Adibags Legion Filters
Adds AdiBag filters for
- Artifact Power
- Ancient Mana
- Artifact Relics
- Champion Equipment
- Champion Upgrades
- Bait
- Rare Fish
- Legion Reputation items
- Broken Shore items
Adds text to icons for the amount of Artifact Power or Ancient Mana an item gives.
Is an item not in the right section? Have a section you would like to see? Leave a comment below.
Press sort, close bags, open bags, keystone will be there. It's a goofy workaround, but it works.
Thanks for this workaround. I played around with it and found that it doesn't work 100% of the time. I discovered it only works when the Keystone changes position in your inventory. It then inherits the item information of the item it swapped spots with and then shows up. It will even inherit information about an empty slot and show up there. This lets me know there is a deeper issue at play here that might be responsible for the bug that causes other items to not appear in AdiBags.
p.s. Mythic Keystones not appearing is because Mythic Keystones no longer have an itemLink they have their own link type in 7.2 which AdiBags doesn't currently handle.
Legowxelab2z8 if the AdiBags addon is not getting updated anymore can you take it over?
What should be done with the druid quest reward Enchanted Bark? It seems like it should be classified with class order hall items, but it's not champion equipment or an upgrade.
They could probably be added to the Champion Equipment/Upgrades section. Every class gets a one time quest reward that summons troops. I didn't add them because they are a one time reward and there was no easy way for me to make a list of all of them since they use a server side script spell effect and not one of the Add Follower Ability or Add Follower Level effects like the other Garrison Equipment or Upgrades use.
Hmmm... I never saw - or remember - getting anything like it as a reward for my hunter (druid is only my second Legion character). I suspected this one was a one-time reward, so your point is valid that perhaps they should be left to the default category. If they can't easily be included as a group, then the reward doesn't justify the effort. I can certainly drag them over manually as I encounter them for my own memory-addled OCD satisfaction.
What do the latest 1.4.3 changes do to categorizations? I haven't seen changes firsthand, but might not have the affected items at the moment. Maybe some new screenshots showing the newly affected items?
Addendum: Nice addition, overlaying the AP amount on the icons!
From a user perspective 1.4.3 just updated the item tables that the addon relies on to categorize items. The categories are still the same as they were, but should be updated for any changes missing from patch 7.1.5
Most of the changes in 1.4.3 were behind the scenes updates to the data extractor that will make it easier for me to keep the item tables up to date. The data the addon relies on is in the game files but cannot be accessed through ingame addons. I use Luacasc to extract the data from the game files and create the itemTables.lua file that the addon can use ingame to categorize items. If itemTables.lua is missing information then the ingame addon will not be able to properly categories them, which is what was happening with the Ancient Mana items.
Didn't the changelog specifically mention that reputation items would now match the filter? I've been growing a manual Reputation category, so I'm curious to see what might get shifted.
version 1.4.4 adds reputation items. for the following factions:
Conjurer Margoss
Court of Farondis
Dreamweavers
Highmountain Tribe
The Nightfallen
The Wardens
Valarjar
This was just a dump of the factions listed in my characters reputation tab under the heading Legion. If I have missed a faction let me know.
I get this error when i log onto every one of my toons, other than that, the addon works superbly
Date: 2017-03-02 18:07:33
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\AdiBags\core\Filters.lua line 128:
Usage: NewModule(name, [prototype, [lib, lib, lib, ...]): 'name' - Module 'Legion' already exists.
Debug:
[C]: ?
...AddOns\ElvUI\Libraries\AceAddon-3.0\AceAddon-3.0.lua:270: NewModule()
AdiBags\core\Filters.lua:128: RegisterFilter()
...ns\AdiBags_Legion_Filters\AdiBags_Legion_Filters.lua:25: in main chunk
Locals:
(*temporary) = "Usage: NewModule(name, [prototype, [lib, lib, lib, ...]): 'name' - Module 'Legion' already exists."
AddOns:
Swatter, v7.3a.5701 (TasmanianThylacine)
AddOnSkins, v3.47
AdiBags, vv1.9.4
AdiBagsBoEBoA, vv1.5
AdiBagsHearthstones, v7.1-release5
AdiBagsLegion, vv1.6
AdiBagsLegionFilters, vv1.4.3
Babylonian, v5.1.DEV.332(/embedded)
Configator, v5.1.DEV.406(/embedded)
ElvUI, v10.44
Gatherer, v7.0.4
LibSharedMedia30, v3.0-97
SharedMedia, v3.0.7-188
SlideBar, v7.3a.5701 (TasmanianThylacine)
BlizRuntimeLib_enUS v7.1.5.70100 <none>
(ck=1c0)
This addon, AdiBagsLegionFilters, and a different addon AdiBagsLegion are not compatible with each other. They both try to register a filter called "Legion" and that is why you are getting an error. You can solve this by uninstalling one of the addons.
Leyscale Koi reasonably ought to be captured by this filter, since it has no use other than increasing Ancient Mana reserves. Hopefully that doesn't conflict with the AdiBags - Tackle Box plugin filter (certainly shouldn't).
I have forked this and added Leyscale Koi, as well as the two items mentioned by the previous poster from earlier this month that received no response. For anyone who would like to fork it as well, in the file Addons/AdiBags_Legion_Filters/ItemTable.lua find this code section:
Then before the closing bracket, add the following:
You might be inclined to save a backup of the original in a Zip file before you do this, as well as save a copy of your modified file. If you use Curse to manage addon updates, it will declare the addon as "modified" and avoid updates unless and until you tell it to ignore the modification. Forcing a reinstall of the addon will of course overwrite your alterations.
Thank you for your contribution. I have updated the backend data exporting and did a new data export which should have all of the Ancient Mana items that are currently in the game. You will need to restart World of Warcraft for the game to load the new data tables.
I reverted to baseline, and indeed things still seem to be categorized the same as my alterations. Thank you.
New items that should be included. These are mostly from the Mana shoulder enchant:
http://www.wowhead.com/item=143734/ancient-mana-crystal-cluster
http://www.wowhead.com/item=143733/ancient-mana-shards
I added them myself. See my post and self-reply above.
I like to save my Rep items till Darkmoon Faire and was wondering if you could add a section for Reputation item? I can add them but figured this could be integrated into your addon.
How about Tradeskill items in Legion? I see you have fish and bait, I wonder if people would be interested in Cloth, Leather, Meat, Herbs and Ore.
I added a section for Legion Reputation items.
Tracking of Tradeskill items is already done by the "Item category" filter that is part of AdiBags. The Fish and Bait part of this addon filters the rare fish (the ones that give +fishing or +artifact power for the legendary fishing rod) and bait items that don't show up as Tradeskill items, and would otherwise get filtered as generic Consumables.