9.0 Update #56


Open
  • jaserival created this issue Oct 15, 2020

    I know this probably a longshot, but I remember someone posting a fix that made AllPlayed work in 8.0

    ...now we're in 9.0 so it's broken again/the 8.0 fix no longer works.  Anyone out there who can fix this?

  • Zorcan2112 posted a comment Oct 15, 2020

    I'm no expert, but I've managed to get it to work for myself.  Or at least, it seems to be working, with no errors.

     

    I updated lines 44 through 47 with:

     

    local GetHonorCurrency = _G.GetHonorCurrency or function() return select(2,C_CurrencyInfo.GetCurrencyInfo(392)) or 0 end

    local GetConquestCurrency = _G.GetConquestCurrency or function() return ( C_CurrencyInfo.GetCurrencyInfo and select(2,C_CurrencyInfo.GetCurrencyInfo(390)) ) or 0 end

    local GetJusticeCurrency = _G.GetJusticeCurrency or function() return ( C_CurrencyInfo.GetCurrencyInfo and select(2,C_CurrencyInfo.GetCurrencyInfo(395)) ) or 0 end
    local GetValorCurrency = _G.GetValorCurrency or function() return ( C_CurrencyInfo.GetCurrencyInfo and select(2,C_CurrencyInfo.GetCurrencyInfo(396)) ) or 0 end

     

    And updated line 360 to:

     

    self.max_pc_level = GetMaxLevelForLatestExpansion()

     

     


    Edited Oct 15, 2020
  • jaserival posted a comment Oct 15, 2020

    Thanks! that seems to have at least made the timers start working again. When I mouseover on it on TitanPanel it's still not showing anything but I'm not sure if that's because of AllPlayed or because of TitanPanel which I don't think has had a 9.0 update yet either.

  • Zorcan2112 posted a comment Oct 15, 2020

    That could be it.  I am running the Titan Panel alpha version, which was updated back at the end of August for Shadowlands beta.  It seems to be working for me for the pre-patch, so you may want to try installing the Titan Panel alpha version

  • Forge_User_59970619 posted a comment Oct 16, 2020

    Hi, could someone who have Allplayed working for the 9.0 update upload it anywhere for me ?

     

    This addon is really great but I can't patch it :( it never works.

     

    Thx

  • Zorcan2112 posted a comment Oct 16, 2020

     I uploaded my updated version here, for anyone who wants it and doesn't want to do the updates I indicated above.  Hopefully this will work for you.

     

    https://jmp.sh/SFjLEq3

     

    Bear in mind, you will still need to update Titan Panel to the alpha version in order for it to work correctly in Titan Panel.

     

    See below for updated version link


    Edited Oct 18, 2020
  • jaserival posted a comment Oct 16, 2020

    Thanks!  I'll give it a try!

    -edit- it now works in the top bar but the mouseover menu doesn't show even with Titan alpha - it shows on all my other addons though. I'm not sure if its an isolated thing - but I am glad the playtime can show on the bar and is doing its thing again


    Edited Oct 16, 2020
  • Zorcan2112 posted a comment Oct 17, 2020

    This is what I see when I mouseover it on  Titan Panel: https://ibb.co/ZYZWYt3 

     

    Do you see something different?

     


    Edited Oct 17, 2020
  • Forge_User_59970619 posted a comment Oct 17, 2020

    Hi, thx for your upload.

     

    I've the same problem as jaserival, I've the playtime of my current character but not the same thing on your screen.

     

    Maybe a problem of language. I'm french so it could be the problem.

     

    I'll check on the lua files if their is differences. Maybe that's will solve the problem.

     

    edit: It have try to copy the lua allPayed-enUS in AllPlayed-frFR and I can see changes (but don't work). Now I can see in menu Interface some action I can check or uncheck. And when I remove Titan Panel to see if it was this add that broke AllPlayed the option in Interface for AllPlayed disapear.
    So I suppose that you have another add-on that make AllPlayed works fine but which one :S

    If someone have an idea or have the solution.

     

    Thanx.


    Edited Oct 17, 2020
  • jaserival posted a comment Oct 17, 2020

    Hey Zorcan, yeah, the problem is the overlay window doesn't seem to appear at all.  All the other Addons I use have their overlays and The Titan Panel menu shows up when I right click an empty area on Titanpanel.  I can't seem to figure out what the variable seems to be.  I might try to add just Titanpanel then re-add my other titan addons one at a time until i can figure out if any of them have a conflict.

    --Update
    Tried disabling them one after another until AllPlayed was the only deal on, and still no luck getting the mouseover menu to appear again


    Edited Oct 17, 2020
  • Zorcan2112 posted a comment Oct 18, 2020

     OK.  Well, two things I noticed.  One, I guess I had made a couple other changes to a couple lines that I hadn't mentioned in my initial post.  That being said, everything that was in the file I uploaded and shared, is exactly what I am using myself.  But, just to document my changes more precisely, I'll mention them here too.

     

    I also changed line 387:

    Old:

    self:RegisterEvent("MINIMAP_ZONE_CHANGED", "EventHandler")

    New:

    --self:RegisterEvent("MINIMAP_ZONE_CHANGED", "EventHandler")

     

    Line 396:

    Old:

    self:Hook("Logout", true)

    New:

    self:RegisterEvent("PLAYER_LOGOUT", "Logout")

     

    Line 398:

    Old:

    self:Hook("Quit", true)

    New:

    self:RegisterEvent("PLAYER_QUITING", "Quit")

     

    Otherwise, everything I have is exactly the same as release version of AllPlayed v70100-1.  And, as I said, what I am using is exactly what I uploaded in the link above.

     

    The other thing I will mention is the TitanPanel team has now uploaded a release version of TitanPanel, as of three hours ago.  So, you may want to try updating your version of TitanPanel to the latest version, and see if that fixes your issues.

     

    If that doesn't work, do you get any sort of LUA errors when you log onto a character?  Or if I can see a screenshot of what you are seeing, perhaps I might get an idea of what is causing the issue you are experiencing.

     

  • TeHbZShadow posted a comment Oct 18, 2020

    I am using last Titan Panel version and your zip file addon

    Message: ...ce\AddOns\AllPlayed\libs\LibQTip-1.0\LibQTip-1.0.lua:519: attempt to call method 'SetBackdrop' (a nil value)
    Time: Sun Oct 18 11:21:47 2020
    Count: 1
    Stack: ...ce\AddOns\AllPlayed\libs\LibQTip-1.0\LibQTip-1.0.lua:519: attempt to call method 'SetBackdrop' (a nil value)
    [string "@Interface\AddOns\AllPlayed\libs\LibQTip-1.0\LibQTip-1.0.lua"]:519: in function <...ce\AddOns\AllPlayed\libs\LibQTip-1.0\LibQTip-1.0.lua:513>
    [string "@Interface\AddOns\AllPlayed\libs\LibQTip-1.0\LibQTip-1.0.lua"]:126: in function `Acquire'
    [string "@Interface\AddOns\AllPlayed\AllPlayed.lua"]:824: in function `DrawTooltip'
    [string "@Interface\AddOns\AllPlayed\AllPlayed.lua"]:2623: in function <Interface\AddOns\AllPlayed\AllPlayed.lua:2622>
    [string "@Interface\AddOns\Titan\LDBToTitan.lua"]:327: in function <Interface\AddOns\Titan\LDBToTitan.lua:286>

    Locals: tooltip = <unnamed> {
    0 = <userdata>
    scrollChild = <unnamed> {
    }
    scrollFrame = <unnamed> {
    }
    }
    key = "AllPlayedTooltip"
    backdrop = <table> {
    backdropColor = <table> {
    }
    edgeSize = 16
    tileEdge = true
    backdropBorderColor = <table> {
    }
    tileSize = 16
    edgeFile = "Interface/Tooltips/UI-Tooltip-Border"
    tile = true
    bgFile = "Interface/Tooltips/UI-Tooltip-Background"
    insets = <table> {
    }
    }
    (*temporary) = nil
    (*temporary) = <unnamed> {
    0 = <userdata>
    scrollChild = <unnamed> {
    }
    scrollFrame = <unnamed> {
    }
    }
    (*temporary) = <table> {
    backdropColor = <table> {
    }
    edgeSize = 16
    tileEdge = true
    backdropBorderColor = <table> {
    }
    tileSize = 16
    edgeFile = "Interface/Tooltips/UI-Tooltip-Border"
    tile = true
    bgFile = "Interface/Tooltips/UI-Tooltip-Background"
    insets = <table> {
    }
    }
    (*temporary) = "attempt to call method 'SetBackdrop' (a nil value)"
    GameTooltip = GameTooltip {
    BottomLeftCorner = <unnamed> {
    }
    OnBackdropLoaded = <function> defined @Interface\SharedXML\Backdrop.lua:205
    textLeft1Font = "GameTooltipHeaderText"
    GetBackdropColor = <function> defined @Interface\SharedXML\Backdrop.lua:443
    SetBackdropBorderColor = <function> defined @Interface\SharedXML\Backdrop.lua:475
    RightEdge = <unnamed> {
    }
    textRight2Font = "GameTooltipText"
    ApplyBackdrop = <function> defined @Interface\SharedXML\Backdrop.lua:347
    SetBackdrop = <function> defined @Interface\SharedXML\Backdrop.lua:382
    ClearBackdrop = <function> defined @Interface\SharedXML\Backdrop.lua:335
    TopOverlay = <unnamed> {
    }
    GetBackdropBorderColor = <function> defined @Interface\SharedXML\Backdrop.lua:462
    GetBackdrop = <function> defined @Interface\SharedXML\Backdrop.lua:400
    SetBorderBlendMode = <function> defined @Interface\SharedXML\Backdrop.lua:319
    comparing = false
    BottomRightCorner = <unnamed> {
    }
    shoppingTooltips = <table> {
    }
    TextLeft1 = GameTooltipTextLeft1 {
    }
    0 = <userdata>
    ItemTooltip = <unnamed> {
    }
    SetupTextureCoordinates = <function> defined @Interface\SharedXML\Backdrop.lua:267
    OnBackdropSizeChanged = <function> defined @Interface\SharedXML\Backdrop.lua:235
    BottomOverlay = <unnamed> {
    }
    Center = <unnamed> {
    }
    HasBackdropInfo = <function> defined @Interface\SharedXML\Backdrop.lua:331
    textRight1Font = "GameTooltipHeaderText"
    BottomEdge = <unnamed> {
    }
    GetEdgeSize = <function> defined @Interface\SharedXML\Backdrop.lua:241
    updateTooltip = 0.069000
    textLeft2Font = "GameTooltipText"
    TopEdge = <unnamed> {
    }
    TextRight2 = GameTooltipTextRight2 {
    }
    TextLeft2 = GameTooltipTextLeft2 {
    }
    TopRightCorner = <unnamed> {
    }
    TopLeftCorner = <unnamed> {
    }
    backdropInfo = <table> {
    }
    needsReset = true
    SetupPieceVisuals = <function> defined @Interface\SharedXML\Backdrop.lua:299
    SetBackdropColor = <function> defined @Interface\SharedXML\Backdrop.lua:452
    LeftEdge = <unnamed> {
    }
    TextRight1 = GameTooltipTextRight1 {
    }
    }
    AcquireTable = <function> defined @Interface\AddOns\AllPlayed\libs\LibQTip-1.0\LibQTip-1.0.lua:493
    labelProvider = <table> {
    cells = <table> {
    }
    cellMetatable = <table> {
    }
    cellPrototype = <table> {
    }
    heap = <table> {
    }
    }
    CELL_MARGIN_H = 6
    CELL_MARGIN_V = 3

     

  • Zorcan2112 posted a comment Oct 18, 2020

    OK, I think I know what might be happening.  Just a guess though.  The LibQTip library I have included in the file I uploaded is an older version, that hasn't been updated for the changes introduced with Shadowlands.  However, I have a few other addons that I have updated, that are using the updated LibQTip library and that might be why it is working correctly for me.  I can try re-uploading my copy of AllPlayed with an updated LibQTip library.  That perhaps may work for you.

     

    Here is an updated version I uploaded, with the updated LibQTip library included.  Hopefully this works for you all!

     

    https://jmp.sh/87bCNjW


    Edited Oct 18, 2020
  • TeHbZShadow posted a comment Oct 18, 2020

    Ty, last update is working for me with TitanPanel.

  • jaserival posted a comment Oct 18, 2020

    Thanks Zorcan!  That worked, and now everything is back to normal!  I appreciate your fixes to this!

  • Forge_User_59970619 posted a comment Oct 19, 2020

    It works!

     

    Thank you Zorcan.

  • serious2 posted a comment Nov 27, 2021

    LibQTip-1.0 has just been updated (Nov 3, 2021: update for WoW 9.1.5's new TooltipBackdropTemplate).
    If you are having errors with AllPlayed, download the latest LibQTip-1.0. It fixed the addon for me.


To post a comment, please login or register a new account.