WowAce

Is anyone using the build Riv24 shared?  It certainly fixes the issue with Mythic keystones, however it won't show newly acquired items without a bag refresh, closing/opening bags, or acquiring a second item of the same kind.

Dear Mr. Baggalo Baggins

As of 7.3.5 my baggins are staying forever closed.  I now get LUA ERROR: 000001EECEE1DCA0.  I have used this addon since release and I cannot seem to move on to another bag addon... I have tried... "I just can't quit you", Baggins.  SO, anyone that can fix this... I am begging you, please update this addon.  I have tried going to a previous update and that also does not fix it.  Thanks.

Hi everyone,

Since the devs have been quiet I've made available a new version of the addon which supports mythic keystones, you can get the download link from my comment over on the wowace page: https://www.wowace.com/projects/baggins#c148

Cheers

thanks a lot.. great job!

Hello fellow Baggins fans!

I've used this addon for literally as long as I can remember playing the game. I can't imagine playing without it, so since there have been a few issues lately and devs have gone quiet I thought I would jump in and quickly clean a few things up.

The main issues lately have been around Mythic Keystones, as many people have pointed out below. I've gone through and fixed most functionality for this, as well as a couple of other things. Changes are as follows:

1. Fixed issue where baggins will not open if you have a mythic keystone in invetory
   • The reason for this is because blizzard changed how links work for keystones
   • I also added more stability for handling battle pets, same reason for issue
2. Added (alt+rightclick) menu support for mythic keystones and battlepets
   • You can now use this to see the item info, as well as options to manually "Add/exclude from category"
   • This now supports adding the item to a specific category
3. Keystones are now picked up in custom categories filtered by item types
   • This means if you create a category and select: ItemType="Reagent", ItemSubType="Keystone", this will now find and include your keystones

I haven't tested many of the other custom category rules, such as using item name or tooltip contains etc, but I expect they should work fine. If not, just use the item type rule that I added above.

Full disclosure:

I am not part of the development team for this addon so any issues you might have downloading from my link should not reflect on them.

Download link:

This is hosted on my personal Google Drive

https://drive.google.com/uc?export=download&id=0B5-oQfU6OJ8BY3F2WUpKNnhCb3M

For the Devs:

I would imagine that you use some kind of version control, but if not then I have added a comment beside my changes if you wanted to review and add to the main project in the form:

-- Riv:

Cheers!

For anyone getting 1-2 sec of frame drops/stutter every minute (mostly caused by having many category rules - espeically tooltip rules I suspect) you can comment out line 414:

self:ScheduleRepeatingTimer("RunItemCountUpdates", 60)

Should stop the stuttering, only downside I can see is new items won't update and get removed from the new section if they stop being new while your bags are open.

The other option is to just disable new items entirely, by setting New Item Duration in the general settings to 0.

I got an error when i have a Mythic Keystone on 7.2.5, the fix is:

Baggins-Filtering.lua at line 305 add:

     if( speciesID ) then

And after

          iteminfo = PET_CAGE_ITEM_ID .. " " .. 1 .. " " .. name

Add:

      end

Hi,

Bug report, if this can be useful :

Message: ...Ons\Baggins\libs\LibGratuity-3.0\LibGratuity-3.0.lua:52: script ran too long
Time: 07/14/17 19:49:20
Count: 1
Stack: ...Ons\Baggins\libs\LibGratuity-3.0\LibGratuity-3.0.lua:52: script ran too longInterface\SharedXML\SharedBasicControls.lua:204: in function <Interface\SharedXML\SharedBasicControls.lua:203>
[C]: in function `ClearLines'
...Ons\Baggins\libs\LibGratuity-3.0\LibGratuity-3.0.lua:52: in function `Erase'
...Ons\Baggins\libs\LibGratuity-3.0\LibGratuity-3.0.lua:211: in function `SetBagItem'
Interface\AddOns\Baggins\Baggins-Filtering.lua:1296: in function `Matches'
Interface\AddOns\Baggins\Baggins-Filtering.lua:359: in function <Interface\AddOns\Baggins\Baggins-Filtering.lua:330>
Interface\AddOns\Baggins\Baggins-Filtering.lua:409: in function `OnSlotChanged'
Interface\AddOns\Baggins\Baggins-Filtering.lua:320: in function `CheckSlotsChanged'
Interface\AddOns\Baggins\Baggins-Filtering.lua:472: in function `ForceFullUpdate'
Interface\AddOns\Baggins\Baggins.lua:3594: in function `OpenBag'
Interface\AddOns\Baggins\Baggins.lua:3632: in function `OpenAllBags'
Interface\AddOns\Baggins\Baggins.lua:3661: in function <Interface\AddOns\Baggins\Baggins.lua:3647>
(tail call): ?
[string "OPENALLBAGS"]:1: in function <[string "OPENALLBAGS"]:1>

Locals: errorMessage = "...Ons\Baggins\libs\LibGratuity-3.0\LibGratuity-3.0.lua:52: script ran too long"
DisplayMessageInternal = <function> defined @Interface\SharedXML\SharedBasicControls.lua:187
MESSAGE_TYPE_ERROR = 0

This addon had been working fine for me, however today it randomly stopped updating things in my bag. I tried re logging and upon logging in I could not open my bags at all anymore. I tried uninstalling the addon and deleting my WTF folder and reinstalling backups I had of my UI from a few days ago that works fine on another computer and still I cannot open my bags with baggins. If I type /baggins the options open and everything seems like it's functioning but I cannot open my bags?

Noticing frame stutter very frequently with the keystone in bags while baggins is loaded. It happens less frequently and less severely without a keystone, but its still there.

The lag from bags being open during combat has something to do with the callback handler, fwiw.

My coding skills are horrible ... does anyone know how I would be able to embed the following LIB into Baggins? 

https://mods.curse.com/addons/wow/libpt-muffinsets&nbsp;

It's a more updated alternative/add-on for LibPeriodicTable-3.1. 

Thanks in advance!

In reply to Innovindil:

 local link = GetContainerItemLink(bag, slot)
 local realId = GetContainerItemID(bag, slot)
 local itemCount = select(2, GetContainerItemInfo(bag, slot))
 local itemid
 if link then
     if realId == 138019 then -- It's a mythic Keystone
         itemid = 138019
     else
         itemid = link:match("item:(%d+)")
     end
     if itemid then -- it's not a battle pet

If you compare these lines to what is there you should be able to see what is actually different (and I added a comment on what my comparison is doing). I would recommend this over what DarthEberron has.  It is still a brittle hack but it's good enough for now for me.

OMG, it works!  Thank you so much!

Not sure if I replaced too many lines or what but now very little appears in my bags, but otherwise they work.

This is working for for 7.2 with this patch:

Baggins-filtering.lua line 305, first and last line added by Bruj0 from wowace forums:

if speciesID ~= nil and speciesID ~= '' then
local name, icon, petType, creatureID, sourceText, description, isWild, canBattle, tradable, unique= C_PetJournal.GetPetInfoBySpeciesID( speciesID )
itemid = - tonumber(petid) -- use negative itemid values for battle-pets
if itemid == 0 then
itemid = - tonumber(speciesID)
end
iteminfo = PET_CAGE_ITEM_ID .. " " .. 1 .. " " .. name
end

So I just paste that into line 305?

See my response on the project site for a better explanation of how to implement this fix:

https://www.wowace.com/projects/baggins#c136

Thank you so much for this explanation on how to fix Baggins!  It's working great for me now.