Guildmate names not class colored since 5.4.2 #282


  • New
  • Defect
Open
Assigned to moonfann
  • Cilraaz created this issue Dec 10, 2013

    What steps will reproduce the problem?
    1. Update WoW to 5.4.2
    2. Login
    3. Have a guildmate talk in /g

    What is the expected output? What do you see instead?
    Expected to see the names in the appropriate class colors.  Names are grey instead.

    What version of the product are you using?
    1.4.4-2-g4fbe5e5

    Do you have an error log of what happened?
    No.

    Please provide any additional information below.
    I was able to fix this with a few lines of code.  It may not be the prettiest hack, but it seems to work and might be a start for you guys.

    \Modules\PlayerNames.lua - Insert after line 311 (realm.names table initialization):

    local randomPointerName = string.find(name, "-")
    if randomPointerName ~= nil then
        local name = string.sub(name, 1, randomPointerName-1)
    end

    It seems guild names are reported to the addon as Name-Server, so this just strips the "-Server" when the name is seen for the first time.  It has worked in local testing.  There might be a better place in the code for this (or a better method overall), but since pretty much every other function calls AddPlayer, it seemed best to put it there.

  • Cilraaz added the tags New Defect Dec 10, 2013
  • Cilraaz posted a comment Dec 22, 2013

    I've shortened up the above code a bit:

    if string.find(name, "-") ~= nil then
      name, _ = string.split("-", name)
    end

  • OttoDeFe posted a comment Jan 1, 2014

    Cilraaz - when I put your patch after line 311 I produce an error:

    Interface\\AddOns\\Chatter\\Modules\\PlayerNames.lua:312: bad argument #1 to 'find' (string expected, got nil)
    

    My line 311 is the end statement for the realm.names table initialization function - what line of code should it be inserted after?


    Edited Jan 1, 2014
  • _ForgeUser2265545 posted a comment Feb 19, 2014

    I got it to work with adding the following line at line 514 of Chatter/Modules/PlayerNames.lua (make it the first line in changeName)

    name = Ambiguate(name, "none")
    

    Not sure if it's the ideal fix though as I know too little of Chatter's internal workings.

  • Stanzilla unassigned issue from ardentvark Oct 24, 2014
  • Stanzilla assigned issue to moonfann Oct 24, 2014

To post a comment, please login or register a new account.