Queue doesn't update when crafting materials are collected from the bank #427


  • Accepted
  • Patch
Open
Assigned to _ForgeUser280725
  • _ForgeUser9301305 created this issue Sep 11, 2012

    Potential bug fix for:
    The Queue window does not update correctly when crafting materials are collected from the bank.

    Example:
    In the main window click QUEUE to craft an item that has materials in the bank.
    Minor Glyph of Porcupine is selected and QUEUE is clicked.
    The Queue window shows there are 10 Stranglekelp in the bank.
    Go to then bank, talk to the teller and open the bank bags.
    Click on the Queue window Reagent line "bank" -or- reagent line "Stranglekelp" and the materials are collected from the bank into your inventory bags.
    The Reagent window will incorrectly show
           Vendor
    3     Midnight Ink
           Missing
    3     Ink of Dreams.

    The workaround was to clear the queue then requeue the Glyph with the materials in inventory.  It would progress to the next step of milling the herbs.

    *** Here is a potential fix that needs verified:  ***

    Queue.lua line 318
    Comment out "Return 0"
    from
                if not reagentsChanged then
                    AddItemsToShoppingList(player, entry)
                    Return 0
                end
    to
                if not reagentsChanged then
                    AddItemsToShoppingList(player, entry)
    --              Return 0
                end

    Now when materials are collected from the bank the Queue window correctly updates to
    [Process Mill Stranglekelp x 2]

    I haven't noticed any new bugs yet so please verify with testing.

  • _ForgeUser9301305 added the tags New Patch Sep 11, 2012
  • _ForgeUser9301305 edited description Sep 11, 2012
  • mishikal1 posted a comment Sep 13, 2012

    I applied this patch, so far all good, and it works great with grabbing stuff from the bank

  • _ForgeUser9301305 edited description Sep 16, 2012
  • _ForgeUser8814248 posted a comment Sep 30, 2012

    fixed in r190

  • _ForgeUser8814248 posted a comment Oct 2, 2012

    @remcoros: Go

    I reverted this fix because it breaks reagent calculation logic.

    I am going to have another look at this issue.

  • _ForgeUser280725 posted a comment Oct 2, 2012

    yeah, i'm not surprised this breaks something else...

    i've tried to make the queue not recalculate too frequently, but still present up to date information. it could be that it doesn't recalculate properly after collecting the bank items. possible tests would be to do other manipulations to the queue adding items, adjust counts, selecting different sources. see if any of those result in proper recalculation.


    Edited Oct 2, 2012
  • WildCard_25 removed a tag New Oct 16, 2012
  • WildCard_25 added a tag Accepted Oct 16, 2012

To post a comment, please login or register a new account.