heals-incoming and my-heals-incoming both use the 'include player heals' option from the incoming-heals status #1027


Closed
  • Trelmarq created this issue Aug 13, 2021

    What version of Grid2 and game type (classic or retail) are you using ?

    2.0.15 retail

    What game client version (windows or mac) and language are you using ?

    9.1.0

    What steps will reproduce the problem?

    Casting an incoming heal with 'my-incoming-heals' showing as a bar, but the 'include player heals' option turned off in 'incoming-heals'

     

    Did you try having Grid2 as the only enabled addon and everything else disabled?

    yes

    Was it working in a previous version? If yes, which was the last good one?

    No idea, first version I've used

     

    Do you have an error log of what happened?

    No lua error, I believe this to be a logic error in code.

     

    Please provide any additional information below.

    I closed my initial report saying I couldn't replicate it, but that was the error, the bug is still happening as stated.

  • michaelsp posted a comment Aug 13, 2021

    I don't understand what you mean. You did not explain what is the bugged behaviour.

    "include player heals" option (maybe should say: "include my heals") is irrelevant for my-heals-incoming status (this status always displays heals casted by you).

    Working fine here.


    Edited Aug 13, 2021
  • Trelmarq posted a comment Aug 13, 2021

    That's the problem

     

    'my-heals-incoming' does NOT display my heals incoming if 'include player heals' is unchecked in 'heals-incoming'

     

    The problem is the option in one is affecting the other.

  • michaelsp posted a comment Aug 13, 2021

    I cannot reproduce the issue and nobody reported that strange  behavior before.

    Can you test the issue with a different profile ?

    Can you send me your profile ? (you can export the profile to text format going to profiles tab).

    Which class are you playing ?

     

     

     

  • Trelmarq posted a comment Aug 13, 2021

    I play paladin (ret spec) and my test spell was flash of light.

     

    The only notable things after that I changed that would have any effect here that I can think of

     

    Indicators -> Health -> Layout -> Orientation of Bar -> Horizontal

    Indicators -> Health -> Statuses (Removed 'heals-incoming', added 'my-heals-incoming')

     

    I then flew up and dropped to damage myself, and when I casted the heal, no incoming heal was shown.

    I then went to Statuses -> Health&Heals -> heals-incoming -> Include player heals (checked)

     

    That made the above setup work.  Unchecking it makes it stop

     

    As I've moved a bunch of stuff around, and made unrelated changes I'll backup the saved variables file and redo this all without any moving around frames, etc to get a fresh profile to export for you.

  • Trelmarq posted a comment Aug 13, 2021

    Ok, I'm definitely breaking this somehow.

     

    I have no idea what I managed to do here, now it looks like it reduces my health bar to about 5% and then shows the incoming heal as if the 5% were my health.  After that, it returns to normal.

     

    Here's the export in this state https://pastebin.com/L89Yeeg6

  • michaelsp posted a comment Aug 14, 2021

    Your setup is not correct.

    You linked heals-incoming to health bar, this replaces the unit health bar with an incoming heal bar (when some incoming heal exist).

    You must replace heals-incoming in "heals" bar with "my-heals-incoming".


    Edited Aug 14, 2021
  • Trelmarq posted a comment Aug 14, 2021

    That may have been an error when I tried to replicate the original problem.  That's not how I have it configured on the one I was using.

     

     

    I'll do another fresh setup and share that, one moment.

     

     

  • Trelmarq posted a comment Aug 14, 2021

    I tried to recreate it fresh again: https://pastebin.com/NTzAh3rf

     

    This time no matter what I do, it's not showing the incoming heal at all.

  • Trelmarq posted a comment Aug 14, 2021

    BTW Here's the saved variables file contents from the original post. (This is the one where my-incoming-heals only shows when the box is checked in incoming-heals for 'include player heals')

     

    https://paste.ubuntu.com/p/c3cc9yPJWM/

    (Used ubuntu paste for syntax highlighting)

  • michaelsp posted a comment Aug 14, 2021

    The incoming heals are not displayed because you did not select a color (so the heal bar is being displayed in a full transparent color).

    You must go to heals / Colors tab, and select a color status to colorize the bar.


    Edited Aug 14, 2021
  • Trelmarq posted a comment Aug 14, 2021

    That works on a fresh profile.

     

    I'd have thought it would've defaulted to the color defined for the status if it wasn't explicitly set in the colors section. 

     

    I can't replicate the original issue on a fresh profile, so I'll close this out and just rebuild from scratch.

     

    Thank you for the assistance.  If it starts happening again, I'll look through the code and see if I can't find anything but as I cannot get the original issue on a fresh profile, I'll have to say I'm good, so thanks again.

     

     

  • michaelsp closed issue Aug 18, 2021

To post a comment, please login or register a new account.