WowAce

What version of Grid2 and game type (classic or retail) are you using ?

2.0.52-wrath

What game client version (windows or mac) and language are you using ?

windows 7

What steps will reproduce the problem?

When members get on vehicles, replace pet frame with vehicle frame. This would help a lot for encounters like Malygos. It also seems that for a lot of cases with vehicles.

so I enable "Toggle for vehicle" option in

General/Layouts/General Tab. But it doesn't work. When I solo some vehicle quests, it's still two frames(player and vehicle).

Did you try having Grid2 as the only enabled addon and everything else disabled?

 yes

Was it working in a previous version? If yes, which was the last good one?

no

Do you have an error log of what happened? 

no errors

Please provide any additional information below.

The vehicle swap and toggle for vehicle option does not work well in classic, It is a bug in blizzard code, i cannot fix this issue. The issue was already reported to blizzard.

thanks.but i noticed that vuhdo has fixed it. I tested it in wyrmrest temple daily quest. 

Vuhdo does not use blizzard code to display the unit frames, so they can replace the frames, but only when out of combat.

This is the reason grid2 can update unit changes (player group changes, player raid join, player raid leave) in the middle of a combat (this is an action restricted to blizzard code) but Vuhdo can't.

I implemented a ugly workaround in version 2.0.54 for non-blizzard frames, this means that the "Use Blizzard Unit Frames" option should be unchecked, this option is in General/Layouts/General Tab.

But keep in mind that this is a last resort solution, using non-blizzard unit frames can generate other issues and glitches (a lot of things can't work while in combat).

I dont event know if the implemented workaround works in raid, because players cannot be in combat while the player units are replaced by the vehicles and I only tested the workaround in boreal tundra vehicle quest.

I tried out this fix on the Malygos fight today. It didn't seem to work. There were no vehicle frames at all during the vehicle phase, and the frames all appeared the moment the boss died (they were additional frames, and didn't replace the player frames)

I had the exact same issue as gruten_ there were no vehicles frames at all during malygos, rather it just showed player frames. They all came up after the boss died like they were pet frames.

I implemented a different workaround in version 2.0.55-beta, but its not perfect, the real fix must be provided by a blizzard patch in the game client. Important:

1. "Use Blizzard Raid Frames" option in General/Layouts must be ENABLED (the opposite of previous workaround).

2. The fix is only enabled in Malygos and Oculus instances.

3. Targeting is only fixed for Grid2 default left-click, this means clique targeting/heals or mouseover macros are not going to work. If you have bindings for healing/targeting in clique for left-click, you are overriding the default grid2 left-click so this workaround are not going to work. To avoid this issue without removing clique keybindings, you can use some modifier leftclick not used in clique for targeting, valid mouse/keybindings for targeting are: LeftClick, SHIFT-LeftClick, CTRL-LeftClick or ALT-LeftClick.

I just cannot delete my screenshot above, but yeah 2.0.55-beta fixed this issue. Player frames are replaced by pet frames and it looks nice, but sometimes it doesn't refresh theirs health status. Only /reload helps. It doesn't work even when i am out of combat.

Unfortunatelly i have not a max level toon  yet and i cannot test these changes.

Can you tell me how did you test this thing out of combat ? As far as i know in malygos players are always in combat. Maybe in oculus ?

Any thing to do to trigger the health not refreshed glitch, or is it random ?

Can happen with your own vehicle ? Does it just become bugged when someone enters on the vehicle or could happen later ?

Thanks for your feedback.

Amazing, there are two different bugs there, the game reports that the player entered in a vehicle that don't exist yet, this is the reason grid2 is displaying partypet1, because partypet1 (the vehicle) did not exit (or at least the game  says dont exist at this point).

Another bug is that the game is forgeting to send health events of some pets, its seems internally the game thinks too that the pet dont exist.

I dont now if it is worth to make trillion of workarounds for this, blizzard should fix its bugged code, i am going to have to use some brute force method to fix this like a timer to update the pet frames every half a second or something like this.

Try 2.0.56-beta-wrath, now if the pet does not exist when the player enters the vehicle the addon trys to reregister the unit after one second  (to give the game some time to create the unit).

Important:

1. "Use Blizzard Raid Frames" option in General/Layouts must be ENABLED (the opposite of previous workaround).

2. The fix is only enabled in Malygos and Oculus instances.

3. Targeting is only fixed for Grid2 default left-click, this means clique targeting/heals or mouseover macros are not going to work. If you have bindings for healing/targeting in clique for left-click, you are overriding the default grid2 left-click so this workaround are not going to work. To avoid this issue without removing clique keybindings, you can use some modifier leftclick not used in clique for targeting, valid mouse/keybindings for targeting are: LeftClick, SHIFT-LeftClick, CTRL-LeftClick or ALT-LeftClick.