Shield absorbs #1241


  • Declined
  • Enhancement
Closed
  • Xhii created this issue Oct 2, 2023

    What version of Grid2  are you using (Version is displayed in General/About Tab) ?

     2.3.20

    What game client version, classic or retail, windows or mac and language are you using ?

    wotlk classic

     

     

    Hello, I've stumbled upon addons like XyzKangUI/Precognito and RomanSpector/UnitFrameLayers that display shield absorbs on frames, but they currently only work with Blizzard frames. Is it possible to integrate them into the Grid2?

  • Xhii added the tags Enhancement Enhancment Oct 2, 2023
  • michaelsp posted a comment Oct 2, 2023

    It seems these addons are using the absorb monitor library: a ten years old abandoned library/code. I am not going to add a ten years old/non maintained library to grid2, because it can stop working with any wow patch.

    If you can find an updated/maintained fork of this library i could change my mind.

  • Xhii posted a comment Oct 3, 2023

    I couldn't find a supported version of the addon. However, I know that many other addons successfully use it, especially on private PvP servers.

    Also, there's only one phase left until the completion of Wrath of the Lich King, and it's unlikely that they will introduce any significant changes. But even if such changes do occur and everything breaks, you can set a condition: if something breaks, you won't bother finding a solution and will simply revert to the previous version of the addon.

    I just really like this feature - it's literally the only thing missing to make grid2 perfect.


    Edited Oct 3, 2023
  • michaelsp posted a comment Oct 6, 2023

    The original LibAbsorb monitor does not work in classic, the version used by the addons your linked is heavy modified, and as far as i know there is not public repository with a clear and valid license to download that version.

    Addons linked are using an "all right reserved" privative license so no code can be used from these versions in another addons.

    I know that is probably not legal, because they cannot convert an open source library in a privative library (at least without permission from the original author), and a GPL licensed library cannot be included with privative code (it is not allowed by the GPL license).

    In short i dont want to mess with that kind of code, i want to avoid future issues so i am not going to add shady code to grid2.

     


    Edited Oct 6, 2023
  • michaelsp added a tag Declined Oct 6, 2023
  • michaelsp removed a tag Enhancment Oct 6, 2023
  • michaelsp closed issue Oct 6, 2023

To post a comment, please login or register a new account.