Create Indicator broken #363


  • Defect
  • Fixed
Closed
Assigned to michaelsp
  • Gethe88 created this issue Aug 24, 2014

    The "Create Indicator" button is always disabled, regardless of the name or settings used.

    What Grid2 version and language of WoW are you using?
    Grid2 r720 WoW 5.4.8

    Do you have an error log of what happened?
    There was no error

    Please provide any additional information below.
    This was tested without any other addons except Buggrabber and BugSack.

  • Gethe88 added the tags New Defect Aug 24, 2014
  • Gragagrogog posted a comment Oct 14, 2014

    There is a text field where you enter name of the new indicator, after you're finished with the name you should press enter or click "Okay" button, after that, "Create Indicator" should be clickable.

  • Gragagrogog removed a tag New Oct 22, 2014
  • Gragagrogog added a tag Invalid Oct 22, 2014
  • Gragagrogog closed issue Oct 22, 2014
  • Gethe88 posted a comment Oct 26, 2014

    r731, no other addons but bugsack/grabber

    name input -> enter
    still disabled
    http://i.imgur.com/dpekNmgl.jpg


    Edited Oct 26, 2014
  • Gragagrogog posted a comment Oct 26, 2014

    Ok, I can't replicate this...

    The code managing this is in Grid2Options\modules\indicators\NewIndicator.lua could pls you add a control print("blablabla") at the beggining of "function NewIndicatorDisabled()" at line 58 and check what it does. It should fire every time anything changes in any new indicator option.

    If it doesn't fire, then it's AceGUI's fault, if it does fire, then replace the NewIndicatorDisabled() with this to see where's the issue:

    local function NewIndicatorDisabled()
    	local name = Grid2Options:GetValidatedName(newIndicatorValues.name)
    	print("checking if '"..name.."' is availible")
    	if name and name ~= "" then
    		if not Grid2.indicators[name] then 
    			local _,frame= next(Grid2Frame.registeredFrames)
    			print("checking '".._.."' for duplicate keys")
    			if frame then
    				-- Check if the name is in use by any unit frame child object
    				for key,value in pairs(frame) do
    					if name==key and type(value)~="table" then
    						print("found duplicate: "..key)
    						return true
    					end
    				end
    				print("new indicator name is ok")
    				return false
    			end	
    		end
    	end
    	print("name doesn't exist or is empty string")
    	return true
    end
    


  • Gragagrogog removed a tag Invalid Oct 26, 2014
  • Gragagrogog added a tag New Oct 26, 2014
  • Gragagrogog reopened issue Oct 26, 2014
  • Gethe88 posted a comment Oct 26, 2014

    @Gragagrogog: Go

    I used that new function and got this:

    1x ...Ons\Grid2Options\modules\indicators\NewIndicator.lua:63: attempt to concatenate local '_' (a nil value)
    ...Ons\Grid2Options\modules\indicators\NewIndicator.lua:63: in function `member'
    ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-59.lua:249: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:197>
    (tail call): ?
    ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-59.lua:1396: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1055>
    ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-59.lua:1588: in function `FeedGroup'
    ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-59.lua:1513: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:1493>
    (tail call): ?
    [C]: ?
    [string "safecall Dispatcher[3]"]:9: in function <[string "safecall Dispatcher[3]"]:5>
    (tail call): ?
    ...eGrid2Options\Libs\AceGUI-3.0\AceGUI-3.0-34.lua:314: in function `Fire'
    ...ibs\8AceGUI-3.0-34\widgets\AceGUIContainer-TreeGroup.lua:518: in function `Select'
    ...ibs\8AceGUI-3.0-34\widgets\AceGUIContainer-TreeGroup.lua:526: in function `SelectByValue'
    ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-59.lua:1684: in function `FeedGroup'
    ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-59.lua:1868: in function `Open'
    ...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0-59.lua:831: in function <...nfig-3.0\AceConfigDialog-3.0\AceConfigDialog-3.0.lua:614>
    (tail call): ?
    [C]: ?
    [string "safecall Dispatcher[3]"]:9: in function <[string "safecall Dispatcher[3]"]:5>
    (tail call): ?
    ...eGrid2Options\Libs\AceGUI-3.0\AceGUI-3.0-34.lua:314: in function `Fire'
    ...ons\Libs\13AceGUI-3.0-34\widgets\AceGUIWidget-EditBox.lua:74: in function <...ons\Libs\AceGUI-3.0\widgets\AceGUIWidget-EditBox.lua:71>
    
    Locals:
    nil
    
  • Gragagrogog posted a comment Oct 26, 2014

    Ok this means Grid2Frame.registeredFrames is an empty table. Which should only be possible if grid2 isn't showing any unit.... Should be fixed in r732.

    So... why would any1 try to create a new indicator when your grid isn't showing any unit?
    http://cdn.alltheragefaces.com/img/faces/jpg/misc-jackie-chan.jpg

    Anyway... thanks for your effort :)

  • Gragagrogog removed a tag New Oct 26, 2014
  • Gragagrogog added a tag Fixed Oct 26, 2014
  • Gragagrogog closed issue Oct 26, 2014

To post a comment, please login or register a new account.