Make invert color usable for more than one bars #420


  • Fixed
  • Patch
Closed
Assigned to michaelsp
  • warbabyy created this issue Mar 1, 2015

    I see there are tickets like http://www.wowace.com/addons/grid2/tickets/321-invert-bar-color-gets-stuck

    But after reading the source codes, I think we may use the bgBar (background color) to implement it.

    Currently the bgBar is attached at the end of the origin bar, not BELOW it. I don't know why.

    IMO, if we always create the bgBar when 'invert color' is enabled and put it below the origin bar, the problem will be solved.

    There is only one problem: the frame level of the bgBar must be changed. and different bar-indicators' levels should have at least 2 interval.

    Sorry for my English. The attachment is a patch for r757, works for me.

  • warbabyy added the tags New Patch Mar 1, 2015
  • warbabyy added an attachment IndicatorBar.patch Mar 1, 2015

    IndicatorBar.patch

    <p>patch for r767</p>

  • warbabyy edited description Mar 1, 2015
  • michaelsp posted a comment Mar 1, 2015

    You have removed the only purpose for the existence of a bgBar ;). The background Bar was coded only to fix a very specific problem, check the image below to see what happens to out of range units when bgBar covers the whole bar:

    http://www.wowace.com/addons/grid2/images/22-bg-bar-alpha-issue/

    I really don't see the point on using inverted colors in a lot of bars, even in a unique bar.

    PD: My english is much worse than yours.


    Edited Mar 2, 2015
  • michaelsp removed a tag New Mar 1, 2015
  • michaelsp added a tag Waiting Mar 1, 2015
  • michaelsp removed a tag Waiting Mar 2, 2015
  • michaelsp added a tag Accepted Mar 2, 2015
  • warbabyy posted a comment Mar 2, 2015

    @michaelspain: Go

    I have been using Grid for a long time, I'd like to use invert color for both health bar and mana bar . In that way, the light color means 'dangerous' (players lost too much health or used too much mana).

    And also, invert color is actually the only way to set dynamic background color for a bar (for example, different power type need different background)

    I will try the way you mentioned to solve this problem, I can guess, 1. create a manabar with color 0,0,0,0.8; 2. create a square indicator below the manabar 3.set it color to power status, that should work

    And I'd like to tell you that in my test, grid2 use less than 1/4 memory and 1/2 cpu compares to grid main addon, not to mention the dozens of subaddons. Great work!

  • michaelsp posted a comment Mar 2, 2015

    @warbaby: Go

    Im going to implement the suggestion without breaking the actual bgBar behaviour:

    -invert colors enabled -> bgBar anchored to the whole main bar

    -invert colors disabled -> current behaviour

    PD: If you want minimal CPU usage, use static colors statuses (they can be created in the colors category) when possible. Linking the bar-color to the mana status, the mana status will update the color of the bar every time the player mana changes, and this is not necessary because the mana-color is always the same. Using a static color status, the color is assigned only once, when the addon is loaded.


    Edited Mar 2, 2015
  • michaelsp posted a comment Mar 2, 2015

    Uploaded an alpha version with this suggestion implemented and some more enhancements (Now the code uses a simple texture for the background instead of a extra statusbar)


    Edited Mar 2, 2015
  • warbabyy posted a comment Mar 4, 2015

    @michaelspain: Go

    oh yeah

  • michaelsp removed a tag Accepted Mar 4, 2015
  • michaelsp added a tag Fixed Mar 4, 2015
  • michaelsp closed issue Mar 4, 2015

To post a comment, please login or register a new account.