WowAce

What steps will reproduce the problem?
1. Sometimes when there is a cinematic during combat/end of combat this error pops up as grid2 tries to load itself in combat

What is the expected output? What do you see instead?

What Grid2 version and language of WoW are you using?
r773 enGB

Do you have an error log of what happened?
1x Grid2\GridCore.lua:190: script ran too long
Grid2\GridCore.lua:190: in function `LoadGrid2Options'
Grid2\GridCore.lua:181: in function <Grid2\GridCore.lua:180>
[C]: in function `Show'
FrameXML\UIParent.lua:2060: in function `SetUIPanel'
FrameXML\UIParent.lua:2130: in function `HideUIPanel'
FrameXML\UIParent.lua:1824: in function <FrameXML\UIParent.lua:1816>
[C]: in function `SetAttribute'
FrameXML\UIParent.lua:2595: in function `HideUIPanel'
FrameXML\CinematicFrame.lua:42: in function <FrameXML\CinematicFrame.lua:30>

Locals:

Please provide any additional information below.

I recent reenabled the posibility to load grid2options addon in combat, it seems i have to revert this change. Loading the module implies a lot of cpu, a lot of lua files to load, it does not fail for me, but a less powerfull cpu or maybe a lot of addons loaded could trigger the 100 ms cpu usage limit.

I think the problem is two parted, one, like you said, loading the config during combat is probably a bad idea and the other that it somehow triggers from right clicking randomly in the world or that cinematic frame.

Are you using a databroker addon (bazooka, etc) , or the minimap Icon ? I have no idea how the load options can be triggered on that scenario, the code is too simple:

OnClick = function(self, button)
	if button=="LeftButton" then
		Grid2:OnChatCommand("grid2")
	elseif button=="RightButton" then
		MenuLayoutsShow()
	end
end,

Bazooka, but I don't even have the Grid2 feed enabled. And yes, it is super weird.

And it happened again, again after a cinematic:

1x Grid2Options\GridCore.lua:70: script ran too long Grid2Options\GridCore.lua:70: in function `MakeOptions' Grid2Options\GridCore.lua:53: in function `Initialize' Grid2\GridCore.lua:208: in function <Grid2\GridCore.lua:207> Grid2AoeHeals\AoeHealsOptions.lua:455: in function <Grid2AoeHeals\AoeHealsOptions.lua:445> Grid2RaidDebuffs\Grid2RaidDebuffs-r774.lua:383: in function `LoadOptions' Grid2\GridCore.lua:193: in function `LoadGrid2Options' Grid2\GridCore.lua:181: in function <Grid2\GridCore.lua:180> [C]: in function `Show' FrameXML\UIParent.lua:2060: in function `SetUIPanel' FrameXML\UIParent.lua:2130: in function `HideUIPanel' FrameXML\UIParent.lua:1824: in function <FrameXML\UIParent.lua:1816> [C]: in function `SetAttribute' FrameXML\UIParent.lua:2595: in function `HideUIPanel' FrameXML\CinematicFrame.lua:42: in function <FrameXML\CinematicFrame.lua:30>

Locals:

It seems that for some reason blizzard code creates the addons list (interface->addons) just after a cinematic start. I changed the code to not load and embed the options in "Interface -> addons" panel. Only a button to open the standalone config window is displayed. r775 must fix the problem.

@michaelspain: Go

That sounds super weird, will test your changes!

I experienced something similar in 2013 (if I remember correctly). The options tried to load after cinematics and even after using the map (in some rare cases). I changed one Grid2Options function to stop this but can't remember which one.

Never happend again since then (with the following update, the function was reset to default but the problem didn't recur).