Grid2 spam while exiting battlegrounds #54


  • Defect
  • Fixed
Closed
Assigned to _ForgeUser117147
  • _ForgeUser3696903 created this issue Dec 21, 2009

    What steps will reproduce the problem?
    1. I can reproduce the error everytime I leave a battleground.
    2. Works with all addons turned off except Grid2.
    3.

    What is the expected output? What do you see instead?
    raid1

    What version of the product are you using?
    Grid2 r288

    Do you have an error log of what happened?
    No, it isn't creating an error inside WoW.  Just the output into chat.

    Please provide any additional information below.
    I've disabled all addons and ran with just Grid2 to make sure that it wasn't something else causing the problems and the issue doesn't happen with my other account that I have the "vanilla" Grid or Grid1 installed on, just the Grid2 accounts.  The text "spam" happens only when leaving a battleground and varies depending on how many groups were in that battleground (i.e. way more for AV as opposed to AB or WSG).

  • _ForgeUser3696903 added the tags New Defect Dec 21, 2009
  • _ForgeUser117147 posted a comment Jan 4, 2010

    What exactly is the text content of these spam messages ?

  • _ForgeUser117147 removed a tag New Jan 4, 2010
  • _ForgeUser117147 added a tag Waiting Jan 4, 2010
  • _ForgeUser342823 posted a comment Jan 4, 2010

    When I exit I typically receive a slew of the following: "Raidxx is not in your party."

    (where xx is an integer between 01 and 40, depending on the number of people in your BG). There is often more than one message for each number.

    I tried the "YouAreNotInAParty" addon on Wowinterface to see if it would clean up the errors but it did not. I'm not in fornt of the client so this is from memory. I can do some better testing later if you have specific questions (like how many messages per player there are).

  • _ForgeUser342823 removed a tag Waiting Jan 4, 2010
  • _ForgeUser342823 added a tag Replied Jan 4, 2010
  • _ForgeUser1198848 posted a comment Jan 5, 2010

    I came to post this very same problem. The messages are in the general chat tab, are colored yellow, and look like this:

    raid1 is not in your party.
    raid8 is not in your party.
    raid12 is not in your party.

      The number following "raid" varies from 1 to about 40, in no particular sort order. They fill my chat log to the point that I cannot see any messages from before they begin. However, after they have stopped I get the normal messages about changing General and LocalDefense chat channels to my new location and the message "You have left the raid group".


    Edited Jan 5, 2010
  • _ForgeUser117147 posted a comment Jan 5, 2010

    Please try with rev292

    If the spam still occurs, please use activate the "Debug" option and post here the Debug messages that are printed just before and after the "unit raidX not in your party".

  • _ForgeUser342823 posted a comment Jan 5, 2010

    Using the latest build (r297) and still have the issue. It occurs when leaving one BG to join another, or just from exiting a BG altogether. As dorquemata mentioned, they are in no particular order, however, each unit (raid14, raid28, etc) has all it's messages appear one after the other, and there seems to be exactly four messages per unit.

    Also, the chat buffer ran out pretty quickly, but I did get this after the tail end of the "raidxx is not in your party" messages after exiting WSG:

    [23:13] Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader2UnitButton1 unit nil unitGUID nil
    [23:13] Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader2UnitButton1 unit nil unitGUID nil
    [23:13] Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader2UnitButton2 unit nil unitGUID nil
    [23:13] Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader2UnitButton3 unit nil unitGUID nil
    [23:13] Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader2UnitButton4 unit nil unitGUID nil
    [23:13] Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader2UnitButton5 unit nil unitGUID nil
    [23:13] Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader2UnitButton6 unit nil unitGUID nil
    [23:13] Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader2UnitButton7 unit nil unitGUID nil
    [23:13] Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader2UnitButton8 unit nil unitGUID nil
    [23:13] Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader2UnitButton9 unit nil unitGUID nil
    [23:13] Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader2UnitButton9 unit nil unitGUID nil
    [23:13] Grid2: DEBUG Grid2 GroupChanged solo => solo
    

    Edited Jan 5, 2010
  • _ForgeUser1198848 posted a comment Jan 6, 2010

    It appears that each "raidX" refers to a particular character in the raid. I left a BG while I was the last person remaining in the group and saw only "raid1". There were still 400+ messages stating that "raid1 is not in your party.", however I was able to scroll back far enough to get some debug messages from before that started.

    I get:

    Grid2: DEBUG Grid2 GroupChanged pvp => raid
    Grid2: DEBUG Grid2_Grid2Layout GroupTypeChanged raid
    Grid2: DEBUG Grid2_Grid2Layout LoadLayout by Group 10 w/Pets

    This is followed by a large quantity of the Grid2LayoutHeaderXUnitButtonY messages that are in Arkive's post. The most recent of which are:

    Grid2: DEBUG Grid2_Grid2Layout Placing group 2 Grid2LayoutHeader4 BOTTOMRIGHT Grid2LayoutHeader3 TOPRIGHT
    Grid2: DEBUG Grid2_Grid2Frame updated Grid2LayoutHeader4UnitButton1 unit raid1 raid1 unitGUID 0x0600000000888264
    Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader4UnitButton2 unit nil unitGUID nil
    Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader4UnitButton3 unit nil unitGUID nil
    Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader4UnitButton4 unit nil unitGUID nil
    Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader4UnitButton5 unit nil unitGUID nil
    Grid2: DEBUG Grid2_Grid2Layout Placing group 3 Grid2LayoutHeader11 BOTTOMRIGHT Grid2LayoutHeader4 TOPRIGHT
    Grid2: DEBUG Grid2_Grid2Frame removed Grid2LayoutHeader11UnitButton1 unit nil unitGUID nil
    raid1 is not in your party.
    

    Then after the "not in your party" messages, I get:

    raid1 is not in your party.
    Changed Channel: [1. General - Dalaran]
    Changed Channel: [2. LocalDefense - Dalaran]
    Joined Channel: [3. LookingForGroup]
    You have left the raid group.
    Grid2: DEBUG Grid2 GroupChanged raid => solo
    Grid2: DEBUG Grid2_Grid2Layout GroupTypeChanged solo
    Grid2: DEBUG Grid2_Grid2Layout LoadLayout Solo w/Pet

    The debug messages end with the same messages shown in Arkive's post.

  • _ForgeUser117147 posted a comment Jan 7, 2010

    It's weird.

    I've committed "something" in rev300, but it looks like it's an issue where Blizzard does not update the group status in the correct order when leaving battleground, as it some API will refuse the "raidX" unit before Grid2 has received the message that the player has left the raid.

  • _ForgeUser3696903 posted a comment Jan 9, 2010

    Ya I'm still getting the whole "raidx is not in your party" spammed over and over coming out of all BGs where "x" is a number. The larger the number of groups in the BG, the longer I spend at the loading screen and when it finally comes out - I have a spam of the yellow text. I love Grid2 but due to this I'm having to switch back to the original.

  • _ForgeUser3696903 posted a comment Jan 9, 2010

    Just updated to the current build (r303) and the problem still exists. Not sure what it is but believe its something about the update of player frames within a raid composition.


    Edited Jan 10, 2010
  • _ForgeUser1198848 posted a comment Jan 12, 2010

    I found that if I remove the role status from the text-down and text-down-color indicators then this will not happen when I leave the BG. I haven't yet had a chance to find out why this is the case. Does this work for anyone else?

  • _ForgeUser117147 posted a comment Jan 12, 2010

    Based on this latest comment, I've modified the implementation of the role status to make it less likely to call an API that would produce an error when leaving a battleground.

    Please check rev308 and report.

  • _ForgeUser117147 removed a tag Replied Jan 12, 2010
  • _ForgeUser117147 added a tag Waiting Jan 12, 2010
  • _ForgeUser3696903 posted a comment Jan 13, 2010

    Checked it out today with the latest version and its still happening when coming out of battlegrounds....

  • _ForgeUser3696903 removed a tag Waiting Jan 13, 2010
  • _ForgeUser3696903 added a tag Replied Jan 13, 2010
  • _ForgeUser1198848 posted a comment Jan 13, 2010

    With r311 I no longer see the "not in your party" messages when exiting a BG. I think that's because of another error however, since I now get a lot of these while inside the BG:

    Grid2-3.3.0.311\modules\StatusRole.lua:23: Usage: GetRaidRosterInfo(index)
    Grid2-3.3.0.311\modules\StatusRole.lua:23: in function `_GetUnitRole'
    Grid2-3.3.0.311\modules\StatusRole.lua:43: in function `?'
    CallbackHandler-1.0-5:146: in function <...ade\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
    <string>:"safecall Dispatcher[3]":4: in function <[string "safecall Dispatcher[3]"]:4>
    <in C code>: ?
    <string>:"safecall Dispatcher[3]":13: in function `?'
    CallbackHandler-1.0-5:91: in function `SendMessage'
    Grid2-3.3.0.311\GridRoster.lua:193: in function `?'
    CallbackHandler-1.0-5:146: in function <...ade\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
    <string>:"safecall Dispatcher[2]":4: in function <[string "safecall Dispatcher[2]"]:4>
    <in C code>: ?
    <string>:"safecall Dispatcher[2]":13: in function `?'
    CallbackHandler-1.0-5:91: in function `Fire'
    AceEvent-3.0-3 (Bartender4):120: in function <...AddOns\Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua:119>
      ---
    
    
  • _ForgeUser117147 posted a comment Jan 14, 2010

    @dorquemata: Your error should now be fixed in rev312.

    @Xancrus: Can you confirm that, using the latest alpha (rev312), the message still appear ? Can you try to remove the status-role and check if the message still occurs without this status ?

  • _ForgeUser117147 removed a tag Replied Jan 14, 2010
  • _ForgeUser117147 added a tag Waiting Jan 14, 2010
  • _ForgeUser1198848 posted a comment Jan 15, 2010

    I deleted the previous version, then installed r312, and removed the saved variables. I get the same error while I am in the BG:

    Grid2-3.3.0.312\modules\StatusRole.lua:28: Usage: GetRaidRosterInfo(index)
    Grid2-3.3.0.312\modules\StatusRole.lua:28: in function `_GetUnitRole'
    Grid2-3.3.0.312\modules\StatusRole.lua:47: in function `?'
    CallbackHandler-1.0-5:146: in function <...ade\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
    <string>:"safecall Dispatcher[3]":4: in function <[string "safecall Dispatcher[3]"]:4>
    <in C code>: ?
    <string>:"safecall Dispatcher[3]":13: in function `?'
    CallbackHandler-1.0-5:91: in function `SendMessage'
    Grid2-3.3.0.312\GridRoster.lua:193: in function `?'
    CallbackHandler-1.0-5:146: in function <...ade\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
    <string>:"safecall Dispatcher[2]":4: in function <[string "safecall Dispatcher[2]"]:4>
    <in C code>: ?
    <string>:"safecall Dispatcher[2]":13: in function `?'
    CallbackHandler-1.0-5:91: in function `Fire'
    AceEvent-3.0-3 (Bartender4):120: in function <...AddOns\Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua:119>
      ---
    
  • _ForgeUser1198848 removed a tag Waiting Jan 15, 2010
  • _ForgeUser1198848 added a tag Replied Jan 15, 2010
  • _ForgeUser1990418 posted a comment Jan 16, 2010

    I get dorquemata's error using r312. Seems that it's checking the role of raidpet1..n which doesn't work.

    Here's a small patch to stop the error:

    Index: StatusRole.lua
    ===================================================================
    --- StatusRole.lua	(revision 312)
    +++ StatusRole.lua	(working copy)
    @@ -25,7 +25,14 @@
     			return "MAINASSIST"
     		end
     	else
    -        return select(10, GetRaidRosterInfo(raid_indexes[unit]))
    +		local index = raid_indexes[unit]
    +		if index == nil then
    +			--Almost exclusively raid pets AFAICT
    +			--print( "Null index for Unit "..unit)
    +			return nil
    +		else
    +        	return select(10, GetRaidRosterInfo(index))
    +		end
     	end
     end
     
    

    Edited Jan 16, 2010
  • _ForgeUser117147 posted a comment Jan 16, 2010

    Thanks Gaff3. Fixed in rev313.

    So let's try this one. I hope it is finally working.

  • _ForgeUser117147 removed a tag Replied Jan 16, 2010
  • _ForgeUser117147 added a tag Waiting Jan 16, 2010
  • _ForgeUser1198848 posted a comment Jan 16, 2010

    Almost there! Line 29 reads:

    if index then return select(10, GetRaidRosterInfo()) end
    

    The GetRaidRosterInfo() is missing it's argument. I changed it to GetRaidRosterInfo(index) and it appears to be working great; at least for BGs.

    Big thanks, guys!


    Edited Jan 16, 2010
  • _ForgeUser1198848 removed a tag Waiting Jan 16, 2010
  • _ForgeUser1198848 added a tag Replied Jan 16, 2010
  • _ForgeUser117147 posted a comment Jan 16, 2010

    Fixed in rev314.

  • _ForgeUser117147 removed a tag Replied Jan 16, 2010
  • _ForgeUser117147 added a tag Fixed Jan 16, 2010
  • _ForgeUser117147 closed issue Jan 16, 2010

To post a comment, please login or register a new account.