Tooltip Player Name Coloring #634


  • Declined
  • Enhancement
Closed
  • Managed created this issue Jan 13, 2019

    Ever since the tooltip refactoring of "r836-alpha", player names have been colored gold, whereas they used to be white like default UI.

     

    Video to demonstrate the default raid/player frame tooltip vs. Grid2.

     

    A temporary workaround I've been doing is to hardcode GameTooltipTextLeft1 to white, but this has to be done every Grid2 update and is hacky.

     

    In Grid2\modules\IndicatorTooltip.lua:

     

    function Tooltip:Display(unit, object)
    	local anchor = self.dbx.tooltipAnchor
    	if anchor then
    		GameTooltip:SetOwner(Grid2Layout.frameBack, anchor)
    	else
    		GameTooltip_SetDefaultAnchor(GameTooltip, UIParent)
    	end
    	object:GetTooltip(unit, GameTooltip)
    	GameTooltipTextLeft1:SetTextColor(1,1,1,1)
    	GameTooltip:Show()
    	tooltipDisplayed = true
    end

     

     

     

  • Managed added a tag Enhancement Jan 13, 2019
  • michaelsp posted a comment Jan 13, 2019

    Is it really so important this color change ?

    Grid2 is displaying the tooltip provided by the game, the developer of the default blizzard frames decided to change manually the default  color provided by the game using GameTooltipTextLeft1:SetTextColor() too, probably because the default frames code is used to display hostile and friendly units (hostile are displayed red, friendly white).

    But in Grid2 frames all units are friendly (usually) the addon do not need to manage hostile units.

    Another problem: changing the tooltip from grid2 code  will mess with tooltip enhanced addons like Tiptac.


    Edited Jan 13, 2019
  • michaelsp added a tag Waiting Jan 13, 2019
  • Managed posted a comment Jan 13, 2019

    Ah, thank you for the explanation. It's not a big deal.

     

    Much appreciated for being super on top of tickets.

  • michaelsp closed issue Jan 16, 2019
  • michaelsp added a tag Declined Jan 16, 2019
  • michaelsp removed a tag Waiting Jan 16, 2019

To post a comment, please login or register a new account.