Wrong Raid Size in BGs when UI is reloaded #641


  • Fixed
Closed
  • michaelsp created this issue Feb 3, 2019
    Owner

    When UI is reloaded inside a BG, PLAYER_ENTERING_WORLD event is triggered but GetInstanceInfo() returns 0 for maxPlayers,  as 0 is not a valid raid size the addon (to avoid displaying zero unit frames) uses the raid size: 40.

    To fix this, as workaround,  UPDATE_INSTANCE_INFO is registered, this event is fired after PLAYER_ENTERING_WORLD,  when GetInstanceInfo() already returns correct values (it seems, at least in my computer and inet conexion).
    Warning this maybe is not reliable because UPDATE_INSTANCE_INFO is fired because Interface/FrameXML/RaidFrame.lua calls RequestRaidInfo().

     

    Fixed in revision 870.

  • michaelsp added a tag Started Feb 3, 2019
  • michaelsp edited description Feb 3, 2019
  • michaelsp edited description Feb 3, 2019
  • michaelsp closed issue Feb 4, 2019
  • michaelsp added a tag Fixed Feb 4, 2019
  • michaelsp reopened issue Feb 28, 2019
  • michaelsp posted a comment Feb 28, 2019

    It seems revision 870 did not fix the problem for all players, trying to fix the issue in revision 873.

    Feedback about v873 behaviour will be welcome.


    Edited Feb 28, 2019
  • michaelsp removed a tag Fixed Feb 28, 2019
  • michaelsp added a tag Waiting Feb 28, 2019
  • stamic posted a comment Mar 2, 2019

    I tested it out today in a random BG.

    My theme is set up to use a different layout for 40 man raids and another layout for the other raid sizes.

    I entered a seething shore BG and on entering the BG the 40 man layout was enabled automatically.

    The seething shore is a 10 man BG so the switch did not work unfortunately.

    My default theme was set to an arena layout before.

  • michaelsp posted a comment Mar 2, 2019

    Tested in seething shore (and another bgs) and here is working correctly:

    Is there any bg/arena where the raid size is detected correctly ?

    Can you test the issue with all addons disabled except Grid2 ?

    Could you PM me your profile (exporting the profile to text format from Profiles->Advanced) ?, to investigate if it is due to some setup problem in the Grid2 configuration.


    Edited Mar 2, 2019
  • michaelsp posted a comment Mar 3, 2019

    Finally Stamic issue is a different problem, opening a new ticket #652 to track the new issue. The original issue in this ticket must be already fixed.

     


    Edited Mar 3, 2019
  • michaelsp added a tag Fixed Mar 3, 2019
  • michaelsp removed the tags Started Waiting Mar 3, 2019
  • michaelsp closed issue Mar 4, 2019

To post a comment, please login or register a new account.