Add Pet Dungeons to possible layouts #687


Closed
  • Shiv_G3 created this issue Jul 19, 2019

    What version of Grid2 are you using?

    r894-alpha

     

    What game client version (windows or mac) and language are you using ?

    Windows

     

    What steps will reproduce the problem?

    Load into Pet Dungeon and a 5 man layout will load

      
    Did you try having Grid2 as the only enabled addon and everything else disabled?

    Yes

      

    Was it working in a previous version? If yes, which was the last good one?

    No, this is a feature enhancement

      

    Do you have an error log of what happened? If you don't see any errors, make sure that error reporting is enabled (`/console scriptErrors 1`) or install [BugSack](https://mods.curse.com/addons/wow/BugSack).

    No error log

     

    Please provide any additional information below.

     

    I've added the following to the function Grid2:GroupChanged(event) in GridRoster.lua

    		elseif string.match(instName, "Pet Dungeon") then
    			newGroupType, newInstType, maxPlayers = "solo", "other", 1

     I added this at line 218 right after the raid check.

     

    This will load a solo layout for the Pet Battle dungeons.

     

    Also, shouldn't the GetNumGroupMembers() check for >1?  1 would be solo, and anything above that would be a group? 

     

  • Shiv_G3 edited description Jul 19, 2019
  • michaelsp posted a comment Jul 19, 2019

    The suggested patch only works in english client, instName is language dependent.

    GetNumGroupMembers() can return 1 when you are in an group or raid, for example when you are the only player in the group or raid subgroup.

    If you are really solo (not group, not raid), GetNumGroupMembers() returns 0.


    Edited Jul 19, 2019
  • michaelsp posted a comment Jul 20, 2019

    For some reason when the player enters in a pet dungeon the game puts the player in a group , i don't want to contradict the game, could break another things, so for now im going to reject this suggestion, another reason, i don't play that pokemon thingy so i cannot test it.


    Edited Jul 20, 2019
  • michaelsp posted a comment Jul 20, 2019

    Maybe a different approach, Im thinking in an option to hide grid2 while in a pet battle. Is this aplicable to pet dungeons ? No idea how this type of dungeon works.


    Edited Jul 20, 2019
  • Shiv_G3 posted a comment Jul 20, 2019

    Make sense.  Wish the API would give you actual results of the type of group you are in.  The Pet Battle dungeons are solo scenarios. 

     

    For the pet dungeons you move through them like a normal dungeon but have pet battles instead of bosses.  So it's the actual instance map, just no NPC's except the pets.  Not sure if there is an elegant way to handle this either. 

     

    Appreciate the response!

  • michaelsp closed issue Jul 26, 2019

To post a comment, please login or register a new account.