Blizzard raidui uses GetRaidRosterInfo() to set online/offline flag, does that help? #720


Closed
  • nukmii created this issue Sep 10, 2019

    What version of Grid2 are you using?

     r922

     

    What game client version (windows or mac) and language are you using ?

     windows

     

    What steps will reproduce the problem?

     N/A


    Did you try having Grid2 as the only enabled addon and everything else disabled?

    N/A

      

    Was it working in a previous version? If yes, which was the last good one?

    n/A  

    Do you have an error log of what happened? If you don't see any errors, make sure that error reporting is enabled (`/console scriptErrors 1`) or install [BugSack](https://mods.curse.com/addons/wow/BugSack).

      

    Please provide any additional information below.

    I read the Blizzard code Interface/Addons/blizzard_raidui/blizzard_raidui.lua and found out that it uses GetRaidRosterInfo() to set online/offline flag, specifically, the 8th returned arg, not UnitIsConnected(). And it seems that blizzard_raidui only uses UnitIsConnected() to help set alpha.

     

    After a bit of testing, I can see that UnitIsConnected() is indeed seriously bugged like you commented in StatusOffline.lua both before- and after- the fix. But GetRaidRosterInfo() seems to respond more quickly and accurately than UnitIsConnected(). I haven't began to implement and test relevant code, just want to share this finding first.

     

    And sorry about the badgering,  cuz I just migrated my whole frame settings to Grid2 and may have lots of newbie thoughts.  I think Grid2 is a GREAT addon and love your work. As to my issue, I have a workaround by disabling offline status and letting alpha do the work. It's mainly about offline-color not covering heath-bar during raid. 

     

  • michaelsp posted a comment Sep 11, 2019

    Unfortunatelly the connection event is bugged too and fires randomly, this forces addons to check continously if the units is connected or not, but grid2 philosophy is to respond to events, to avoid eating too much cpu cycles.

    Sorry if i might have sounded rude. It wasn't my intention, Im really a bit tired of implementing workarounds, the addon is already full of workarounds because blizzard refused to fix a lot bugs (even some game bug has 10 years old). My apologies, I was angry with blizzard not with you ;)


    Edited Sep 11, 2019
  • nukmii posted a comment Sep 11, 2019

    Cool! I can relate to the event-based philosophy, and will no longer push on this issue. Thx and have a good day!

  • nukmii closed issue Sep 11, 2019
  • michaelsp posted a comment Sep 23, 2019

    Notes for future reference: Tested some posibilities, and i could not create a working code for all cases, unfortunatelly GetRaidRosterInfo() always reports "offline" for non-visible units (+100 yards away units), and and real offline unit is considered non-visible too be the game, so the result of GetRaidRosterInfo is  garbage, unuseful.


    Edited Sep 23, 2019

To post a comment, please login or register a new account.