After switching to LibHealComm-4.0 the incoming healing of other players ceased to be displayed #764


Closed
  • nubnuby created this issue Nov 5, 2019

    What version of Grid2 are you using? 939 / 940b

     

    What game client version (windows or mac) and language are you using ? classic

     

    What steps will reproduce the problem?

      
    Did you try having Grid2 as the only enabled addon and everything else disabled? n

      

    Was it working in a previous version? If yes, which was the last good one? r938 (2019-10-09)

      

    Do you have an error log of what happened? If you don't see any errors, make sure that error reporting is enabled (`/console scriptErrors 1`) or install [BugSack](https://mods.curse.com/addons/wow/BugSack).

      

    Please provide any additional information below.

     

     

  • Tiuven posted a comment Nov 6, 2019

    939 version here. Last week I have updated the addon and I am no longer able to see any incoming heal from other players who are using healbot or healcomm.

    We did a MC run and it was overhealing fest for the Grid 2 users.

     

    Grid2 is the only raid frames enabled. 

     

    I was raiding like I used to. I have not installed any other addons or anything.

    Is there any other way to make it work? Half of the raid is crumpled at the moment.

  • VirtueAvatar posted a comment Nov 6, 2019

    I have the same issue, here's my log:

     

    Date: 2019-11-07 00:53:46
    ID: 1
    Error occured in: Global
    Count: 1
    Message: ...ddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua line 744:
    attempt to compare number with nil
    Debug:
    ...ddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:744:
    ...ddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:681
    ...ddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:2189: ?()
    ...ddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:2725:
    ...ddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:2723
    Locals:
    guid = "Player-4739-003C22D9"
    spellID = 9858
    spellName = "Regrowth"
    rank = 9
    healAmount = 152
    spellPower = 0
    healModifier = 1.100000
    spModifier = 1
    bombAmount = nil
    totalTicks = 7
    (*temporary) = nil
    (*temporary) = 1
    (*temporary) = nil
    (*temporary) = false
    (*temporary) = 7
    (*temporary) = nil
    (*temporary) = nil
    (*temporary) = nil
    (*temporary) = nil
    (*temporary) = nil
    (*temporary) = nil
    (*temporary) = "attempt to compare number with nil"
    GetSpellInfo = <function> defined =[C]:-1
    SpellIDToRank = <table> {
    10468 = 6
    3698 = 2
    9839 = 8
    9840 = 9
    639 = 2
    774 = 1
    19939 = 2
    1064 = 1
    19943 = 6
    3700 = 4
    25297 = 11
    8004 = 1
    25299 = 11
    2050 = 1
    1430 = 3
    11700 = 6
    9472 = 2
    9473 = 3
    9474 = 4
    9856 = 7
    9857 = 8
    2052 = 2
    13542 = 5
    10622 = 2
    13544 = 7
    22009 = 5
    9863 = 4
    25315 = 10
    11694 = 6
    2054 = 1
    13543 = 6
    10964 = 3
    5187 = 3
    2055 = 2
    6078 = 6
    1058 = 2
    10328 = 7
    3699 = 3
    5189 = 5
    709 = 3
    9750 = 6
    3661 = 3
    689 = 1
    8010 = 3
    959 = 6
    10623 = 3
    2090 = 4
    2053 = 3
    9758 = 8
    6063 = 3
    10395 = 8
    9888 = 9
    9889 = 10
    2060 = 1
    331 = 1
    19941 = 4
    547 = 3
    2061 = 1
    6075 = 3
    19940 = 3
    647 = 3
    9862 = 3
    10915 = 5
    10916 = 6
    10917 = 7
    996 = 2
    3111 = 2
    7651 = 4
    6064 = 4
    25357 = 10
    913 = 4
    19942 = 5
    139 = 1
    9841 = 10
    10927 = 7
    699 = 2
    10929 = 9
    11699 = 5
    596 = 1
    25292 = 9
    11695 = 7
    11693 = 5
    755 = 1
    6074 = 2
    1026 = 4
    1042 = 5
    332 = 2
    10329 = 8
    5185 = 1
    8910 = 7
    5186 = 2
    25316 = 5
    6076 = 4
    25314 = 5
    5188 = 4
    6077 = 5
    740 = 1
    8918 = 2
    3627 = 6
    6778 = 6
    2091 = 5
    10396 = 9
    19750 = 1
    9858 = 9
    10928 = 8
    939 = 5
    635 = 1
    10960 = 3
    10961 = 4
    8008 = 2
    10963 = 2
    3662 = 4
    10965 = 4
    3472 = 6
    136 = 1
    8936 = 1
    8903 = 7
    8938 = 2
    8939 = 3
    8940 = 4
    8941 = 5
    10466 = 4
    10467 = 5
    8005 = 7
    }
    hotData = <table> {
    Rejuvenation = <table> {
    }
    Regrowth = <table> {
    }
    }
    GetSpellBonusHealing = <function> defined =[C]:-1
    playerHealModifier = 1
    talentData = <table> {
    Gift of Nature = <table> {
    }
    Improved Rejuvenation = <table> {
    }
    }
    GiftofNature = "Gift of Nature"
    WotLK = false
    Genesis = nil
    unitHasAura = <function> defined @Interface\AddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:523
    TreeofLife = nil
    MasterShapeshifter = nil
    playerCurrentRelic = nil
    Rejuvenation = "Rejuvenation"
    ImprovedRejuv = "Improved Rejuvenation"
    equippedSetCache = <table> {
    Stormrage = 0
    }
    EmpoweredRejuv = nil
    NaturesSplendor = nil
    Regrowth = "Regrowth"
    Lifebloom = nil
    bloomBombIdols = <table> {
    42577 = 217
    42578 = 246
    33076 = 105
    42579 = 294
    28355 = 87
    42580 = 376
    51423 = 448
    35021 = 131
    42576 = 188
    33841 = 116
    }
    ceil = <function> defined =[C]:-1
    calculateGeneralAmount = <function> defined @Interface\AddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:535
    glyphCache = <table> {
    }
    WildGrowth = nil
    calculateSpellPower = <function> defined @Interface\AddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:545
    HealComm = <table> {
    TargetLastTarget = <function> defined @Interface\AddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:2475
    GetHealModifier = <function> defined @Interface\AddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:369
    bucketFrame = <unnamed> {
    }
    TargetLastFriend = <function> defined @Interface\AddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:2471
    compressGUID = <table> {
    }
    UNIT_SPELLCAST_CHANNEL_START = <function> defined @Interface\AddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:2301
    GetNextHealAmount = <function> defined @Interface\AddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:392
    ALL_HEALS = 23
    GLYPH_ADDED = <function> defined @Interface\AddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:1680
    UseAction = <function> defined @Interface\AddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:2480
    itemSetsData = <table> {
    }
    currentModifiers = <table> {
    }
    aurasUpdated = true
    GLYPH_REMOVED = <function> defined @Interface\AddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:1680
    GetCasterHealAmount = <function> defined @Interface\AddOns\Grid2\Libs\LibHealComm-4.0\LibHealComm-4.0.lua:512
    CASTED_HEALS = 3
    UNIT_SPELLCAST_
    AddOns:
    Swatter, v8.2.6377 (SwimmingSeadragon)
    AdvancedInterfaceOptions, v1.3.3
    AtlasLootClassic, vv1.3.3
    AtlasLootClassicData, vv1.3.3
    AtlasLootClassicDungeonsAndRaids, vv1.3.3
    AtlasLootClassicMaps, vv1.0.0
    AucAdvanced, v8.2.6430 (SwimmingSeadragon)
    AucFilterBasic, v8.2.6364 (SwimmingSeadragon)
    AucScanData, v8.2.6365 (SwimmingSeadragon)
    AucStatHistogram, v8.2.6366 (SwimmingSeadragon)
    AucStatiLevel, v8.2.6370 (SwimmingSeadragon)
    AucStatPurchased, v8.2.6367 (SwimmingSeadragon)
    AucStatSimple, v8.2.6399 (SwimmingSeadragon)
    AucStatStdDev, v8.2.6369 (SwimmingSeadragon)
    AucUtilFixAH, v8.2.6371 (SwimmingSeadragon)
    BagBrother, v
    Bagnon, v8.2.16
    BeanCounter, v8.2.6422 (SwimmingSeadragon)
    BetterVendorPrice, vv1.10.00
    ClassicThreatMeter, v1.10
    DBMCore, v1.13.18
    DBMDefaultSkin, v
    DBMStatusBarTimers, v
    Details, v
    DetailsTinyThreat, v
    ElvUI, v1.15
    ElvUIBenikUIClassic, v1.06
    ExtendedCharacterStats, v1.5
    FasterLooting, v1.1.1
    FieldGuide, vv1.5-release
    GatherMate2, v1.45.5
    Grid2, vr939
    Grid2LDB, vr939
    Grid2RaidDebuffs, vr939
    HandyNotes, vv1.5.9
    HandyNotesDungeonLocationsClassic, v1.03
    Informant, v8.2.6374 (SwimmingSeadragon)
    ItemPriceTooltip, v1.01
    ItemRack, v
    LeatrixMaps, v1.13.36
    LeatrixPlus, v1.13.37
    MonkeyBuddy, v
    MonkeyLibrary, v
    MonkeyQuest, v
    MonkeyQuestLog, v
    OmniCC, v8.1.1
    Questie, v5.0.1 2 e2e80b7
    QuestLogEx, v1.2
    RealMobHealth, v2.13
    SlideBar, v8.2.6375 (SwimmingSeadragon)
    Stubby, v8.2.6376 (SwimmingSeadragon)
    TellMeWhen, v8.7.1
    TomTom, vv80200-1.0.7
    BlizRuntimeLib_enUS v1.13.2.11302 <none>
    (ck=64a)

     

  • michaelsp posted a comment Nov 6, 2019

    Did the other healers switch to libhealcomm-4.0? 

  • nubnuby posted a comment Nov 6, 2019

    Of course not, they use various add-ons for healing, and from none I see incoming healing.

    it may be possible to somehow use both versions of the library in parallel?


    Edited Nov 6, 2019
  • michaelsp posted a comment Nov 6, 2019

    it may be possible to somehow use both versions of the library in parallel?

    No, Grid2 does not use libclassichealcomm anymore, the old library was an unauthorized fork, i cannot use or include stolen code in Grid2.

  • Yingas2 posted a comment Nov 9, 2019

    So we just wont have incoming heals ever again? Does the old version still include libclassichealcomm?

  • michaelsp posted a comment Nov 9, 2019

    Yo will have incoming heals if other healers update their addons, almost all raid addons have switched to the new healcomm library.

    But a lot of people uses the game default raid interface that does not use any healcomm library. 

  • nubnuby posted a comment Nov 9, 2019

    VuhDo updated today. left to wait for Healbot update.

  • LooriaTV posted a comment Nov 10, 2019

    I still can't make my incoming heals work. Tried the 940 beta version, didn't work. Went back tot he 939 version, still not working. It's working just fine in VuhDo, and I understand that I won't see all other healers, but I can't even see my own incoming heals. Any ideas what's going on?

  • michaelsp posted a comment Nov 10, 2019

    Your own heals are not displayed by default, did you enable the "Include player heals"  option? 


    Edited Nov 10, 2019
  • Yingas2 posted a comment Nov 10, 2019

    Thanks for the reply Michael. I appreciate it.

     

  • LooriaTV posted a comment Nov 10, 2019

    Thanks Michael, that did it for me. And actually, made me think about...do I really want to see my incoming heals on players or just other players incoming heals? If I see both, I don't know if there are two or three other players about to heal that target and my heal might end up as an overheal (druid here lul). Now without seeing my incoming heals, if the target does not display any incoming heals and I'm casting a heal on that target, I can be 100% sure it won't end up as overheal. So it might make more sense to keep this option off..

  • michaelsp posted a comment Nov 10, 2019

    So it might make more sense to keep this option off

    I applied the same logic time ago (i want to know if the incoming heal is mine or not to maybe stop cast my heal) , and i don't need to see my incoming heal, i already know that i am casting a heal.

    That is the reason because in the default config the player incoming heals option is disabled.

    The only issue with this logic is: HOTs, maybe i would like to to see my own hots (but a different indicator can be used to display my own heals: using my-incoming-heals status).

    But usually raid frames are configured to track the player healing buffs/auras (hots+another CDs), so is it really necessary to display the own hots amounts ?


    Edited Nov 10, 2019
  • LooriaTV posted a comment Nov 10, 2019

    Yeah I actually left the incoming heals text including my incoming heals, so I can see hots amount that will be healed (in addition to specific indicator for Rejuv and Regrowth countdown obvously), but for the visual representation of incoming heals, I left that only for other players.

  • stinkiestbear posted a comment Nov 10, 2019

    My own incoming heals are still inconsistent and broken. I've had to revert back to a version of grid2 using libclassicHealComm :( 

  • michaelsp posted a comment Nov 10, 2019

    If you keep an old Grid2 version installed you won't see other healers information, because the rest of the players eventually are going to update their addons, and all addons have switched to the original healcomm library.


    Edited Nov 10, 2019
  • stinkiestbear posted a comment Nov 12, 2019

     @michaelsp

     
    I get what you're saying, but I upgraded to the latest version and even my own incoming heals were partially broken. Sometimes they just don't work at all.
     
    At least downgrading, I can still see my own incoming heals properly. 
     
    Is the author of the original healcomm library aware of all the issues? Have you experienced them yourself?
     
    Also, for whatver reason, I can see incoming heals of people using the original healcomm lib (my friend uses elvui which has switched to it)

    Edited Nov 12, 2019
  • michaelsp posted a comment Nov 13, 2019

    Yes, healcomm-4 maintainer (one of the elvui developers) is fixing bugs and releasing several alpha versions each day,  but some bugs were not completelly fixed yet, probably in a few days the library will reach a more stable state, once it happens i will release a new grid2 version with the updated library.

  • Forge_User_24335220 posted a comment Nov 14, 2019

    Hey @michaelsp just a heads up on a couple things I noticed with that last 2 builds.

     

    The incoming heal doesn't seem to recognise either 1) rank of spell and/or 2) it's miscalculating +healing on gear. I've reverted back 2 versions which works perfectly.

     

    In addition to this, when I cast e.g. renew, in the version two earlier, it would show the total HoT then as the ticks come off, it would update in real time, the remaining value of the HoT. The latest version just shows a flat amount and it also sticks on the grid frame once the HoT has finished.

     

    Also, there is a strange relationship with Masque and Bagnon Facade where the latest version of Grid2 stops the prior mentioned addons working, specifically the Masque skin for Bagnon.

     

     

    Just a few things, they seem minor just thought you should know.

     

    Keep up the good work man!


    Edited Nov 14, 2019
  • michaelsp posted a comment Nov 14, 2019

    I have uploaded a new beta version:

    https://www.wowace.com/projects/grid2/files/2827526

    This version includes some new options in incoming-heals status configuration, and a new libhealcomm-4 library version, with some bugs fixed.

    Now users that don't want to see the full hots heal amount can configure a time band duration, for example 3 seconds to see only the heals that are going to land within the specified time period. The type of heals to display can be configured too (hots, casted, channeled, ..)


    Edited Nov 14, 2019
  • michaelsp closed issue Nov 28, 2019

To post a comment, please login or register a new account.