Ready check status generates errors #77


  • Defect
  • Fixed
Closed
Assigned to _ForgeUser117147
  • _ForgeUser1990418 created this issue Jan 16, 2010

    Hi,

    Looks like you didn't quite merge my patch right:

    StatusReadyCheck.lua
    function ReadyCheck:GetReadyCheckStatus(unit)

    The function has both "unit" and "unitid" in it, only "unit" works. I would commit the fix myself but I'm not sure what the etiquette / permissioning is ;)

  • _ForgeUser1990418 added the tags New Defect Jan 16, 2010
  • _ForgeUser117147 posted a comment Jan 16, 2010

    Sorry about that Copy/pasting failure.

    I prefer "unit" for the name for the variable, even though it does indeed contain a unit ID. The reason being mainly that it is named like that in Blizzard code.

    I think you should be able to commit to the Grid2 repository. I have no problem with you doing so. The different patch that you provided recently have been really helpful and of good quality.

  • _ForgeUser117147 removed a tag New Jan 16, 2010
  • _ForgeUser117147 added a tag Fixed Jan 16, 2010
  • _ForgeUser117147 closed issue Jan 16, 2010

To post a comment, please login or register a new account.