Ny'alotha RaidDebuffs still not working (specifically Ra'den's room) #792


Closed
  • kaluu created this issue Jan 31, 2020

    What version of Grid2 are you using? r950

     

    What game client version (windows or mac) and language are you using ? Windows 10, English

     

    What steps will reproduce the problem? Zoning into Ra'dens room wont show the debuffs in his room

      
    Did you try having Grid2 as the only enabled addon and everything else disabled? Yes

      

    Was it working in a previous version? If yes, which was the last good one? No

      

    Do you have an error log of what happened? If you don't see any errors, make sure that error reporting is enabled (`/console scriptErrors 1`) or install [BugSack](https://mods.curse.com/addons/wow/BugSack). No errors, just debuffs aren't showing

      

    Please provide any additional information below.

     

    This is the similar issue that's going on ticket https://www.curseforge.com/wow/addons/grid2/issues/786 , but for Ra-den's room. I already made a reference in #786 that when i do /dump C_Map.GetBestMapForUnit("player") in Ra'den's room, i get 1591 as an output. I'm going to assume that 

     

    [1591] = 1581,
    
     

    goes around line 51 of Grid2RaidDebuffs.lua , but I didn't have a time to attempt a pull as it was already the end of raid.

     

     

  • kaluu edited description Jan 31, 2020
  • michaelsp posted a comment Jan 31, 2020

    MapID 1591 is recognized by the game, so an entry is not needed in bugged_maps table, You can type:

     

    /script print( EJ_GetInstanceForMap(1591) )

     

    which in my computer displays 1180 (the Ny'alotha raid identifier), when a map is not recognized the result is 0.

    Another way to check if a zone is recognized by the game is to click the "Adventure Guide" micro button. In a recognized zone the game displays the information for the dungeon/raid you are in. In a non recognized zone the game displays generic info about azeroth (even the default game  interface does not work correctly due to this bug)

     

    Are you sure raiddebuffs are not working in this zone ? Maybe there are simply some missing debuffs in the raid debuffs table ?.

     

    Keep in mind that the code does not reload the raid debuffs when you change subzones in same dungeon/raid (the code checks if the dungeon is the same and in this case do nothing). This means that the bugged zone could be another, the one where the last UI reload or logout/login was done.

    But t in theory there are not missing bugged zones, because i have checked all results of C_Map.GetMapInfo() /EJ_GetInstanceForMap() using a brute force method (I said "in theory" because  I am assuming there is no other bug/missing info in C_Map.GetMapInfo() function)

     

    You can enable RaidDebuffs debug (General -> About tab) and report the debug message here.

     

     

     

     

     


    Edited Jan 31, 2020
  • kaluu posted a comment Jan 31, 2020

    Yes, I am sure the raid debuffs on Ra-den are not working. I switched to being a healer for this patch, so I'm even more diligently watching raid frames more than usual. I even went back to watching my stream from last night, and saw no debuffs on any of the attempts we did.

    I attempted to switch on the raiddebuff debug checkmark (after raid was over), as soon i rezoned into the raid , the same debug code of (referenced in ticket #768)

     

    [08:09:06 PM] Grid2: DEBUG Grid2_Grid2RaidDebuffs Zone [Ny'alotha, the Waking City][1580/1180/102217] Status [raid-debuffs3]: 2 raid debuffs loaded
    [08:09:06 PM] Grid2: DEBUG Grid2_Grid2RaidDebuffs Zone [Ny'alotha, the Waking City][1580/1180/102217] Status [raid-debuffs]: 31 raid debuffs loaded
    [08:09:06 PM] Grid2: DEBUG Grid2_Grid2RaidDebuffs Zone [Ny'alotha, the Waking City][1580/1180/102217] Status [raid-debuffs4]: 0 raid debuffs loaded
    [08:09:06 PM] Grid2: DEBUG Grid2_Grid2RaidDebuffs Zone [Ny'alotha, the Waking City][1580/1180/102217] Status [raid-debuffs2]: 1 raid debuffs loaded

     

    popped up, but no debug code popped up when i zoned into Ra-den's room, not even after a /reloadUI or restarting WoW. I am currently not able (until Monday night during my raid) to go back to pull any additional information needed.

  • michaelsp posted a comment Jan 31, 2020

    but no debug code popped up when i zoned into Ra-den's room

    That is a correct behaviour, because raid debuffs are only loaded the first time you enter the instance not when the player changes subzones inside the same instance (or if a reload ui is executed, that is the same than reentering in the instance).

    Your debug info is OK (raiddebuffs for the instance number 1180 (Ny'alotha raid) are loaded)

    But Grid2RaidDebuffs info message not displayed when the ui is reloaded, is not possible, this can only happen if the addon is crashing.

    Enable script errors and check if some lua error is displayed, to enable script errors type into chat:

    /console scriptErrors 1

    Update: Sometimes the first chat messages are not displayed when the ui is reloaded due to chat addons, because the chat addon is not fully initialized when the first messages are sent the chat.


    Edited Jan 31, 2020
  • kaluu posted a comment Feb 3, 2020

    So, I am currently in my raid, debuffs showed up with [1591] = 1581 in the bugged_maps table. still no bugged or script errors with /console scripterrors 1


    Edited Feb 3, 2020
  • michaelsp posted a comment Feb 3, 2020

    The entry  [1591] = 1581 is irrelevant, because 1591 map is not bugged (at least not in my game client), which  number displays in your computer the line ?

    /script print( EJ_GetInstanceForMap(1591) )

    Another thing, if you want to test the 1591 map, you must logout or reload the UI while your toon is in that zone, without this the raid debuffs used are the ones loaded when you entered in the instance (in the 1580 zone, that is Wrathion zone).

    I need to know the debug info displayed by the unchanged addon (no [1591] = 1581 line added to bugged_maps table)


    Edited Feb 3, 2020
  • kaluu posted a comment Feb 4, 2020

    The output for /script print( EJ_GetInstanceForMap(1591) )  in Ra'den's room is 1180. I but now I am now currently unable any other script outputs as my raid has ended for the night, and will do a reset on Wednesday NA.

  • michaelsp posted a comment Feb 4, 2020

    The number 1180 is OK. But the most important data is the debug info displayed by the addon, because this data is collected at the right time:  just after entering the instance, after reloading the UI or after login.

  • kaluu posted a comment Feb 4, 2020

    Entering the instance  (at a cleared normal Wrathion)
    [10:31:19 PM] Grid2: DEBUG Grid2_Grid2RaidDebuffs Zone [Ny'alotha, the Waking City][1581/1180/102217] Status [raid-debuffs4]: 0 raid debuffs loaded
    [10:31:19 PM] Grid2: DEBUG Grid2_Grid2RaidDebuffs Zone [Ny'alotha, the Waking City][1581/1180/102217] Status [raid-debuffs]: 31 raid debuffs loaded
    [10:31:19 PM] Grid2: DEBUG Grid2_Grid2RaidDebuffs Zone [Ny'alotha, the Waking City][1581/1180/102217] Status [raid-debuffs3]: 3 raid debuffs loaded
    [10:31:19 PM] Grid2: DEBUG Grid2_Grid2RaidDebuffs Zone [Ny'alotha, the Waking City][1581/1180/102217] Status [raid-debuffs2]: 1 raid debuffs loaded

    After relogging (at the same normal Wrathion)

    Grid2: DEBUG Grid2_Grid2RaidDebuffs Zone [Ny'alotha, the Waking City][1582/1180/102217] Status [raid-debuffs4]: 0 raid debuffs loaded
    Grid2: DEBUG Grid2_Grid2RaidDebuffs Zone [Ny'alotha, the Waking City][1582/1180/102217] Status [raid-debuffs2]: 2 raid debuffs loaded
    Grid2: DEBUG Grid2_Grid2RaidDebuffs Zone [Ny'alotha, the Waking City][1582/1180/102217] Status [raid-debuffs3]: 3 raid debuffs loaded
    Grid2: DEBUG Grid2_Grid2RaidDebuffs Zone [Ny'alotha, the Waking City][1582/1180/102217] Status [raid-debuffs]: 30 raid debuffs loaded

     

     

  • kaluu posted a comment Feb 4, 2020

    Never mind now, I just managed to re-look over my stream from last Thursday and tonight, and the debuffs you put as the default ones are showing up from phase 2. None of the debuffs that happen on phase 1 are listed. That is probably what is causing the confusion from me, sorry about that.

    The ones I have added (for what I expecting) are

    Nullifying Strike 306819
    Unstable Vita 306273
    Instability Exposure 306279
    Void Defilement 309777


    Edited Feb 4, 2020
  • michaelsp posted a comment Feb 4, 2020

    Thanks,  i will add these new debuffs to the raiddebuffs module.

  • michaelsp closed issue Feb 4, 2020

To post a comment, please login or register a new account.