Classic: Maxed heal prediction status that overheals doesn't change value when HP is reduced #827


  • Defect
  • Fixed
Closed
  • BujuArena created this issue Apr 24, 2020

    What version of Grid2 are you using?

     

    959-beta-classic

     

    What game client version (windows or mac) and language are you using?

     

    WoW Classic (latest); English; Windows 7 64-bit

     

    What steps will reproduce the problem?

     

    1. Add a healing prediction status attached to the end of the current HP bar and an overhealing prediction status to another bar in Grid2.
    2. Start a heal on yourself while in combat with an enemy who deals damage to you. This heal must be predicted to heal for more than your missing HP.
    3. Take an amount of damage while the heal is being cast that is less than the overhealing prediction.

     

    At this point, the heal prediction status will stay the same instead of being updated. The heal prediction will no longer fill the missing HP area, even though the overheal bar will still have a value above 0. The expected behavior is for the heal prediction status to continue to fill the missing HP.

     

    Did you try having Grid2 as the only enabled addon and everything else disabled?

     

    No, but I'm pretty sure no other addons are interfering with this test.

     

    Was it working in a previous version? If yes, which was the last good one?

     

    No.

     

    Do you have an error log of what happened? If you don't see any errors, make sure that error reporting is enabled (`/console scriptErrors 1`) or install [BugSack](https://mods.curse.com/addons/wow/BugSack).

     

    No, this is not related to Lua errors.

     

    Please provide any additional information below.

     

    The overheal portion of the previous issue ticket at https://www.wowace.com/projects/grid2/issues/756 was fixed. Now all that remains is fixing the heal prediction portion, as there's still a disconnected heal prediction when the target takes damage, which is confusing in action.

  • BujuArena added the tags Defect New Apr 24, 2020
  • michaelsp posted a comment Apr 24, 2020

    My advise is:  remove heals and health bar and create a multibar indicator instead. Multibar indicators are working fine and can stack several bars (not only one extra bar).

    The heals bar code is an ancient and non perfect patch to allow an extra bar and I don't want to mess with so old code. I need an important reason to change the heals bar code.


    Edited Apr 24, 2020
  • BujuArena posted a comment Apr 24, 2020

    I tried that and multibar still can't do everything that anchoring a bar indicator to another bar can do.  I couldn't set the color of the second part of the multibar to the incoming-heals status color.

     

    I'm pretty sure this won't need touching the heals bar code.  Grid2StatusAbsorbs which is just based on the old absorb-below-max-hp and absorb-above-max-hp statuses that were removed from Grid2 still works perfectly fine even when health goes down, so there's already an example of a status that works properly with this.  I think only the incoming-heals status code needs a fix.


    Edited Apr 24, 2020
  • michaelsp posted a comment Apr 24, 2020

    The bugged code is in the bar indicator.  Fixing the issue in the incoming-heals status is a bad fix and very cpu consuming (because  health events are triggered a lot of times per second).

    Just a question, are you using the same color for health and heals bars (but applying a different opacity) ?


    Edited Apr 24, 2020
  • michaelsp posted a comment Apr 25, 2020

    Finally i fixed the bar indicator code in r960-beta version.


    Edited Apr 25, 2020
  • michaelsp removed a tag New Apr 25, 2020
  • michaelsp added a tag Started Apr 25, 2020
  • BujuArena posted a comment Apr 25, 2020

    I'm using the status colors for the health and heals bars.  On the health bar, I use the Recount "Flat" texture which is a slightly darker texture and statuses charmed, magic debuff, disease debuff, poison debuff, curse debuff, and current health in that order.  On the heals bar, I use the "Grid2 Flat" texture, which is max brightness, and color of status incoming heal.  With the different texture, I can differentiate the bars.  I was able to set something like it up with multibar, but all my class profiles use bar anchored to bar and the setup change would take a while.

     

    Ultimately, thank you so much for the fix!  Grid2 is amazing and you've done an incredibly good job over the years.

  • michaelsp closed issue Apr 26, 2020
  • michaelsp added a tag Fixed Apr 26, 2020
  • michaelsp removed a tag Started Apr 26, 2020

To post a comment, please login or register a new account.