UnitIsWarModePhased deprecated in Shadowlands #864


  • Defect
  • Fixed
Closed
  • toludin created this issue Aug 14, 2020

    What version of Grid2 and game type (classic or retail) are you using ?

    v973 in Shadowlands beta v9.0.1 (35522)

     

    What game client version (windows or mac) and language are you using ?

    Windows, English

     

    What steps will reproduce the problem?

    1) Log into Beta client

    2) Note error message on login

      
    Did you try having Grid2 as the only enabled addon and everything else disabled?

    Yes

      

    Was it working in a previous version? If yes, which was the last good one?

    Works in all versions on retail, just broken on beta with the API change

      

    Do you have an error log of what happened? If you don't see any errors, make sure that error reporting is enabled (`/console scriptErrors 1`) or install [BugSack](https://mods.curse.com/addons/wow/BugSack).

     

    3x Grid2\modules\StatusPhased.lua:20: attempt to call upvalue 'UnitIsWarModePhased' (a nil value)
    [string "@Grid2\modules\StatusPhased.lua"]:20: in function <Grid2\modules\StatusPhased.lua:19>
    [string "@Grid2\modules\StatusPhased.lua"]:35: in function <Grid2\modules\StatusPhased.lua:27>

    Locals:
    _ = nil
    unit = "player"
    (*temporary) = nil
    (*temporary) = "player"
    (*temporary) = "attempt to call upvalue 'UnitIsWarModePhased' (a nil value)"
    range = <table> {
    player = true
    }
    UnitIsWarModePhased = nil
    UnitInPhase = nil
    cache = <table> {
    }
    Phased = <table> {
    indicators = <table> {
    }
    GetTexCoord = <function> defined @Grid2\modules\StatusPhased.lua:71
    UnregisterMessage = <function> defined @BigWigs\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:153
    GetColor = <function> defined @Grid2\GridUtils.lua:152
    SendMessage = <function> defined @BigWigs\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:59
    dbx = <table> {
    }
    OnDisable = <function> defined @Grid2\modules\StatusPhased.lua:56
    RegisterEvent = <function> defined @BigWigs\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
    UnregisterAllMessages = <function> defined @BigWigs\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
    IsActive = <function> defined @Grid2\modules\StatusPhased.lua:75
    OnEnable = <function> defined @Grid2\modules\StatusPhased.lua:47
    name = "phased"
    enabled = true
    RegisterMessage = <function> defined @BigWigs\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
    UnregisterAllEvents = <function> defined @BigWigs\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
    UnregisterEvent = <function> defined @BigWigs\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:153
    GetIcon = <function> defined @Grid2\modules\StatusPhased.lua:67
    }

      

    Please provide any additional information below.

    First, huge thank-you for updating Grid2 for the beta. One remaining issue: the API call UnitIsWarModeFlagged was removed in 9.0 and now throws an error in beta. It looks like the correct method to look for War Mode now is to call UnitPhaseReason which will return an enum, and then comparing that enum to Enum.PhaseReason.WarMode.

  • toludin added a tag Defect Aug 14, 2020
  • michaelsp added a tag Started Aug 14, 2020
  • michaelsp posted a comment Aug 14, 2020

    Fixed in r975-beta

  • michaelsp added a tag Fixed Aug 14, 2020
  • michaelsp removed a tag Started Aug 14, 2020
  • toludin posted a comment Aug 14, 2020

    Tested in 975 and this looks to be fixed, but another error has popped up now:

     

    9x Grid2\modules\StatusPhased.lua:20: attempt to call upvalue 'UnitInPhase' (a nil value)
    [string "@Grid2\modules\StatusPhased.lua"]:20: in function <Grid2\modules\StatusPhased.lua:19>
    [string "@Grid2\modules\StatusPhased.lua"]:35: in function <Grid2\modules\StatusPhased.lua:27>

    Locals:
    _ = nil
    unit = "player"
    (*temporary) = nil
    (*temporary) = "player"
    (*temporary) = "attempt to call upvalue 'UnitInPhase' (a nil value)"
    range = <table> {
    player = true
    }
    UnitIsWarModePhased = <function> defined @Grid2\GridUtils.lua:13
    UnitInPhase = nil
    cache = <table> {
    }
    Phased = <table> {
    indicators = <table> {
    }
    GetTexCoord = <function> defined @Grid2\modules\StatusPhased.lua:71
    UnregisterMessage = <function> defined @BigWigs\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:153
    GetColor = <function> defined @Grid2\GridUtils.lua:152
    SendMessage = <function> defined @BigWigs\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:59
    dbx = <table> {
    }
    OnDisable = <function> defined @Grid2\modules\StatusPhased.lua:56
    RegisterEvent = <function> defined @BigWigs\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
    UnregisterAllMessages = <function> defined @BigWigs\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
    IsActive = <function> defined @Grid2\modules\StatusPhased.lua:75
    OnEnable = <function> defined @Grid2\modules\StatusPhased.lua:47
    name = "phased"
    enabled = true
    RegisterMessage = <function> defined @BigWigs\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
    UnregisterAllEvents = <function> defined @BigWigs\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
    UnregisterEvent = <function> defined @BigWigs\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:153
    GetIcon = <function> defined @Grid2\modules\StatusPhased.lua:67
    }

  • michaelsp posted a comment Aug 14, 2020

    Try version r976-beta.

  • toludin posted a comment Aug 16, 2020

    The error is gone; however, my frames have a permanent "out of phase" icon on them, even for myself (haven't tested yet in a group but can try that).

     

  • michaelsp posted a comment Aug 16, 2020

    Maybe r978-alpha ...

  • toludin posted a comment Aug 16, 2020

    Hm, I don't see an r978-alpha file? Was it taken down?

  • toludin posted a comment Aug 17, 2020

    No errors and seems to be working (well, the Phased icon doesn't show on my own frame at least) in v978. I'll hopefully get to try it out in a group sometime soon.

     

    I did encounter an unrelated error swapping profiles for which I'll create a new issue.

  • michaelsp closed issue Aug 17, 2020

To post a comment, please login or register a new account.