LUA error after ready check #866


  • Defect
  • Fixed
Closed
  • guardog88 created this issue Aug 26, 2020

    What version of Grid2 and game type (classic or retail) are you using ?

     retail r955

     

    What game client version (windows or mac) and language are you using ?

    Windows EN-US 8.3.7 (35435)

     

    What steps will reproduce the problem?

    It happens after a raid ready check. But it is not clear what exactly needs to be done to produce the error - probably some people failing the ready check or offline.

      
    Did you try having Grid2 as the only enabled addon and everything else disabled?

    no 

     

    Was it working in a previous version? If yes, which was the last good one?

    No such error before this version

      

    Do you have an error log of what happened? If you don't see any errors, make sure that error reporting is enabled (`/console scriptErrors 1`) or install [BugSack](https://mods.curse.com/addons/wow/BugSack).

     

    24x Grid2\modules\IndicatorIcons.lua:67: bad argument #1 to 'min' (number expected, got nil)
    [string "=[C]"]: ?
    [string "@Grid2\modules\IndicatorIcons.lua"]:67: in function <Grid2\modules\IndicatorIcons.lua:19>
    [string "@Grid2\modules\IndicatorIcons.lua"]:88: in function <Grid2\modules\IndicatorIcons.lua:86>
    
    Locals:
    (*temporary) = nil
    (*temporary) = 1
    (*temporary) = "number expected, got nil"

     

      

    Please provide any additional information below.

     

     

  • guardog88 added a tag Defect Aug 26, 2020
  • michaelsp posted a comment Aug 27, 2020

    Try version r979-beta.

  • michaelsp added a tag Fixed Aug 27, 2020
  • guardog88 posted a comment Aug 27, 2020

     just tested in a 2-man raid, looks okay, the icon now turns into red cross correctly. Will update here if there's anything wrong again.

  • michaelsp posted a comment Aug 28, 2020

    I implemented a workaround (check for invalid data) to avoid the crash, but in theory the reported error should never happen even in the old version. Could you send me your profile ? You can go to Profiles/Import&Export/Export Profile to export the profile to text format. I wish to check if there is some invalid data  or corruption in the profile, or maybe a bug i could no detect yet.


    Edited Aug 28, 2020
  • guardog88 posted a comment Aug 31, 2020

     this is the export from the current version of Grid2 (r979) https://pastebin.com/KjwiT7XG

     

    and this is the LUA file backup before using r979 https://pastebin.com/d83s1cUC

     

    hope they help

  • michaelsp closed issue Sep 13, 2020

To post a comment, please login or register a new account.