WowAce

Could /slwarning slash command be disabled by default and then use the slash command to enable it, since it doesn't save to the saved variables.

i thought, a lot, about that. But if there is no warning, then nobody will ever know why LibStatLogic is failing to understand stats on your items.

i was going to have it disabled by default, when i thought the only things still having problems where things like reputation tabbards. At first i disabled warnings when Mists went live (they were enabled during beta).

But yesterday i discovered that LibStatLogic was not picking up:

• Mastery
• Mining
• Hit

So i turned warnings back on, because we obviously are not done.

Ideally it is a self-correcting problem:

• people see the warnings and report them
• LibStatLogic is updated
• no more warnings

i personally logged into every character, and hovered over every item:

• in my inventory
• my bank
• my guild's bank

and saw no warnings. So as far as i'm concerned there should be no warnings. If you are getting warnings, then please, for the love of god, say what they are.

i think a week or two would be sufficient to catch everything that LibStatLogic is missing; as long as you, and everyone else; report the missing strings here as tickets.

Fair enough, well as you said Reputation Tabbards are throwing warnings. Flintlocke's Woodchucker is also throwing up warnings. Not sure if other Hunter scopes are affected.

<<reply 916918>>

So ideally, what's the best way to report these? I mean, if I leave it on, I feel like I get spammed with tons of them especially when there's items with procs or weapons with apparently fractional damage (why is this a thing?). Do I want to be creating an individual ticket for each one? Do I want to create a singular ticket and copy paste all of them?

Just to have the ones I just got right now:

LibStatLogic: No Match for 'Equip: Your melee and ranged attacks have a chance to trigger an additional attack for 7,423-9,696 physical damage.' Warnings can be disabled by typing /sldebug
[19:08:37] LibStatLogic: No Match for 'Socket Bonus: +10 PvP Resilience' Warnings can be disabled by typing /sldebug
[19:08:37] LibStatLogic: No Match for 'Equip: Increases your pvp power by 100.' Warnings can be disabled by typing /sldebug
[19:08:24] Type '/help' for a listing of a few commands.
[19:08:27] Type '/help' for a listing of a few commands.
[19:08:36] LibStatLogic: No Match for 'Equip: Increases your pvp power by 101.' Warnings can be disabled by typing /sldebug
[19:08:36] LibStatLogic: No Match for 'Flintlocke's Woodchucker' Warnings can be disabled by typing /sldebug
[19:08:37] LibStatLogic: No Match for '+40 PvP Resilience' Warnings can be disabled by typing /sldebug
[19:08:37] LibStatLogic: No Match for 'Equip: Increases your pvp power by 100.' Warnings can be disabled by typing /sldebug
[19:08:37] LibStatLogic: No Match for 'Socket Bonus: +10 PvP Resilience' Warnings can be disabled by typing /sldebug
[19:08:37] LibStatLogic: No Match for 'Equip: Increases your pvp power by 120.' Warnings can be disabled by typing /sldebug

<<reply 918334="">>

i think adding them in one long continuous list is fine.

i see from what you reported so far that there's a lot missing. Although since i never do any PvP at all ever, i never see those items.

Checked in changes:

• 234.56 - 2,345 Damage (i.e. decimal points in weapon damage range)
• Increases your pvp power
• Heirloom ("Equip: Heals you for 2% of your maximum health whenever you kill a target that yields experience or honor.")
• Heirloom ("Equip: Restores 2% of your maximum mana whenever you kill a target that yields experience or honor.")
• Reputation tabbards: "^Equip: You champion the cause of"
• pvp item "Equip: Increases the damage dealt by your Crusader Strike ability by 5%."
• pvp item "Equip: Increases the critical effect chance of your Flash of Light by 2%."
• PvP Relsilience "+40 PvP Resilience"
• PvP Power "+50 PvP Power"
• Flintlocke's Woodchucker enchant

• Level 60 legacy armor: Blood Guard's Lamellar Guantlets "Equip: Increases the Holy damage of your Judgements by 20."

• warnings, by default, will now not be show for other locales (i.e. only for enUS). Other translations are so far behind that they will never be correct

i went to all the token vendors and hovered over everything, the heirloom vendors and hovered over everything, the pvp vendors and hovered over everything.

Get that, and tell me what items are throwing more errors (since i cannot find them)

Edit: Fractional damage was a thing because that's how the regular expression was setup:

^%+?%d+[,%d]* %- (%d+[,%d]*) .-Damage$

when quite obviously it should have been:

^%+?%d+[,%d]*.?%d* %- (%d+[,%d]*.?%d*) .-Damage$

But since the game never showed fractional values for min or max damage it was never an issue.

You should have seen the hell i went through when Blizzard added commas to numbers:

1234

became

1,234

Oh dear god what a mess.

[18:18:43]LibStatLogic: No Match for 'Equip: Your spells have a chance to grant you 1,962 haste for 10 sec and 392 haste to up to 3 allies within 20 yards.' Warnings can be disabled by typing /sldebug [18:18:43]LibStatLogic: No Match for 'Power Torrent' Warnings can be disabled by typing /sldebug [18:18:43]LibStatLogic: No Match for 'Equip: Your spells have a chance to grant you 1,962 haste for 10 sec and 392 haste to up to 3 allies within 20 yards.' Warnings can be disabled by typing /sldebug

oddly enough, doing a /sldebug actually enables the debugging and doing it again, even tho it says it disables debugging, it does NOT saves up upon relog/reloadui. please atleast let us disable all this spam, i do not want to see these same errors 200 times :(

<<reply 922110="">>

Ohhh, crap. The text should say:

Warnings can be disabled by typing /slwarning

Typing /slwarning actually does turn it off. i'll change the message that's displayed with a warning to say /slwarning, rather than what it currently says.

Please keep those warning messages coming!

with the last update, still getting the errors (or warnings) and doing /slwarning only disables them for the current session. please make it so that it disables it for good XD

<<reply 924634="">>

i'll default warnings to off as long as you promise to always turn them on every time you load.

Because if i have the warnings turned off: you might not report them.

no need to default them off i believe, just leaving them default on (even reset default on after every addon update) so that ppl can still see and report the warnings, just add an option to disable them for good (that is, the disable setting to be saved at logout).

<<reply 926882="">>

saved at logout

Unfortunately, since it's a library (i.e. not an addon) it doesn't have any saved variables.

What i think i will do is remember each item i've warned you about and remember it - so that it doesn't get spammed hundreds of times for the item, that session.

But if you're getting spammed with the same item hundreds of times: i add one line to LibStatLogic and the hundreds of warnings go away.

That would be great! thing is, i carry in my bags another weapon and a fishing pole and everytime i would move the mouse above the items in bag (to pick one item) the errors would trigger in chat because i mouse-over on other items on the way to my item. This is all using RatingBuster (which is using LibStatLogic)

I'm getting these warnings for pretty much everything also..
- My Shaman gets for both Landslide AND the Fire/Frost/Shadow damage on No'Kaled.
- My DK gets it for every Runeforge on his weapon.
- My Druid gets it on his Kalu'ak fishing pole AND on his staff for Power Torrent.

It really needs to be disabled until it's more the exception than the rule, that it will trigger a warning...

Deathknight error- LibStatLogic: No Match for "Equip: You champion the causes of your guild. All guild reputation gains are increased by 100%." Warnings can be disabled by typing /slwarning

Shaman Error-

LibStatLogic: No Match for "Power Torrent" Warnings can be disabled by typing /slwarning

LibStatLogic: No Match for "Equip: Improves the range of your Shock and Wind Shear spells by 5 yards." Warnings can be disabled by typing /slwarning

Hunter/Leather Worker-

LibStatLogic: No Match for "Equip: Your attacks may occasionally attract small celestial objects." Warnings can be disabled by typing /slwarning

LibStatLogic: No Match for "Equip: Skinning skill increased by 10." Warnings can be disabled by typing /slwarning

LibStatLogic: No Match for "Equip: You champion the causes of your guild. All guild reputation gains are increased by 100%." Warnings can be disabled by typing /slwarning

Mage/Engineer/Cooking/First Aid/Archeology-

LibStatLogic: No Match for "Equip: Allows you to cook faster." Warnings can be disabled by typing /slwarning

LibStatLogic: No Match for "Power Torrent" Warnings can be disabled by typing /slwarning

LibStatLogic: No Match for "Equip: You champion the causes of your guild. All guild reputation gains are increased by 100%." Warnings can be disabled by typing /slwarning

LibStatLogic: No Match for "Equip: You champion the causes of your guild. All guild reputation gains are increased by 50%." Warnings can be disabled by typing /slwarning

Warlock/Tailor/Cooking/Fishing/First Aid/Archeology-

Chef's Hat- ItemID: 46349 LibStatLogic: No Match for "Equip: Allows you to cook faster." Warnings can be disabled by typing /slwarning

Renowned Guild Tabard ItemID: 69210 LibStatLogic: No Match for "Equip: You champion the causes of your guild. All guild reputation gains are increased by 100%." Warnings can be disabled by typing /slwarning

LibStatLogic: No Match for "Power Torrent" Warnings can be disabled by typing /slwarning

Priest/Tailor/Cooking/First Aid/Fishing/Archeology-

Chef's Hat- ItemID: 46349 LibStatLogic: No Match for "Equip: Allows you to cook faster." Warnings can be disabled by typing /slwarning

Inherited Cape of the Black Baron ItemID: 62039 LibStatLogic: No Match for "Equip: Experience gained from killing monsters and completing quests increased by 5%." Warnings can be disabled by typing /slwarning

Renowned Guild Tabard ItemID: 69210 LibStatLogic: No Match for "Equip: You champion the causes of your guild. All guild reputation gains are increased by 100%." Warnings can be disabled by typing /slwarning

Druid/Leatherworking/Cooking/First Aid/Fishing/Archeology-

Chef's Hat- ItemID: 46349- LibStatLogic: No Match for "Equip: Allows you to cook faster." Warnings can be disabled by typing /slwarning

Renowned Guild Tabard ItemID: 69210- LibStatLogic: No Match for "Equip: You champion the causes of your guild. All guild reputation gains are increased by 100%." Warnings can be disabled by typing /slwarning

Illustrious Guild Tabard ItemID: 69209- LibStatLogic: No Match for "Equip: You champion the causes of your guild. All guild reputation gains are increased by 50%." Warnings can be disabled by typing /slwarning

Warrior/Blacksmithing/Cooking/First Aid/Fishing/Archeology-

LibStatLogic: No Match for "Landslide" Warnings can be disabled by typing /slwarning

Burgy Blackheart's Handsome Hat ItemID: 65665- LibStatLogic: No Match for "Equip: Succumb to the curse of Burgy Blackheart." Warnings can be disabled by typing /slwarning

Paladin/Jewelcrafting/Mining/Cooking/First Aid/Fishing/Acheology

Skullpiercer Pauldrons ItemID: 69582 LibStatLogic: No Match for "Socket Bonus: +10 Expertise" Warnings can be disabled by typing /slwarning

LibStatLogic: No Match for "Power Torrent" Warnings can be disabled by typing /slwarning

Illustrious Guild Tabard ItemID: 69209- LibStatLogic: No Match for "Equip: You champion the causes of your guild. All guild reputation gains are increased by 50%." Warnings can be disabled by typing /slwarning

Renowned Guild Tabard ItemID: 69210- LibStatLogic: No Match for "Equip: You champion the causes of your guild. All guild reputation gains are increased by 100%." Warnings can be disabled by typing /slwarning

if you have posted all your errors or makes your chat unreadable trough the spam you can disable it by doing this go to the the following folder :

World of Warcraft\Interface\AddOns\RatingBuster\libs\LibStatLogic-1.2 in that folder open LibStatLogic-1.2.lua with wordpad (rightclick open with then wordpad dont forget to uncheck the box).

then use the search to look for the word ''true'' and change the first 3 entry's you find to ''false'' and save the document. the message should now no longer be shown untill you update the addon.

if me showing how to disable this bugs the dev of the addon i'm sorry but its the least i could have done after all if you reported all your errors theres no further use for the function for that player. and seeing all my errors are posted here theres no need for me to be spammed anymore and this counts for many people. a build in report function could also be a better idea for a future version and a lua that actualy saves all the reports that have bin made so they dont show up again. after all getting a report once makes sense getting it 500 times is rather excessive.

<<reply 946010="">>

If it's still happening then i still need to know about it. As far as i was concerned they were all fixed.

If not, then i want to know about it. This is exactly why i want it turned on. Now nobody will never now the values or wrong because you won't even know the values are wrong.

i like it if the adopters of alpha software to help me get it to a beta level.

@JackTripper: Go

i have seen all buggs i expeirence posted here so there is NO reason for the spamming to be on my screen untill there is a update period.

IF after a future update they still show then im sure that it will get posted again and again untill its fixed. seeing updating this addon removed the fix i posted . so when people update they will see the errors again and post here. if they do not they wherent the kind of people that post feedback anyway.

so do not worry just work with the errors you have now release a new version and when people update we will see if it gets fixed. but intill there is a new version i dont see the need for spam seeing its already reported :)

Socket Bonus: +10 Expertise Skullpiercer Pauldrons ItemID: 69582

  /dump StatLogic:GetSum("item:69582")

Already fixed (20120915)

Power Torrent

  /dump StatLogic:GetSum("item:77196:4097:0:0:0:0:0:0")

Fixed 20120915 (r129)

Equip: You champion the causes of your guild. All guild reputation gains are increased by 50%. Illustrious Guild Tabard ItemID: 69209

Fixed 20120915 (r129)

Equip: You champion the causes of your guild. All guild reputation gains are increased by 100%. Renowned Guild Tabard ItemID: 69210

Fixed 20120915

Landslide

  /dump StatLogic:GetSum("item:77196:4097")

Fixed 20120915 (r129)

Succumb to the curse of Burgy Blackheart. Burgy Blackheart's Handsome Hat ItemID: 65665

  /dump StatLogic:GetSum("item:65665")

Fixed 20120915

Equip: Allows you to cook faster. Chef's Hat- ItemID: 46349

  /dump StatLogic:SetTip("item:46349")

Fixed 20120915 (r129)

Equip: Your attacks may occasionally attract small celestial objects. Ricket's Magnetic Fireball

  /dump StatLogic:GetSum("item:70144")

Fixed 20120915

Equip: Skinning skill increased by 10. Finkle's Skinner

  /dump StatLogic:GetSum("item:12709")

Fixed 20120915 (r129)

Equip: Improves the range of your Shock and Wind Shear spells by 5 yards.

  /dump StatLogic:GetSum("item:51510")

Fixed 20120915 (r129)