#87 Update for 8.1.5 - Issues - OneBag3 - Addons - Projects

Update for 8.1.5 #87

Closed

MakeMeLaugh27 created this issue Mar 12, 2019

Addon stopped working after today's update(8.1.5).

Thank you.
gemini1661 posted a comment Mar 12, 2019

3x FrameXML\ItemButtonTemplate.lua:54: attempt to index local 'icon' (a nil value)
FrameXML\ItemButtonTemplate.lua:54: in function `SetItemButtonTexture'
FrameXML\ContainerFrame.lua:581: in function <FrameXML\ContainerFrame.lua:526>
...OneBag3\libs\OneCore-1.0\OneCore-1.0\OneCore-1.0-9999.lua:252: in function `UpdateBag'
...OneBag3\libs\OneCore-1.0\OneCore-1.0\OneCore-1.0-9999.lua:267: in function `UpdateFrame'
OneBag3\OneBag3-v3.10.1.lua:36: in function <OneBag3\OneBag3.lua:29>
[C]: in function `Show'
OneBag3\OneBag3-v3.10.1.lua:228: in function `OpenBag'
OneBag3\OneBag3-v3.10.1.lua:129: in function <OneBag3\OneBag3.lua:126>
[C]: ?
...ore\libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:29: in function <...ore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
...ore\libs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua:64: in function `Fire'
DataStore\libs\AceEvent-3.0\AceEvent-3.0-4.lua:120: in function <DataStore\libs\AceEvent-3.0\AceEvent-3.0.lua:119>
[C]: in function `TurnOrActionStop'
[string "TURNORACTION"]:4: in function <[string "TURNORACTION"]:1>

Locals:
button = OneBagFrameBag0Item1 {
0 = <userdata>
BagStaticBottom = <unnamed> {
}
BagStaticTop = <unnamed> {
}
flash = <unnamed> {
}
GetItemContextMatchResult = <function> defined @FrameXML\ContainerFrame.lua:1425
ExtendedSlot = <unnamed> {
}
ExtendedOverlay2 = <unnamed> {
}
JunkIcon = <unnamed> {
}
UpdateTooltip = <function> defined @FrameXML\ContainerFrame.lua:1347
ExtendedOverlay = <unnamed> {
}
meta = <table> {
}
border = <unnamed> {
}
handler = <table> {
}
ShouldShow = <function> defined @OneBag3\libs\OneCore-1.0\OneCore-1.0\OneCore-1.0.lua:74
timeSinceUpgradeCheck = 0
UpgradeIcon = <unnamed> {
}
BattlepayItemTexture = <unnamed> {
}
flashAnim = <unnamed> {
}
NewItemTexture = <unnamed> {
}
newitemglowAnim = <unnamed> {
}
SplitStack = <function> defined @FrameXML\ContainerFrame.lua:1100
}
texture = nil
icon = nil
(*temporary) = "OneBagFrameBag0Item1IconTexture"
(*temporary) = nil
(*temporary) = "OneBagFrameBag0Item1"
(*temporary) = "attempt to index local 'icon' (a nil value)"

Included error details in spoiler.

Blizzard made a change to ItemButtonTemplate. Found a post here:
https://www.wowinterface.com/forums/showthread.php?p=331510

Edited Mar 12, 2019
thunderlibra67 posted a comment Mar 12, 2019

please let us know when the fix is made. I rely on Onebag and Onebank. I feel I would have difficulty playing if I had to relearn after using it all these years. Your addon is very much appreciated.
Piraticus posted a comment Mar 12, 2019

same :x

used onebag and onebank for so many years they feel like a necessity :p
eagerly awaiting a fix :)
cheers
george_mavrin posted a comment Mar 13, 2019

Please fix this problems
Kaelten posted a comment Mar 13, 2019

hey all, will look into this soon. I've been running high fevers the last few days so I didn't even see these until now :(
shannaroxx posted a comment Mar 13, 2019

When I wanted to use OneBag or OneBank only the frame opened but I can't see any item. I also want to thank you for your engagement and it's horrible to work without this addon.
Zulandia posted a comment Mar 13, 2019
Easy fix until a new version is posted:

Line 133 of OneCore-1.0.lua currently reads:
```
local slot = CreateFrame("Button", parent:GetName().."Item"..id, parent, slotType)
```
Changing it to:
```
local slot = CreateFrame("ItemButton", parent:GetName().."Item"..id, parent, slotType)
```
Should get everything working again.
elhao84 posted a comment Mar 14, 2019

Thank you very much Zulandia, that fix works perfectly.

Hope you get better soon, Kaelten!

Edited Mar 14, 2019
TightwadTheMage posted a comment Mar 14, 2019

I am having an issue with your "fix" of changing line 133 of OneCore-1.0.lua. I do not have nor have i ever had onecore installed to make onebag or onebank work. I have always just had the two addons installed and I never had onecore installed. How do i fix this issue if i do not have onecore installed (I do not want to install anything else).
jleafey posted a comment Mar 14, 2019

If you look in the directory containing the code for OneBank3 or OneBag3 you should find a libs/ directory containing another directory with a copy of OneCore along with a bunch of Ace libraries. Distributing libraries used by an addon this way is a common (if messy) practice and has no adverse effect other that chewing up a bit more disk space with multiple copies of duplicated libraries. On my system the file that needs to be edited is in the addons\ folder under OneBank3\libs\OneCore-1.0\. If you have both OneBank3 and OneBag3 I believe you will need to edit OneCore-1.0.lua in both places. It will only load one copy of the library, but which one is probably not deterministic.
Kaelten posted a comment Mar 15, 2019

I have an update out that fixes the issues for me locally. Some people reported issues with the fix. Please let me know if you guys have problems with it.
Kaelten closed issue Mar 15, 2019

To post a comment, please login or register a new account.