OneBag
NOTICE
<big>This version is no longer maintained! I'm working as fast as I can to get the new version to a better state but it does have base line functionality.
Check out the new true OneBag as it's being developed! </big>
END NOTICE
OneBag is a replacement for the default game bags that combines all the bags into one frame. There are already addons out there that do this, so why OneBag? Mainly because I wanted a simpler, more system-friendly bag. OneBag doesn't entirely rewrite the bag-handling interface like others do. It simply rearranges the bags into one and allows the default UI to continue managing the bag slots. This means that addons such as KC_Items, ItemSync, LootLink, and SellValue should be inherently supported. As long as an addon is compatible with the default game bags, it should work with OneBag. This was my goal, anyway. For my uses OneBag has succeeded. Hopefully you will have similar results.
Features
- Combines all your character bags into one.
- Customizable number of columns.
- Displays the total number of slots, by slots used and type. Types being that ammo, soul bags, and professions bags all get a seperate count.
- Inherent support for addons such as KC_Items, ItemSync, LootLink, and SellValue, with no need for special code.
- Color coded slots by item rarity or bag type.
- Will automatically open for you when you visit the auction house, bank, mailbox, merchant, or when entering a player trade.
- Customizable display of only certain bags, either but slot number, or by type.
- Gives you a bag bar for easy manipulation of your bags.
- You can mouseover the bags on the bar to highlight the slots from that bag. You can also lock this highlight by clicking.
- Customize the scale and alpha of the frame.
- Provides an easy to use graphical config menu.
I have the same problem. I think it'sbecause one of my other mods tries to add a confirm box, which is suppressed somehow... if I disable OBB I directly get that box. Not sure if it's CTMod or Nurfed o_O
just tried to buy an extra bank slot n nothing happend i had to disable mod and buy it then reenable mod ... not sure why this happened or if this is known issue but thought i would post the problem found in 1.4.1
THis mod is prety sweet but i like to have the base bag on the bottom so all my loot is placed in the bottom slots first. All In One Inventory has support for this by allowing you to reverse the bag order. anyway you could add support for this too?
You'll have to give me more specific on what you mean by it being broken. I have other German users (particularly Neriak who provided translations) who haven't reported any problems.
And it's rather easy for you to learn what Ace does: http://www.wowace.com http://rousing.pbwiki.com/index.php?wiki=UnderstandingDependencies
Having used MyInventory/MyBank for quite some time but disliking changes in recent versions, I recently left them behind for this fine piece of code. However, I have two suggestions to make:
- I do not really like the Ace dependency, as I don't see what it does for the addon, that could not be easily done otherwise & Ace seems broken on my (german, deDE) client - OneBag does not save the settings (especially the cols parameter) per-character, forcing me to set this each time I switch chars - this is a pain. But then again, it might just be that Ace's broken...
Other than that, great job on this one! (Nice looking code, too.)
Every time I log on with my hunter, my ammo are in my bags, including my ammo pouch. That's really annoying!
Doesn't all that kind of defeat the purpose of having "OneBag"?
Thanks for the mod. It's quite nice. That being said, I have a few feature requests, too:
1. Group bag slots instead of starting with bag 0 and moving left to right with the slots. For instance, runecloth bag would occupy a 4x4 area instead of a 1x16 area (column settings permitting).
2. Allow custom separation (somewhat like cellspacing) per cell. This would not apply across all cells, but for the current cell only. For instance, for onebag position (1,4), the user could increase the cellspacing above it to X width. Continuing with cellspacing for the tops of (2,4) and (3,4), then cellspacing on the right side of (3,4), (3,5), and (3,6) the user would effectively "set aside" a 3x3 grid for items.
You write: "... Right now there's no way to determine what contents belong to what bag expect by counting out the bag slots. The backpack starts at the top left and the other bags follow after."
But wouldn't that be sufficient to be able to highlight items in a specific bag? I'm guessing that there is some sort of OnMouseOver event when you hover the mouse over a bag (since the bag is highlighted when you do). When that happens you know what bag is highlighted, and then you could count your way to the items in that bag and highlight them.
I don't know add-on coding so I'm guessing here though... :)
Thought of something else, a problem all the single bag mods seem to have.
9) If you have OneBag enabled and OneBankBag disabled, and you open the bank then your extra bank bags, they open on top of the OneBag inventory. They aren't 'pushed aside' by the OneBag the way they are by the default bags. Can this be fixed? (Without using a mod like 'MoveAnything'... I like how the bags are dynamically placed and don't want them to be in fixed positions.
I've tried all (I think) of the different single inventory mods out there, and haven't been able to find one that's 'perfect' to my liking. But hope springs eternal, so I thought I'd post a list of things I'd like to see, for your consideration:
1) Make an option for 'default' style bag art, like AIOI has.
2) When using the current frame, add an option to set the alpha value.
3) Make the bag window's 'priority', for lack of a better word, equal to that of the AH window, so the bag can be pulled in front of the AH window, or fall behind it when the AH window is clicked.
4) Make the slash commands more intuitive, like an /ob disable and /ob enable command. Or /ob on, /ob off. Having to type '/ob noreplace' to turn -on- replacing bags is kind of counter-intuitive.
5) Save settings seperately for each character, if it isn't there already.
6) Integrate support for KC_Bank and KC_Inventory so you can switch the bank or inv view dynamically to see your other chars' items (MyBags has this)
7) Add an option to not show the bag slots in the bankbag, or move them. I hate how they're at the top left of the window and are not hideable or moveable. If they were at the bottom and seperated slightly from the main bank of inv slots, that'd be okay.
8) Add an option to dis-include ammo bags, or to show their contents as a seperate section of the OneBag at the top or bottom. (Divided by a border and a little space)
Well, that's all I can think of for now. If I mentioned anything which your mod already does, my apologies.
Thank you for your consideration.
The tooltip alignment is still in 1.4.1 (possibly broken in 1.4). It's a static alignment, though. You can force them to display to the left or right. I didn't change this feature. If you need to prevent tooltips from floating offscreen, get Tipster. It was made specifically for that.
Was WoWEcon updated again? I submitted the fix to them the last time they updated. If they haven't updated, the current file should still work. In any case, I'll look at it later and test it out myself.
First of all i just want to say great mod! I was just wondering if you could update the wowecon fix to the latest version. The dual text displayed is the only i am having right now.
I tested some more and I'm not sure that OneBag is causing the problems with BoC. I'll take it up in the BoC forum instead. However, I still like the tooltip alignment in 1.3 a lot better than in 1.4 (where there is none). It's very annoying that the tooltip keeps showing outside the screen area.
But still.... Great add-on :)
Yes, StopTheLagness! is for stopping this lag. It worked in my tests and so far those of a few others who've given me feedback. I'm hoping to turn that addon into a broad lag-killer. :)
painstorm, are you sure you installed 1.4.1? 1.4 had a tooltip problem, so I removed the code and reverted it back to the way 1.3a was handling tooltips. If 1.3a works, 1.4.1 should also, but 1.4 will be bugged.
Just downloaded and installed version 1.3a instead of 1.4. BoC works perfectly there, and the same does the tooltip alignment :) I've never had problems with 1.3, so I think I'll just stick with that until a bug fix for 1.4 is released.
Has it ever worked with OneBag? 1.4 introduced some tooltip interference because I was trying to get a handle on these tooltip lag concerns, but I backed those out in 1.4.1. Make sure you're running 1.4.1 and not 1.4. I'd test this myself, but I have no active crafters to test with.
I have done some testing and I can see that the new 1.4.* versions of OneBag breaks BoC: http://www.curse-gaming.com/mod.php?addid=1397 Without OneBag enabled BoC works fine.
BoC won't show any information about recipes when OneBag is active.
I've noticed a lot of confusion lately about dependencies, a lot of folks don't seem to really know what they are or what purpose they serve. I've written up on dependencies elsewhere but I figured it'd be best to put up an example on my Wiki ...
http://rousing.pbwiki.com/index.php?wiki=UnderstandingDependencies
Anyone else can feel free to point folks here, too.