OneBag
NOTICE
<big>This version is no longer maintained! I'm working as fast as I can to get the new version to a better state but it does have base line functionality.
Check out the new true OneBag as it's being developed! </big>
END NOTICE
OneBag is a replacement for the default game bags that combines all the bags into one frame. There are already addons out there that do this, so why OneBag? Mainly because I wanted a simpler, more system-friendly bag. OneBag doesn't entirely rewrite the bag-handling interface like others do. It simply rearranges the bags into one and allows the default UI to continue managing the bag slots. This means that addons such as KC_Items, ItemSync, LootLink, and SellValue should be inherently supported. As long as an addon is compatible with the default game bags, it should work with OneBag. This was my goal, anyway. For my uses OneBag has succeeded. Hopefully you will have similar results.
Features
- Combines all your character bags into one.
- Customizable number of columns.
- Displays the total number of slots, by slots used and type. Types being that ammo, soul bags, and professions bags all get a seperate count.
- Inherent support for addons such as KC_Items, ItemSync, LootLink, and SellValue, with no need for special code.
- Color coded slots by item rarity or bag type.
- Will automatically open for you when you visit the auction house, bank, mailbox, merchant, or when entering a player trade.
- Customizable display of only certain bags, either but slot number, or by type.
- Gives you a bag bar for easy manipulation of your bags.
- You can mouseover the bags on the bar to highlight the slots from that bag. You can also lock this highlight by clicking.
- Customize the scale and alpha of the frame.
- Provides an easy to use graphical config menu.
Love the addon. I replaced AIOI and MyBank with this. Unfortunately I miss the ability to check my other characters bank contents from any char as that greatly helps with crafting management. Please consider adding this functionality. I'd also like to request the option of not having your ammo bag show when opening your main bag but instead have it show when you want to check its contents. Anyway, again, great job!
After that awful subject line, Turan ... I have this strange, strange urge to play Flight of the Amazon Queen. Curses! Like I didn't have enough distractions.
Howell! At least I get to remind myself what was good about adventure games.
Do I have anything important to add? Not really. I'm just glad that these AddOns are gaining recognition and now with ammo-borders, if I were still playing Warcraft I would praise the ground Turan walked on.
I love that simpleness and that this combines two great mod ideas.
1) The Inventory bag won't auto open at the Mailbox for me. Autoopens fine at a vendor and the AH. (I've checked to ensure that the setting is enabled).
Edit: Just read the post below. MyInventory autoopens fine at the mailbox -- OneBag does not. (I'm also running AuctionIt, which I seem to think has some impact on all of this.)
2) I really dig the fact that MyInventory displays the actual bags in a row on top of the frame. I use AdvancedBagsPlus, so my acutal bags are very hard to manipulate in the (admittedly) rare case that I get a bigger bag and need to swap it out with an older and smaller one. Sure, I can disable ABP, swap my bags out, and reenable ABP, but that just sucks.
Thanks!
So I decided to glance at what it may take to impliment scaling. SetScale()? No, it can't be -that- easy. Hahahaha. I shrunk my bag to the size of a peanut then to the size of my house.
Anyway, there's scaling for ya. /ob or /obb scale <0.2 to 2.0>
And btw, the color coding must be turned on with /ob or /obb colorcode if you already had OneBag installed.
Thanks a lot for this, really snappy and its a sure keeper for me.
Since it appears I won't get away from this request, I've added color coding of slot borders. ;) However, I'm not sure this is exactly what you're all looking for. It's not too noticeable on my screen, but my scale is set pretty small. Let me know if you have any suggestions for improvement.
@devla
I looked at how CooldownCount works and it looks like my idea won't work. But there is a frame for every item slot in OneBag just like there is for MyInventory. You just need to parse out the naming as I suggested. If you'd like email your files ([email protected]) and I'll provide you the names.
@Koalachan
I will look at the scaling. It seems like it might not be too difficult to implement, so I'll give it a whirl.
On the mailbox thing, very strange. There actually isn't any code in OneBag that forces open the bag at the mailbox, but that's because the UI by default opens the backpack, which has always caused OneBag to open for me. It's odd that it doesn't work like that on yours. Is there possibly an addon in your UI that's suppressing the default bag open?
I'll look at changing it anyway to try to make sure it's forced open if the option is on.
It didn't when I just tested this addon while the option was enabled (confirmed by chat).
My initial reaction was 'eek, my bag buttons are so large again, I can't live with this!'. But when I opened the bank and got the 2 screens fluently together... Then I noticed how bags were easily adapted. And how functionality with other mods that use bags got restored... Weeeell, I'll keep Onebag :-)
But what I do miss from similar programs is the colorcoding and the ability to scale. And since your layout for bank+bags is so great, you now also make me dislike the other bankitems Addons so I'll start dreaming of getting that in your format too some day.
Very well done. Thanks.
Hmm well I'm really not sure.
I did up the plugin for MyInventory, which had a frame for each bagslot in its xml. It seems like alot of unnecessary repetetive code to me, however I think thats the only way for Cooldowncount to work properly.
I dunno its not super important, don't spend too much time on it...unless there's a cooldown addon written with ACE lol :)
Thanks
Could you make the color of the border of an item match the quality color of that item?
Gods, what an awful subject line. :)
xaviorm, I now what happened! NeT recently added a new category, Development Tools, which Ace is under. When you click the dependency link above, this category is unchecked, so Ace doesn't appear. I will inform NeT of this.
In the meantime, here is Ace: http://www.curse-gaming.com/mod.php?addid=1744
@Sharky
You won't see much, Sharky. OneBag is meant to be light, not feature-packed. I will add some small features when I can to help with convenience, but otherwise, OneBag is exactly where I intend it to be. I used the original MyInventory because I didn't want all those extra features. When MyInventory turned out to be overly buggy, I wrote OneBag with the intenion of keeping it just as simple.
@devla
Those $parent strings in the XML translate into a full name you can use. It should be OneBagFrameSub0Item1 for the first slot of the backpack, then Sub1-4 would correspond to the extra bags.
I might also be able to offer a better solution. In the interests of making OneBag a complete replacement for the default bags and needing no special support, I can provide mapping of the default bags to OneBag's slots. Then you can use the original names and there should be no need to write it specifically for OneBag. Let me know if you think this would work.
WHere do you get Ace now. It doesn't show up in the search
I tried making a Cooldowncount plugin for OneBag and can't pin down the slot frames, since it appears they are referred to as $parentSlots and CC likes individual named frame numbers.
If anyone figures it out please share.
Thanks
I see your point in making this addon, but myinventory and mybank have still more features (especially scaling, transparency, seeing bank content/money of other characters and a UI to configure the settings), so I will wait and see how this addon developes.
Sorry about the error. That was the result of a snippit of leftover code. Btw, OneBag is set up so that if you don't want OneBankBag, you can delete the OneBankBag.* files and OneBag will still run.
New feature added: The bag will now open at a player trade. You have to type /ob opentrade to enable this if you already have OneBag installed. On new installs, it is enabled by default.
I looked at setting transparency but the way OneBag is currently designed, I can't figure out how to set just the background transparency. I ended up changing the transparency on everything, items included. I know I can separate the background into its own frame and do it that way, but if anyone else has some easier ideas, let me know.
Whn I type /obb disable
[string "Interface\AddOns\OneBag\OneBankBag.lua"]:40: attempt to call fieldn 'Disable' (a nil value)
No, it won't, but that's a good idea. It should be a quick change.
I dare sleep for a few measely hours and someone formed a party in my living room! Ah, well, the more the merrier.
@halfelven
@painstorm
Rowne and xelepart already answered your initial comment, but I'll add a bit more of what prompted me to write OneBag. You see, I never wanted to write a bag mod. AIOI was too bulky for me, so I started using MyInventory. This was before Ramble took it over. I started OneBag back in April, at the same time I started Ace. MyInventory was buggy and my initial plan was just to clean it up. I realized it needed a rewrite, and I also realized that it was replacing default UI routines that it didn't need to.
Your question about OneBankBag was answered too, but I'll clarify. The screenshot shows OneBankBag on the top and OneBag on the bottom. When you open your bank, you see OneBankBag now instead of the default bank frame.
@xelepart
Thank you very much for the comments and compliments. I saw your PM and will respond shortly.
@Eraphine
It would be possible to store the bank info fairly efficiently. I'm mostly retired from addon coding now, though, so I don't know what I'll get a chance to do. I'm sticking around mainly to finish a few addons and ensure my new ones are stable, then Kaelten has agreed to take them over.
@Maylin
As I mentioned above, I don't know how much I can get done, but I'll try to implement some of these simpler requests. Transparency should be easy enough, I think. The rest, I'm not sure.
@Brakeman
I'm trying to think of a simple way to make it distinguishable visually. The bags are aligned in order from right to left, starting with your backpack. So the first slot of OneBag will be the first slot of your backpack. After that will be bag one, then bag two, etc. So you should be able to count manually to find the right slot number.
will this auto open on player trades as well?
Some of my mods look for a certain slot in a certain bag to be swapped equipped. With your mod can I tell what each slot number and bag number it would have been in?
Thanks