OneBag
NOTICE
<big>This version is no longer maintained! I'm working as fast as I can to get the new version to a better state but it does have base line functionality.
Check out the new true OneBag as it's being developed! </big>
END NOTICE
OneBag is a replacement for the default game bags that combines all the bags into one frame. There are already addons out there that do this, so why OneBag? Mainly because I wanted a simpler, more system-friendly bag. OneBag doesn't entirely rewrite the bag-handling interface like others do. It simply rearranges the bags into one and allows the default UI to continue managing the bag slots. This means that addons such as KC_Items, ItemSync, LootLink, and SellValue should be inherently supported. As long as an addon is compatible with the default game bags, it should work with OneBag. This was my goal, anyway. For my uses OneBag has succeeded. Hopefully you will have similar results.
Features
- Combines all your character bags into one.
- Customizable number of columns.
- Displays the total number of slots, by slots used and type. Types being that ammo, soul bags, and professions bags all get a seperate count.
- Inherent support for addons such as KC_Items, ItemSync, LootLink, and SellValue, with no need for special code.
- Color coded slots by item rarity or bag type.
- Will automatically open for you when you visit the auction house, bank, mailbox, merchant, or when entering a player trade.
- Customizable display of only certain bags, either but slot number, or by type.
- Gives you a bag bar for easy manipulation of your bags.
- You can mouseover the bags on the bar to highlight the slots from that bag. You can also lock this highlight by clicking.
- Customize the scale and alpha of the frame.
- Provides an easy to use graphical config menu.
That's pecular. I ran my own tests with MyBags and saw it using no memory vs. memory consumption with OneBag/default bags. I imagine the problem varies depending on which addons are installed, because the primary problem is with the game. In 1.7 they seem to have changed tooltips to update constantly, whereas prior they at least used a little intelligence to update less often.
Basically there are two solutions that I can see. One is a custom tooltip like MyInventory uses, but I'm not going that route, because it causes too much maintenance to support other addons. The other is to trap Blizzard's button OnUpdate and force it to be intelligent. That's the route I'm going to try for now, but it looks like I'll probably implement that in a separate addon because I consider it a general game fix that can help those who don't use OneBag.
And as far as not caring about this stuff, I hear you. I and many others have lamented this often, and that's what we're working against at Ace. So far we're basically a community of people who've gotten sick of laggy addons. It irks me that changes like this in Blizzard's own UI defeat our attempts and force us to fix their code. :(
ramble's Mybags mod suffers from even more extreme memory usage than does this mod. that's actually why i was looking to this for a replacement at first, but i'm still on myinventory (fixed for 1.7).
mybags uses .4mb per second, and .8 mb per second with both inv & bank frames open >.< and it even uses that much mem without mousing over anything - just having them open is enough. i wouldn't suggest taking code from mybags til it's fixed :P
myinventory however, is rock solid - no mem usage at all, and thats why i'm still using it, and why i still recommend it as the best all in one inventory mod out there atm.
really hoping you can fix the mem usage :p i'm glad you can see it, some authors dont care about this stuff and just let it go the way it is, but more an more of the community is becoming aware of it :) the first time i found out about this was tracking down teh huge HUGE mem usage of cosmos mods, and found that there were literally hundreds of OnUpdate calls being made - causing mem usage to go thru the roof.
anyway, thanks again for the quick response, im just trying to pass along as much info as i can ;)
I've determined that removing tooltip realignment doesn't seem to solve anything. I've also compared to the default game bags and they suffer from the same memory consumption. And this is a problem that seems to have been introduced in game patch 1.7. Since OneBag is mostly just a repackaging of the default game bags, it's likely to inherit whatever problems those bags develop. I'll see what Ramble did in MyBags that's circumventing this problem and try to apply it to OneBag. I know that MyInventory uses its own custom tooltip, but this poses a series of different problems. I believe Ramble used a different approach in MyBags.
I am taking note of all feature requests, but I won't be able to add many very quickly. Some I doubt I'll ever add. Bank display is at the top of my list to add as well as some of the simple cosmetic changes like toggling off the close buttons and bag text. Auto-stacking is beyond the scope of OneBag. Toggling of specific bags is something I'd like to get to eventually. Right now there's no way to determine what contents belong to what bag expect by counting out the bag slots. The backpack starts at the top left and the other bags follow after.
On the memory usage, the problem stems from OneBag realigning the tooltips, a feature I added by request. Any hooking of the tooltip will amplify memory consumption, because the game rebuils tooltips, whether they need it or not, several times per second. I tried in 1.4 to diminish this effect but that caused problems. What I can do next version is just provide the option to turn this feature off.
As far as Ace goes, all I'm going to say is that if this is the only Ace addon you're using, do your UI a favor and visit http://www.wowace.com
first, please let us remove the Title and Buttons from the onebag window. takes up more space than really needed. i know what char i'm on and dont need to see my name's inventory in the title :) i use a keybind to open/close the frame too so the button is unnecessary. myinventory/mybags has this functionality and would like to see it included here if possible :)
second, and this is a biggy...if i open the OB frame and mouse over any item, my memory usage goes up up up and never stops. it seems to go up by .07mb every tick, which is about .14mb every second or so. i use auctioneer and goodtip and gypsy - those are my only addons that do anything to the tooltip that i'm aware of. again, myinventory does not behave this way. sure there's an initial bump in mem usage to populate the tooltip with info from auctioneer but then it stops.
cant use addons that incrememt mem usage by so much so often, or my garbage collection cycle is too frequent, which leads to stuttering/freezes/lag.
if mem usage was stable this mod would rock :) the other stuff is just cosmetic :)
last but not least, is there any way to remove the ace dependency? this would be the only mod i have that needs it, and hate to use mods with any dependencies :/
ps - using uimem to monitor the mem usage.
thanks!
Ah, as Highend says, the mail 'problem' I mentioned was with CT_MailMod, not the original mailbox. I've been running with that mod for too long, forgot it wasn't a standard feature D:
(taken from BOLL):
- Auto-stacking. Default Off, if possible stacks items looted from mails into stacks in your inventory. - Bags in a separate row in the bank, and maybe the ability to show your normal bags at the top of your inventory as well, in the same fashion.
^^ Good feature requests imho :) The seconde one should be configurable as well (turn it on or off if you want to see your bag icons in a different row)
I have 3 feature requests as well (and I list them here because I think/hope then could be done with little effort):
- Compability with the mass mail feature of ct_mod so that all items that are pulled into the mass mail window are greyed out in the OB inventory.
- The option to switch the sort order of the bags in OB. ATM it shows all items of your backpack at the top and the other bags underneath it. Reversing this (items from backpack at the bottom and the other bags and their items above it) would be a great option (at least for me).
- Last one: An Option to exclude bags completely in the OB inventory. Why that? I'm playing a warlock and I usually have at least one bag full with soulshards. I don't need this bag to show in my OB inventory because I'm using shardtracker as an addon that displays the number of shards in a single icon and that's enough I need to know.
Any chance to include these feature requests?
Thanks for your good work on this nice addon!
Regards, Highend
How do you tell which item is in which bag when "one bag" is open? The reason I ask is: What if I find a nice new bag I want to use, how do I know which bag to empty and move around and such. Or do you use the /standby command to turn off "one bag". How do you turn it back on?
Lovely mod :) Imo the colored item borders makes this mod outstanding :D In an old version I would have the wrong items turn gray when mailing, but now none turn gray at all :p which suites me fine tbh, better than the wrong ones. Thanks for the lock feature, and the fixed alttab-scaling problem :)
I have a few suggestions, which I don't know if they are in line with what you aim for, but here goes. Auto-stacking. Default Off, if possible stacks items looted from mails into stacks in your inventory. (not sure if it's useful elsewhere) Bags in a separate row in the bank, and maybe the ability to show your normal bags at the top of your inventory as well, in the same fashion.
Cheers :)
First, the details.
I backed out some changes I made to try to improve tooltip efficiency. Hopefully this will fix the tooltip problems.
'standby' replaced enable/disable to avoid confusion with the new API enable/disable features.
Tooltips don't get realigned automatically by OneBag. If you want to prevent tooltips from moving offscreen, try Tipster. http://curse-gaming.com/mod.php?addid=1814
I will work on overlapping issues and try to add options for layering OneBag. Getting it to work overtop the Auction House while still working well elsewhere has always been a problem, but new features of game patch 1.7 may help.
I don't know why SwitchFix isn't doing anything. I know that OneBag is registering itself correctly but the problem for me is that SwitchFix never fires. But then I've never noticed any scaling issues, so it may be that for some reason doesn't need to fire on my configuration.
Offline bank viewing is the only major feature I have planned to implement and I can't make any promises on the delivery. Just too many other priorities right now.
Now for everything I didn't address individually. I would ask that you read the description above once more for OneBag. OneBag was not made to be just another MyInventory or AIOI. It does exactly what it was written to do. As such, I will not be implementing features that let OneBag match the feature set of these other addons. If you want their functionality, here's what I suggest: use them. Please stop asking me to turn OneBag into what it is not when what you apparently want is already available in another addon.
Hi,
I'm using DAB (Discord Action Bars) for my interface setup and I'd like to ask if it is somehow possible to get OneBank to the frontmost layer (atm DAB is _always_ in front of OB and some UI elements hide parts of my OB inventory window)?
Hoping to see the remote bank view feature really soon :)
Regards, Highend
WickedKlown, the proper command is /obb standby (and use again to toggle on or off) not /obb disable
How do I get the config window up like the one I used to use for MyInventory?
How to I turn off the title, buttons, money and slots displays like I used to for MyInventory?
How do I tell it not to display the ammo pouch / quiver? (I have been using AIOI while MyInventory was not working.
How do I tell it to always stay open like MyInventory used to?
If I switch between windowed and fullscreen, OneBag slides off the right hand side of the screen.
How do I use ob but not obb?
If I try to do /obb standby, I get an error message (stack overflow).
I miss MyInventory...
First I like to thanks Turan's work they are great. And here is a couple of suggestions to make it even better:
1. Although OBB replace the bank but it can't offer me access to view my bank item wherever I want.
2. OB window is covered by Auction Window.
3. More customization would be great, things like "XXX's bag" "XX/50 Slot used" and how much gold I have should be able to hide.
4. I really don't see the point to show bag in bank while you have already combined them.
Overall this addon has great potional to be the real "ONE BAG TO RULL THEM ALL", but now MyInventory and MyBank combination > OneBag imo.
Not sure if this is related to OneBag or someone else but it seems as if the tooltips don't relocate properly based on how far you are from the edge of the screen, any solutions?
I tried downloading that addon and putting it in the addon folder, didnt work, I tried to add all the files with the OB folder, didn't work either. How do I make Switchfix work with this awesome addon?
Everytime I try to disable OBB by typing /obb disable I get OneBagBank Invalid option "disable" entered. Same thing happens when you try to enable them. Also have have the newest version installed.
Can you please add an option that would prevent the auction house window from overlapping the inventory. I'm finding it very frustrating to have to drag my inventory slightly offscreen to auction off stuff near the top corner of my bags.
Other than that, great addon, will never revert to pre onebag reguardless of this nuissiance.
Regarding the errors with commands, I haven't seen any errors myself, so download the new version and see what happens.
Regarding Bank bag slot purchase, I've addressed this before as well. It's likely an addon conflict, possibly from an addon trying to move the default bank or the popup itself. Only a few people have this problem and I haven't tracked it down specifically, so I still don't have a solution other than telling you to type /obb standby (replaces /obb disable and /obb enable) to turn OneBankBag off, purchase the slot, then /obb standby to turn OneBankBag back on.
As for bank viewing with BankStatement or any other addon, there's currently no support for that. I hope to add it eventually, but it requires some major reworking of OneBag and I haven't had time to complete it yet.
@dan2507: Thanks for the translations. I'll get them into my next version.
i did install newest bankitems from authors site before i installed onebag...still broke??