OneBag
NOTICE
<big>This version is no longer maintained! I'm working as fast as I can to get the new version to a better state but it does have base line functionality.
Check out the new true OneBag as it's being developed! </big>
END NOTICE
OneBag is a replacement for the default game bags that combines all the bags into one frame. There are already addons out there that do this, so why OneBag? Mainly because I wanted a simpler, more system-friendly bag. OneBag doesn't entirely rewrite the bag-handling interface like others do. It simply rearranges the bags into one and allows the default UI to continue managing the bag slots. This means that addons such as KC_Items, ItemSync, LootLink, and SellValue should be inherently supported. As long as an addon is compatible with the default game bags, it should work with OneBag. This was my goal, anyway. For my uses OneBag has succeeded. Hopefully you will have similar results.
Features
- Combines all your character bags into one.
- Customizable number of columns.
- Displays the total number of slots, by slots used and type. Types being that ammo, soul bags, and professions bags all get a seperate count.
- Inherent support for addons such as KC_Items, ItemSync, LootLink, and SellValue, with no need for special code.
- Color coded slots by item rarity or bag type.
- Will automatically open for you when you visit the auction house, bank, mailbox, merchant, or when entering a player trade.
- Customizable display of only certain bags, either but slot number, or by type.
- Gives you a bag bar for easy manipulation of your bags.
- You can mouseover the bags on the bar to highlight the slots from that bag. You can also lock this highlight by clicking.
- Customize the scale and alpha of the frame.
- Provides an easy to use graphical config menu.
Hello! :) First I must say that OneBag is a really nice Addon! I like it more than AIOI or MyBags because of its clear code.
I've just seen that today a new version of OneBag was released.
I downloaded it and replaced the old version 1.2b with 1.3 .
Now, every time I log into the game, an error message is displayed with following content: [string "Interface\AddOns\OneBag\OneBagCore.lua"]: 444: bad argument #1 to 'format' (string expected, got nil)
I'm using the german client-version but 1.2b worked fine for me.
This error popups every time I log into the game.
Greetings Kataris
I was wondering if you could have "sticky" bag slots that do the same thing as the "sticky" action slots that blizzard recently put it.
or if you want to take it furthur...have some sort of sort option not really needed and I think it would defeat the whole little memory process thing.
Yeah, I was always a big AIOI person too, then i switched to MyInventory for the flexability, then /gouges eyes out OneBag!
could you add the flexability of MI and the style of AIOI? I miss them :P
@Kayde: I'll answer your post in the AuctionIt forum.
@Georgezzz: Ah, I see what you mean now. I guess I don't see this as a big issue. Basically what you're pointing out is that when there's a short row, OneBag has the empty space on the bottom whereas AIOI puts it at the top. To me it felt more logical this way, since the stacking order of the slots matches the fill order.
---Georgezzz - what do you mean by AIOI item filtering? I've used it in the past, and I just went through and read the comments and description and changes files and see no mention of item filtering anywhere in it.
I used AIOI before and it ordered the items in my inventory in the other way then Onebag does now...
I'll try to make a picture of it:
ONEBAG:
| | | | |
| | | | |
| | |
AIOI:
| | |
| | | | |
| | | | |
I hope this explains it a bit...
--ZAPPED AWAY UNRELATED CONTENT--
BTW, I've given into the fact that perhaps something like moveanything is encumbering the bank purchase button (as I overlooked this before). I can live with it and simply disable when I want to buy a new slot, then switch it back on. The most that will happen in a toons life is 6 times. :)
Georgezzz - what do you mean by AIOI item filtering? I've used it in the past, and I just went through and read the comments and description and changes files and see no mention of item filtering anywhere in it.
Can you explain this feature?
-x
Well, Kronos, that's odd. It's still working fine for me without my previous fix. Nevertheless, the fix is easily reapplied and doesn't break anything, so I posted an updated file with my fix added back in. I also sent the WOWEcon folks a note so hopefully they'll get this added soon.
@Kayde: I still don't know what to tell you. I'm going to guess that maybe you have, or had, a MoveAnything type of addon installed that's trying to reposition that popup. Even if those addons are removed, the game might be remembering those settings. You might need to clear your layout cache.
I'll be sure to make the tooltip direction settable.
@Kronos: I tried the latest version and it looks like the problem with double price display is fixed. Try it and let me know. If the problem is still there, then I'll write to them and perhaps post a new version of my fix.
New problem: I removed anything that will interfere with the confirmation popup box. When I click the "Purchase Bag" option, I hear the click, but no confirmation box, and no bought bag. When I /obb disable, exit bank, and then reopen bank - the confimation dialog is there asking if I'm sure I want to buy it. If I /obb enable and try again, same situation, no popup.
I would also suggest that if you do, in fact, change the tooltips to display all one direction, make such a feature toggle-able for both directions. I keep my bank info on the left of the screen near its default location, and all tooltips would fly offscreen if you changed all to be shown only one way.
The job never ends eh?
@Moonsorrow: Okay, I'll make sure it works in the next version. Thanks.
@Georgezzz: Not yet. Unfortunately I just haven't had time to spend on my addons lately. Hopefully I can get some updates done this weekend.
@Kayde: *lol* That's too funny. I actually meant to mention Tipster here but forgot. The tooltip thing was mentioned before and my response was basically that I was going to put tooltip alignment code into a separate addon since there are many tooltips in the game that can benefit.
Here's why the goofiness in OneBag's tooltip alignment. As I say in the intro, OneBag allows the default UI mechanisms to manage item slots. What most bag mods do is write their own slot management and create their own tooltips. So they align all their tooltips in one direction. Well, since the UI continues to manage all this in OneBag, the UI is also setting tooltips. If you disable OBB, you'll notice that the main bankframe pops open on the left while all other bags pop open on the right. So the UI is setting tooltips based on it expecting the bank to be on the left and all other bags to the right.
I'm not sure what to do about this in OneBag. I won't add Tipster's alignment code because that's beyond OneBag's scope. However, it does make sense that all the bag tooltips should display in the same direction. What I will probably do is turn the main bank tooltips around so they match the other bags, meaning they'll open towards the left.
It was indeed. I can't explain WHY I still hadn't removed the addon for a confimation box when buying a bank bag yet, but I didn't. All fixed. You are STILL the man. :)
As if that was ever in question.
[edit] Question: I believe this was addressed once before, but all my bank bought bags tooltips are displaying to the left (and therfore running off screen), while my normal bank slots are displaying to the right. Wassup wit dat?
[edit2] ROFLMAO! I was going to suggest that you check out this "other" mod i saw once that keeps things from running off screen at http://www.curse-gaming.com/mod.php?addid=1814 , BUT YOU WROTE THAT ONE! You think you'll add that code here? Or should I just give into the madness and DL that addon too?
Isnt there an option to see the bank whne you arent there? Like Mybank does with a Keybinding.
BTW thx for trying to make AIOI ordering and that BankBag-Toggle
doesn't work, but found out why. the call order of the translation files in the xml file was wrong, so he always compared the german with the english text, this will fix it:
<script file="OneBagLocals_deDE.lua"/> <script file="OneBagLocals.lua"/>
Beside, I hope we will soon be able to look at our bank contents when you are not at the bank. The bank data is stored anyway, so it shouldn't be a big deal i hope.
Dooh, I figured it was there, guess I didn't want to see it. :)
@m0rgoth: Thanks. I'm glad you like it.
@Itanius: Thanks and you're welcome. :)
@smilyman: As m0rgoth said, you can just hit your default bag open key. Right now I don't have any other option but if you need to create a macro you can use OneBag:Open() and OneBankBag:Open(). I could add open and close options to the slash commands as well if there's a need for that.
@Mazzardah: Yes, it does get painful scanning a huge bag. As Pogel pointed out, there is Advanced Bags Plus. That's probably your best choice if you want that kind of thing anytime soon.
@Georgezzz: I'm not familiar with AIOI's ordering, so I'll have to take a look at it. As far as the bank bags staying on top of all slots, well, maybe I'll offer a toggle for that later, but it's certainly not a "fix." I chose to do it that way because it's my preference. I keep the bank on my characters between 12 and 16 slots wide depending on how many bags they each have. You see, I like to place my bank and character bags top to bottom not side to side. So for me, having those bag slots take up their own row is a nasty waste of space on my screen.
@Kayde: I have no explanation for that error. I would have to guess that if that problem repeats there's a problem beyond OneBag. PurchaseSlot is an API function. If it's nil, that means something destroyed it, possibly another addon.
@SaberHawke: There has always been a way to set scale and columns. You have two commands, /ob for the character bag and /obb for the bank bag. I have a list above detailing the command options available for them both.
Type /OBB and you get all settings ^^
I still have some suggestions:
-AIOI ordering (noted that before :p) -The bags that show in the window from OBB should ALWAYS be ontop off all slots... when I set cols to 8 the bags go beside the slots...
I realy hope this gets fixed because I am still using MyInventory And Mybank because of this :p
Is there a way to change the scale and numbers of cols on the bank display yet? I may have missed it.
[string "BBagFramPurchaseButton OnClick']:3:Attempt to call global 'PurchaseSlot' (a nil value)
When clicking the purchase bag option.
Only thing I want is the AIOI item ordering