This site works best with JavaScript enabled. Please enable JavaScript to get the best experience from this site.
What steps will reproduce the problem? 1. Remove all addons except for PitBull. 2. Mount up in the Argent Tournament and apply TWO stacks of "Defend". 3. Attack the beginner "Melee Target" one time. Note that your buff icon will show that Defend still has two stacks, but that the orbs around your character will correctly show just one stack. 4. Apply an additional stack of "Defend". Note that your buff icon will now show three stacks of "Defend" but that you only have two orbs.
What is the expected output? What do you see instead? I would expect that PitBull would not interfere with the default Blizzard buff icons.
What version of the product are you using? v3.2.10
Do you have an error log of what happened? No errors, just incorrect display.
Please provide any additional information below. The issue is that when you're in a vehicle your buffs are reported for your PET, not for the player. BuffFrame.lua (the Blizzard code) determines the unit on which to look for buffs by checking PlayerFrame.unit which is set in PlayerFrame.lua using the "UNIT_ENTERED_VEHICLE", "UNIT_ENTERING_VEHICLE", etc. events.
When PitBull disables PlayerFrame, this prevents BuffFrame from determining for which unit to display buffs, resulting in incorrect buffs and counts. If PitBull removes or disables PlayerFrame, it should implement behavior that allows the default BuffFrame to work correctly.
The relevant lines of code in the Blizzard UI are 198-223 and 272-333 in PlayerFrame.lua and 102-104 in BuffFrame.lua.
Hope this helps!
I had a thought about this, so I tried something... I added four RegisterEvent lines to PitBull_HideBlizzard:HideBlizzardPlayerFrame() in HideBlizzard.lua
function PitBull_HideBlizzard:HideBlizzardPlayerFrame() if not playerFrameState then return end playerFrameState = false PlayerFrame:UnregisterAllEvents() PlayerFrame:RegisterEvent("UNIT_ENTERED_VEHICLE"); PlayerFrame:RegisterEvent("UNIT_ENTERING_VEHICLE"); PlayerFrame:RegisterEvent("UNIT_EXITING_VEHICLE"); PlayerFrame:RegisterEvent("UNIT_EXITED_VEHICLE"); PlayerFrameHealthBar:UnregisterAllEvents() PlayerFrameManaBar:UnregisterAllEvents() PlayerFrame:Hide() end
This allows the PlayerFrame to continue monitoring vehicle status even when it is otherwise disabled, which allowed the BuffFrame to function normally. The Blizzard frame did not appear when entering or exiting a vehicle and in my (limited) testing I did not notice any problems with this work around.
Again, this fix only works when there are no other addons (such as ElkBuffBars) taking over the display of the buffs, but I have filed separate tickets about vehicle buffs for those addons.
I occasionally get an error in the visualheal module, which I haven't been able to reproduce predictably. On a cannon in Wintergrasp it said "addons\pitbull_visual_heal\visualheal.lua line 321: texcoord out of range". Googling a bit, http://forums.wowace.com/showthread.php?t=10369&page=26 has a post that said SetTexCoord had limits introduced in 3.1.0, and possibly changed in 3.1.1, with the values ranging from -10000 to 10000. Looking at that section of code in visualheal, I'm not sure what exactly would cause the amounts (heal to max-health ratio) to be out of that range, but maybe adding a range-check around the SetTexCoord call would help in case that is the problem.
(Update: Oops wrong area; i'll open a new ticket, but leave the comment here in case someone remembered seeing it here and is trying to find it again)
To post a comment, please login or register a new account.