PoisonSwapper
PoisonSwapper manages weapon swaps for maximum poison damage by automatically swapping in a weapon with instant or wound poison to your offhand when you have a 5 stack of Deadly Poison up with more than 5 seconds remaining. This allows you to use a damage poison, like Wound or Instant as is appropriate to your spec in order to achieve maximum throughput.
This can result in a 300 DPS gain for a BIS combat rogue, and a 600 DPS gain for a BIS Mutilate rogue.
To use it, just poison your primary offhand with Instant or Wound Poison as appropriate, and a secondary offhand with Deadly. Your Instant/Wound hand should have better uptime, so you generally want that weapon to be your better one, and your Deadly weapon should be fast, due to Deadly's flat 30% (before talents) proc rate. The mod does the rest and automatically swaps weapons for you. You can toggle it on and off with /ps, or by clicking the included LDB entry.
PoisonSwapper supports a PVP mode, as well, which will equip poisons with the priority: Crippling -> Mind Numbing (If caster target. This includes ret paladins and enhance shaman at the moment, unfortunately) -> Damage Poison. It is automatically enabled against PVP targets, and can be forced on (for something like faction champs) with /ps pvp. Do be aware that in a PVP environment, where poisons are often removed, this will cause you to be on the GCD a lot and might potentially be an overall strategic loss. Usage is left to the user's discretion.
- /ps boss - Toggle on boss-only. Boss-only will only use Deadly poison on boss mobs, damage poison on others. Default Off.
- /ps debug - Toggle debug mode. Can help identify why the addon may not be working. Default Off.
- /ps [pvp/pve/auto] - Force PvP, PvE, or Auto mode. Default is Auto.
- /ps toggle - Toggle PoisonSwapper on and off.
- /ps time <number> - Set the number of seconds at which to swap back to your primary poison. Default 5.
Finally, PoisonSwapper includes an intelligent swing estimator, and will attempt to only equip weapons immediately following a white mainhand swing. Changing weapons resets your swing timer on both hands, so swapping halfway through a mainhand swing timer is rather expensive. This causes PoisonSwapper to produce superior overall DPS compared to poison swapping macros or manual swapping.
will get rogues nerfed
(If you have Improved Poisons in a combat spec, it likely isn't optimal anyhow)
Read up on it a bit more and swapping uses a GCD so that's what the delay I was noticing. Also probably why it seems to lag to 3 sec before it swaps sometimes also. I probably envenomed and put it on GCD and it is waiting for it to end before it swaps.
A couple things:
The /ps does not disable the addon. It also keep stating "enabled" and even if you hit it, it will not disable so currently disabling the addon at the character screen is the only way to turn it off. Not sure what the included LDB entry is or where it's located.
The default time of 5 seconds might be a bit too close. I've edited the time to 6 seconds per the .lua file and it seems to be consistently keeping deadly up now. However, it seems to be swapping at weird times like at 3 seconds and not really 6 which is strange.
This is probably just a part of the swap but sometimes I try to envenom and it delays because it's swapping or there is some sort of delay. As a ruptureless assassination rogue this isn't as big of a deal but with a rupture rotation this might allow slice n dice to fall off.
Thanks again for making weapon swapping less clunky!
where in the lua did you change the switch time? I noticed dropping DP stacks on my tests too, but couldn't find the time variable.
Another question to the developer: you mentioned to use the PRIMARY OH as DP and secondary OH as Wound/IP Weapon. At least for Combat that doesnt seem right, since the primary weapon also in most cases is the better weapon and the Wound/IP weapon should have a higher uptame in fight than the DP weapon.
no delay
mutilate: makes the swap only with Instant on second OH
combat: make the swap only with Wound on second OH
and like Nightwatcher57 said there is no on-off - always displays "Enabled"
great addon !
/cheers
I've just noticed one thing :
The "on-off" command doesn't work. It's always on "Enabled"
Btw, great job. thank you.
As it is v0.1, I assume you were planning to already, but a Configurable time to swap (3s, 5s, etc) would be optimal. At the current 2 seconds, the swing timer reset will only allow for another swing or two, and sometimes that allows for Deadly Poison charges to drop off..Which diminishes the whole idea behind the poison swapping.
Awesome addon, though..Thank you very much for taking the time to make it =)
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\PoisonSwapper\PoisonSwapper.lua line 53:
attempt to index local 'poison' (a nil value)
Debug:
(tail call): ?
PoisonSwapper\PoisonSwapper.lua:53:
PoisonSwapper\PoisonSwapper.lua:52
(tail call): ?
PoisonSwapper\PoisonSwapper.lua:134: ExecuteSwap()
PoisonSwapper\PoisonSwapper.lua:244: ?()
...non\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:146:
...non\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:146
[string "safecall Dispatcher[1]"]:4:
[string "safecall Dispatcher[1]"]:4
[C]: ?
[string "safecall Dispatcher[1]"]:13: ?()
...non\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:91: Fire()
...ace\AddOns\Bagnon\libs\AceEvent-3.0\AceEvent-3.0.lua:120:
...ace\AddOns\Bagnon\libs\AceEvent-3.0\AceEvent-3.0.lua:119
[C]: TurnOrActionStop()
[string "TURNORACTION"]:4:
[string "TURNORACTION"]:1
AddOns:
Swatter, v5.6.4424 (KangaII)
Atlas, v1.15.1
AtlasBattlegrounds, v1.15.1
AtlasDungeonLocs, v1.15.1
AtlasOutdoorRaids, v1.15.1
AtlasTransportation, v1.15.1
AtlasLoot, vv5.08.06
AtlasLootFu, vv5.08.06
Babylonian, v5.1.DEV.130
Bagnon, v2.12.0
Carbonite, v3.22
ClassTimer, v2.3
Configator, v5.1.DEV.190
DBMCore, v
DBMOnyxia, v
DebugLib, v5.1.DEV.130
Informant, v5.6.4424 (KangaII)
NugComboBar, v
Omen, v3.0.8
PoisonSwapper, v0.1
Recount, v
Stubby, v5.6.4424 (KangaII)
Titan, v4.3.0.30200 - Revision 316
TitanBag, v4.3.0.30200
TitanClock, v4.3.0.30200
TitanCoords, v4.3.0.30200
TitanGoldTracker, v4.3.0.30200
TitanLootType, v4.3.0.30200
TitanPerformance, v4.3.0.30200
TitanRegen, v4.3.0.30200
TitanRepair, v4.3.0.30200
TitanXP, v4.3.0.30200
TrickOrTreat, v
XPerl, v3.0.6
XPerlArcaneBar, v
XPerlCustomHighlight, v
XPerlParty, v
XPerlPartyPet, v
XPerlPlayer, v
XPerlPlayerBuffs, v
XPerlPlayerPet, v
XPerlRaidAdmin, v
XPerlRaidFrames, v
XPerlRaidHelper, v
XPerlRaidMonitor, v
XPerlRaidPets, v
XPerlTarget, v
XPerlTargetTarget, v
BlizRuntimeLib_enUS v3.2.2.30200 <us>
(ck=484)
I got that when I tried to use the addon. Didn't work at all. Hope that helps though!