Valuation v1.4.3 - Gives Lua Error #1


  • New
  • Defect
Open
Assigned to _ForgeUser1097915
  • _ForgeUser39481 created this issue Oct 17, 2008

    What steps will reproduce the problem?
    1. Gives error whan you start wow

    What is the expected output? What do you see instead?
    It still lists item values in the tooltip but then throws more errors (not listed here)

    What version of the product are you using?
    v1.4.3

    Do you have an error log of what happened?

    [2008/10/17 22:12:36-2880-x1]: Valuation\ValuationUI.lua:12: hooksecurefunc(): SetCraftItem is not a function
    Valuation\ValuationUI.lua:12: in function `ValuationUI_Hook'
    Valuation\ValuationUI.lua:113: in main chunk

      ---

    Please provide any additional information below.

  • _ForgeUser39481 added the tags New Defect Oct 17, 2008
  • _ForgeUser1191215 posted a comment Oct 27, 2008

    Here's a patch:

    <<code>>- Valuation-old/Styles/Blizzard.lua 2007-11-27 11:40:12.000000000 +0000 + Valuation/Styles/Blizzard.lua 2008-10-18 14:14:55.000000000 +0000 @@ -14,12 +14,7 @@ if (not tmp_tt[frame]) then tmp_tt[frame] = CreateFrame("Frame", "ValuationTooltip_" .. frame:GetName(), frame, "SmallMoneyFrameTemplate");

    - local tmp = this; - this = tmp_tt[frame]; - - MoneyFrame_SetType("STATIC"); - - this = tmp; + MoneyFrame_SetType(tmp_tt[frame], "STATIC"); end

    if (price == 0) then<</code>>

    <<code>>- Valuation-old/ValuationUI.lua 2007-11-27 11:40:12.000000000 +0000 + Valuation/ValuationUI.lua 2008-10-26 11:31:03.000000000 +0000 @@ -110,14 +110,6 @@ return GetTradeSkillItemLink(craft), GetTradeSkillNumMade(craft), nil; end);

    -ValuationUI_Hook(GameTooltip, "SetCraftItem", function (...) - return GetCraftReagentItemLink(...), select(3, GetCraftReagentInfo(...)), nil; -end); - -ValuationUI_Hook(GameTooltip, "SetCraftSpell", function (...) - return GetCraftItemLink(...), 1; -end); - ValuationUI_Hook(GameTooltip, "SetSocketGem", function (...) return GetNewSocketLink(...), 1; end);<</code>>

    It basically means that you should open up the file mentioned, remove all lines prefixed with a "-" and add the lines prefixed with a "+".


To post a comment, please login or register a new account.