Archeology Attempts call returns bad data #295


Closed
  • arbelac created this issue Jul 18, 2018

    Pulling this out from the other issue (294):

     

    Scepter of Azj'Alqir tracking is returning 2762568466 for attempts.

     

     

    The in game Arch UI is showing 3 "slots" for races, but not their names yet. I wonder if this is breaking the call to get the Arch data?

  • RDW posted a comment Jul 19, 2018

    Yes, this is actually very likely to change the API return values, which might mess up some things. GetNumArchaeologyRaces() is being used by Rarity, as well as GetActiveArtifactByRace()...  I'll look into it after the other issues are dealt with.

     

    Edit: This is just on a quick glance. I've not worked with said APIs so it could easily be something else.


    Edited Jul 19, 2018
  • RDW posted a comment Jul 20, 2018

    Okay, this was surprisingly easy. There are two new races, Drust and Zandalari, which have been assigned the IDs 1 and 2 (but... why? Sigh). Therefore, all race IDs are shifted by two, which affected both the Fossilized Raptor (now interpreted as a Nerubian rare and not a Fossil one), and the scepter (Vrykul instead of Tol'vir).

     

    I can't really test the correctness of my assumptions, as I already have both mounts, but this should be resolved in the latest alpha. Please confirm so this can be closed! :)

  • Forge_User_94403818 posted a comment Jul 20, 2018

    The Scepter was strange long before the patch, mine showed thousands of attemts all along Legion and I definitely don't even have 10 attempts...

     

  • RDW posted a comment Jul 20, 2018

    Are new attempts being counted correctly? If the data is corrupt you could just delete it. If the count doesn't increase properly, I'll have to take another look.

  • arbelac posted a comment Jul 20, 2018

    Something is still wrong with this.

     

    I grabbed the latest alpha and installed it, the count was still the previous value.

     

    So I wiped the Rarity.lua and backup from the WTF folder and tried it again; it's got a new value that is still massively incorrect:

     

    ["Scepter of Azj'Aqir"] = {["Scepter of Azj'Aqir"] = { ["attempts"] = 13158921003, },

     

    The count of attempts is being calculated incorrectly somehow.

  • RDW posted a comment Jul 20, 2018

    Indeed it appears the archaeology API has changed in yet another place; a minor change, but easy to miss. It's probably been that way in Legion already.

     

    r659 should fix the miscalculation, though you may have to reset the attempts first.

  • arbelac posted a comment Jul 20, 2018

    Just grabbed it, cleared the data and it shows the correct count now. This looks like it's fixed.

     

    Thanks!

  • RDW closed issue Jul 20, 2018
  • RDW posted a comment Jul 20, 2018

    Very good! One less thing to worry about. Thanks for making me aware of the problem, I would never have noticed on my own.

  • Dahustler1337 posted a comment Jul 22, 2018

    can confirm the fix.

    Go into Rarity Options/Mounts/Scepter of AzjAqir. Set attempts to 0, press the Okay button next to the number 0 and bam it goes to 69 attempts for me instead of 1324324234 attempts.

  • RDW posted a comment Jul 26, 2018

    Closing this as resolved, then.

     

    The manual reset thing isn't ideal, but unless I get many more reports of invalid counts I'm putting off implementing an automatic reset just for this.


To post a comment, please login or register a new account.