post patch issues #439


Closed
  • sidartha_star created this issue Oct 22, 2020

    If you're reporting a problem, please ALWAYS include the following information or I won't be able to help you!  (Suggestions or feature requests need not use this template)

    • Addon version: r700
    • Did you RESTART the game after updating the addon? yes
    • Steps to reproduce the error or unwanted behavior: No error. No steps other than using normally.
    • Any other information you consider relevant or helpful in solving the problem: NA

     Thank you for understanding! It's not always easy to troubleshoot problems. Please don't make it more difficult by disregarding these suggestions.

    After the r700 patch the addon is now working for me but it's not working optimally I don't think.

     

    -First of all it is causing massive if temporary lag. My FPS drops like 30+ FPS when bringing it up. It does tend to stabilize after that. I'm new to this addon so not sure if that's always been the case. 

     

    -The interface is also very flaky. I click the mini-map button to bring up the item list and it appears and then randomly disappears and reappears constantly. It's quite irritating to try and navigate through the list because of this. Is there a way to bring up a permanent window that you can move around?

     

    -I also tried using the "cntrl click" to change the sort order but that doesn't appear to do anything.

     

    -The list seems to be very incomplete. I don't see either of the mounts from "Return to Karazhan" listed at all. I assume there is an item pack that I need to import but the only one listed on here is for illusions and when I searched for more I didn't find any. Maybe this is just me not knowing where to find it or not understanding how the addon works. Is there a way to manually add your own items somehow?

  • RDW posted a comment Oct 22, 2020

     

    Hello! In the future, please create a separate issue for each problem to make it more manageable :)

     

    1. The lag is presumably the same issue that's been reported by others, though it only appears to affect some users. Unfortunately it's not something I can easily improve due to how the addon's UI was written (by the original author, not me). It's on the list of things to fix, but said list is very long and my time very limited. GitHub status: https://github.com/SacredDuckwhale/Rarity/issues/106

     

    2. That's also a, uhm, feature of the tooltip library I think. The window is hidden when you no longer mouse over it, which is less than ideal but (similarly to 1.) can't easily be rectified without reworking the entire UI.

     

    3. This has been reported before, but it's working for me so I'll need more information (like, are there any errors? Etc).

     

    4. There aren't any other item packs AFAIK, no idea what the idea was with having them TBH. Most collectibles should be part of the addon's database, though Return to Karazhan only has two mounts as far as I know. Midnight is definitely in the database and should show up, while Nightbane's mount wasn't added due to being a mostly-guaranteed drop (I think). I've had another request to add it recently, so I created this issue https://github.com/SacredDuckwhale/Rarity/issues/202 - I simply haven't gotten around to doing anything other than fix prepatch-related problems so far.

  • RDW posted a comment Oct 22, 2020

     

    Oh, and you can add your own items under the "Custom" tab.

  • sidartha_star posted a comment Oct 25, 2020

    Awesome. Thanks for the updates and sorry for putting them all in one post.

     

    On #3 there is no error it just doesn't do anything.

     

    On #4 with regard to Nightbane it's not guaranteed but I think it's like a 20% drop rate which is better than most. I'm also pretty sure Midnight is not listed. If you look down the list of zones there isn't even any entry for Return to Kara. I'm not 100% but I don't think the mount from legacy Kara is there, either.

     

    How do you add your own items? Just entering the item# or something?

  • RDW posted a comment Oct 26, 2020

    You may have to enable script errors if you haven't already for them to show up: https://www.curseforge.com/wow/addons/rarity/pages/faq/how-to-enable-and-disable-script-errors-lua-errors

     

    I'm 100% certain both Midnight mounts are tracked. You may have them disabled in your settings, perhaps? Nightbane isn't currently being tracked, but will be soon (as soon as I have time to test it).

     

    You can go to the Custom tab in the options menu. This is where custom items are added, by looking up the relevant data (item ID etc) from wowhead.

  • clancyby posted a comment Oct 26, 2020

    Put your spoiler here.

    13:19:58] Rarity: UpdateText: 0.080200ms
    [13:19:58] Rarity: UpdateText: 0.074300ms
    [13:19:58] Rarity: UpdateText: 0.093900ms
    [13:19:58] Rarity: UpdateText: 0.089900ms
    [13:19:58] Rarity: Initialization failed to retrieve 362 item(s)
    [13:19:58] Rarity: UpdateText: 0.060200ms
    [13:20:03] Rarity: Loading 362 item(s) from server...
    [13:20:03] Rarity: UpdateText: 0.080700ms
    [13:20:04] Rarity: UpdateText: 0.103000ms

     

    [13:21:23] Rarity: Проверка ввода: Reins of the Drake of the Four Winds ...
    [13:21:23] Rarity: Проверка ввода: Tundra Icehoof ...
    [13:21:23] Rarity: Проверка ввода: Reins of the Blazing Drake ...
    [13:21:23] Rarity: Проверка ввода: Mail Muncher ...
    [13:21:23] Rarity: Проверка не удалась с 7 ошибками!(Verification failed with 7 errors!)

     

    [13:22:58] Rarity: BuildStatistics: 0.225000ms
    [13:22:58] Rarity: ScanStatistics: 4.099500ms
    [13:22:58] Rarity: Scanning toys (FINAL INIT)
    [13:22:58] Rarity: Toys took 0.639800ms
    [13:22:58] Rarity: Scanning transmog (FINAL INIT)
    [13:22:58] Rarity: Transmog took 0.563000ms
    [13:22:58] Rarity: Scanning calendar (FINAL INIT)
    [13:22:58] Rarity: Calendar took 0.069300ms
    [13:22:58] Rarity: Scanning instance locks (FINAL INIT)
    [13:22:58] Rarity: Instances took 1.918300ms
    [13:22:58] Rarity: ScanExistingItems: Total time 625.705200ms

    [13:24:29] Rarity: Initialization failed to retrieve 860 item(s)
    [13:24:29] Rarity: UpdateText: 0.081200ms
    [13:24:34] Rarity: Loading 860 item(s) from server...
    [13:24:34] Rarity: UpdateText: 0.083400ms
    [13:24:34] Rarity: UpdateText: 0.073000ms
    [13:24:34] Rarity: UpdateText: 0.073300ms
    [13:24:34] Rarity: UpdateText: 0.092300ms
    [13:24:34] Rarity: UpdateText: 0.093500ms
    [13:24:34] Rarity: Mouse hovered over NPC with id = 77370
    [13:24:34] Rarity: UpdateText: 0.095200ms

     

    [16:13:31] Rarity: Calendar took 0.074900ms
    [16:13:31] Rarity: Scanning instance locks (FINAL INIT)
    [16:13:31] Rarity: Instances took 0.137800ms
    [16:13:31] Rarity: ScanExistingItems: Total time 609.024800ms
    [16:13:31] Rarity: UpdateText: 0.077300ms
    [16:13:31] Rarity: BuildStatistics: 0.181900ms
    [16:13:31] Rarity: ScanStatistics: 3.722900ms
    [16:13:33] Мастер осады Черноплавс кричит: Давай, Шанна. Твой выход.
    [16:13:34] Rarity: BuildStatistics: 0.195700ms
    [16:13:34] Rarity: ScanStatistics: 3.775300ms
    [16:13:36] Rarity: Mouse hovered over NPC with id = 73091
    [16:13:36] Rarity: Mouse hovered over NPC with id = 72964

     Also faced with a drop in FPS, after looting the boss in a raid / dungeon. I mean strong drops 30+fps, I know about microfreeze when entering the world. I wanted to write a ticket. I went to the alt. character, turned on debug and profiling, but the drops did not appear. Installed now (r701-alpha), but the problem appeared after the pre-patch.
    I decided to verify the database, but got an error (Rarity: Проверка не удалась с 7 ошибками!(Verification failed with 7 errors!)). How much can this affect the work of the addon?
    It would be nice to do import / export attempts of the main base.

  • RDW posted a comment Oct 27, 2020

    In order to troubleshoot performance issues, I'll need a debug log (including profiling data) and ideally you should run only Rarity/BugGrabber to exclude the possibility of other addons causing the reported problem.

     

    The database verification has no bearing on performance; it merely checks if all entries contain the expected data fields. Invalid entries can theoretically cause errors, but not normally FPS drops. It's mostly a preventative measure used to uncover outdated entries, and nothing critical to the functioning of the addon :)

     

    It would be nice to do import / export attempts of the main base.

    Unfortunately I don't quite understand what this means.

  • RDW posted a comment Dec 16, 2020

     

     

  • RDW closed issue Dec 16, 2020

To post a comment, please login or register a new account.