Skyshard tracking keeps enabling itself #504


  • Defect
Open
  • Hollo6 created this issue Apr 12, 2023
    • Addon version r719
    • Did you RESTART the game after updating the addon? Yes
      • Steps to reproduce the error or unwanted behaviour
         1. Untrack Skyshard (untick "Track this") in "Toys & Items" as suggested in https://www.curseforge.com/wow/addons/rarity/issues/503
         2. Some time later (not immediately and not after a simple relog) the item is being tracked again ("Track this" is ticked without me touching it)

     <Your text here>

  • Hollo6 added a tag Defect Apr 12, 2023
  • Hollo6 edited description Apr 12, 2023
  • RDW posted a comment Apr 12, 2023

     

    Assuming you've unchecked "Repeatable", it sounds like the WOW client didn't save your settings properly. If that was the case, your attempt counts should also fail to update however (which i assume you would've noticed long before this problem).

     

    It could be that you've set file permissions on the WTF folder/saved variables to "read only" or that the game didn't exit cleanly, e.g. Alt+F4/crash?

     

    Otherwise, I'll need a more specific (reproducible) way of causing the problem to manifest.

  • Hollo6 posted a comment Apr 13, 2023

    I didn't uncheck "Repeatable", thought disabling "Track this" would make it not track.

     

    Read permissions are OK and I haven't had a crash in months so that's not it, also I've been tracking this for some days when I last had this issue, and also now since reporting the problem, the "Track this" haven't enabled itself yet.

     

    Should I also untick "Repeatable" for disabling "Track this" to stick?

  • RDW posted a comment Apr 14, 2023

     

     

    "Repeatable" means that Rarity will keep tracking the item after you've obtained one. So I guess it might be that you looted a Skyshard, but since it was set to repeatedly track them the "Track this" setting was automatically enabled again?

     

    I can only guess here, but if you don't want to track the item just disable both to be sure :)


    Edited Apr 14, 2023
  • Hollo6 posted a comment Apr 15, 2023

    Alright, I've disabled "Repeatable" now as well.

    Will report back next week or after, that's usually how often this used to happen.


    Edited Apr 15, 2023
  • Hollo6 posted a comment Apr 26, 2023

    Well, it didn't work.

    Now both "Track this" and "Repeatable" stayed unticked, and looting a Skyshard still triggered the alert.

    Now I've also unticked "Announce" but even then, it wouldn't make sense to fire the alert if something is not tracked.


    Edited Apr 26, 2023
  • RDW posted a comment Apr 27, 2023

     

    That doesn't sound right to me, but without a debug log and the exact settings you've been using I don't know how I can help.

  • Hollo6 posted a comment Apr 28, 2023

    I'm happy to provide any logs if you tell me how to get them. :) And which settings you need.


    Edited Apr 28, 2023
  • RDW posted a comment Apr 28, 2023

     

    That would be the settings for Skyshard, and a log that shows the output while you are looting a Skyshard (when it is triggering the alert despite alerts being turned off). You can enable this via `/rarity debug` or the debug mode checkbox in the options menu.

  • Hollo6 posted a comment Jul 2, 2023

    Today I finally looted a Skyshard again, and this time it didn't trigger the alert. Of course today I forgot to enable debug mode, but it seems that unticking "Announce" was the thing that solved it. But I still think this is not right, if "Track this" and "Repeatable" are both disabled, Announce should not have an effect.

  • RDW posted a comment Jul 2, 2023

     

    Maybe it would be easier to reproduce this with a different (custom) item? If you add a standard cloth or other common item with the same tracking and notification settings, and the problem still occurs, then it might be possible to find out what's wrong via the debug log or manual testing.

  • Hollo6 posted a comment Jul 11, 2023

    So I did some testing with a common item as you suggested, and after finding the first one, a new checkbox "Found" has appeared.

    Not just for this new entry but Skyshard as well. I have never seen this checkbox before so now the question is why it has only appeared after creating a new custom item tracking.

    (The way it works matches my expectation btw, if the "Found" checkbox is ticked, there is no announcement. Yet to see it work with Skyshard but so far the custom item works the same way.)


    Edited Jul 11, 2023
  • Hollo6 posted a comment Jul 11, 2023

    And after being AFK for like ~20 minutes, the "Found" checkbox just disappeared from everywhere.

    I didn't log out, haven't even touched the PC for some time and it's just now gone.

  • RDW posted a comment Jul 11, 2023

     

    This sounds like UI taint, which can cause bugs in your UI.  I would recommend checking for script errors and possibly investigating the taint log.

     

    For details, see these links:

     

    * https://web.archive.org/web/20210518120056/https://www.townlong-yak.com/taint.log/about.html

    * https://wowpedia.fandom.com/wiki/Secure_Execution_and_Tainting

    * https://www.wowace.com/projects/rarity/pages/faq/how-to-enable-and-disable-script-errors-lua-errors

     

    Also make sure to test with all other addons disabled, since they may interfere with Rarity or Blizzard's UI.

  • Hollo6 posted a comment Jul 13, 2023

    I didn't have any LUA errors when testing this earlier.

     

    I just checked with every other addon disabled and the "Found" checkbox is not there on any of the items.


    Edited Jul 13, 2023
  • RDW posted a comment Jul 13, 2023

     

    If it's a taint issue you should find something in the taint log. See the first link above for how to enable the log and check its contents.

  • Hollo6 posted a comment Aug 11, 2023

    I have enabled taintlog level 2, had only Rarity enabled.

    The "Found" checkbox doesn't appear and the taint log is empty.

  • Hollo6 posted a comment Aug 11, 2023

    Addendum: while in the game and reloading, there was nothing in the taint log but after logging out, it contained this:

     

    8/11 10:32:12.706 Global variable LibStub tainted by Rarity - Interface/AddOns/Rarity/Libs/LibStub/LibStub.lua:8
    8/11 10:32:12.706 Global variable AceGUIEditBoxInsertLink tainted by Rarity - Interface/AddOns/Rarity/Libs/AceGUI-3.0/widgets/AceGUIWidget-EditBox.lua:25
    8/11 10:32:12.706 Global variable AceGUIMultiLineEditBoxInsertLink tainted by Rarity - Interface/AddOns/Rarity/Libs/AceGUI-3.0/widgets/AceGUIWidget-MultiLineEditBox.lua:22
    8/11 10:32:12.722 Global variable SLASH_LibQTip1 tainted by Rarity - Interface/AddOns/Rarity/Libs/LibQTip-1.0/LibQTip-1.0.lua:1563
    8/11 10:32:12.837 Global variable AceGUIWidgetLSMlists tainted by Rarity - Interface/AddOns/Rarity/Libs/AceGUI-3.0-SharedMediaWidgets/prototypes.lua:20
    8/11 10:32:12.918 Execution tainted by Rarity while reading LibStub - Interface/AddOns/Rarity/Locales.lua:1996
    8/11 10:32:12.918 Global variable Rarity tainted by Rarity - Interface/AddOns/Rarity/Core/Init.lua:15
    8/11 10:32:14.547 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:14.547 Interface/AddOns/Rarity/Core.lua:183 DoEnable()
    8/11 10:32:14.547 Interface/AddOns/Rarity/Core.lua:150
    8/11 10:32:14.547 xpcall()
    8/11 10:32:14.547 Interface/AddOns/Rarity/Libs/AceAddon-3.0/AceAddon-3.0.lua:66 safecall()
    8/11 10:32:14.547 Interface/AddOns/Rarity/Libs/AceAddon-3.0/AceAddon-3.0.lua:523 EnableAddon()
    8/11 10:32:14.547 Interface/AddOns/Rarity/Libs/AceAddon-3.0/AceAddon-3.0.lua:626
    8/11 10:32:14.837 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:14.837 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:14.837 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:14.937 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:14.937 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:14.937 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:15.037 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:15.037 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:15.037 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:15.137 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:15.137 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:15.137 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:15.237 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:15.237 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:15.237 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:15.337 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:15.337 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:15.337 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:15.437 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:15.437 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:15.437 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:15.537 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:15.537 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:15.537 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:15.637 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:15.637 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:15.637 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:15.738 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:15.738 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:15.738 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:15.838 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:15.838 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:15.838 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:15.937 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:15.937 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:15.937 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:16.040 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:16.040 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:16.040 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:16.108 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:16.108 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:16.108 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:16.205 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:16.205 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:16.205 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:16.305 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:16.305 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:16.305 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:16.408 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:16.408 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:16.408 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:16.504 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:16.504 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:16.504 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:16.618 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:16.618 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:16.618 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:16.713 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:16.713 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:16.713 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:16.807 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:16.807 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:16.807 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:16.918 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:16.918 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:16.918 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:17.014 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:17.014 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:17.014 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:17.114 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:17.114 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:17.114 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57
    8/11 10:32:17.211 Execution tainted by Rarity while reading Rarity - Interface/AddOns/Rarity/Core/GUI/DataBrokerDisplay.lua:152 UpdateText()
    8/11 10:32:17.211 Interface/AddOns/Rarity/Core.lua:402 func()
    8/11 10:32:17.211 Interface/AddOns/Rarity/Libs/AceTimer-3.0/AceTimer-3.0.lua:57

  • RDW posted a comment Aug 11, 2023

     

     

    Unfortunately, none of that explains why the checkbox would be hidden. Without a reliable way of reproducing the problem, I can't do anything.


    Edited Aug 11, 2023
  • Hollo6 posted a comment Aug 14, 2023

    I can reproduce this 100% of the time, wouldn't that be enough?

  • RDW posted a comment Aug 14, 2023

     

     

    No, unless you're the one who is doing the debugging ;) It's not clear if the problem is caused by Rarity, some 3rd party library, or Blizzard's UI.

     

    When I say "reproducible" I mean that I have to be able to reproduce it. If I can't, then I don't know how I should identify (let alone fix) the problem.


    Edited Aug 14, 2023

To post a comment, please login or register a new account.