Item Tooltip not respecting "Tooltip Additions" Option Checkbox #540

Open
  • View thomaseak's Profile
    thomaseak created this issue Aug 25, 2024

    If you're reporting a problem, please ALWAYS include the following information or I won't be able to help you!  (Suggestions or feature requests need not use this template)

    • Addon version (Example: r664-alpha)
    • Did you RESTART the game after updating the addon? (Make sure to exit and close fully the client, and not just reload your UI, to detect newly-added files)
    • Steps to reproduce the error or unwanted behaviour (If the addon won't load, make sure to enable script errors!)
    • Any other information you consider relevant or helpful in solving the problem (Screenshots, expected behaviour, things you already tried to fix the issue...)

     Thank you for understanding! It's not always easy to troubleshoot problems. Please don't make it more difficult by disregarding these suggestions.

    I don't know if it's intended or not, but container items in the world don't respect the option to disable tooltip additions, only unit tooltips do. I messed around and fixed in my local LUA by adding this:


    if (R.db.profile.enableTooltipAdditions == false) then

        return

    end

     

    to the beginning of the function:

    local function onTooltipSetItem(tooltip, tooltipData)

     

    in Core/GUI/GameTooltipHooks.lua

     

     

    There might be a more correct way (or it could be intended behavior, at which I'd request a separate option to toggle it), but this hack seems to fix it temporarily.

  • View RDW's Profile
    RDW posted a comment Aug 25, 2024

    Thanks for the report! The tooltip registration code was recently revamped due to a change on Blizzard's end, so I suspect this was simply missed.

     

    Status: https://github.com/WowRarity/Rarity/issues/754

     

To post a comment, please login or register a new account.