WowAce

What steps will reproduce the problem?
1. Enter a dungeon via the dungeon finder.
2. Check the VuhDo tooltip for role icons.

What is the expected output? What do you see instead?
No role icons are shown.

What version of the product are you using?
2.9

Do you have an error log of what happened?
-

Please provide any additional information below.
The VuhDo tooltip shows role icons in raids, just not in groups. But since the default tooltip also shows role icons in groups, the VuhDo tooltip should show them too.

It works fine in my testing, although I think I know where your confusion is coming from. RoleIcons (and it's tooltip support) displays the BLIZZARD role assignments. When there is no role assignment (eg if you just form a party in Stormwind), it does not display a role.

By default Vuhdo shows role icons on the party frames even when NO blizzard role has been assigned - it will guess a role (which may be wrong) and stick it on there, but the blizzard role remains unassigned. In this case the RoleIcons tooltip will continue to show no role, since none hasbeen assigned. Run a role check to assign roles and it will all show up correctly.

LFG and LFR automatically assign roles, and the vuhdo tooltip correctly shows that role for me.

Nope, no confusion on my side here. I did mean the automatic Blizzard roles from LFD. These are NOT shown on my VuhDo tooltips but ARE shown on the default tooltips. I'm not talking about any unit frames here, just tooltips. But the problem happens only in LFD, LFR shows them correctly.

Since it's working for you there must be something different in our setups. I'm using a deDE client if that maybe somehow matters.

Here are my saved variables:

RoleIconsDB = {
	["debug"] = false,
	["tooltip"] = true,
	["chat"] = false,
	["autorole"] = true,
	["focus"] = false,
	["target"] = false,
	["raid"] = true,
	["classbuttons"] = true,
	["rolebuttons"] = true,
}

Is there anything I could try or debug? Would it print anything useful if I set debug to true in the saved variables?

Ok, I don't know why, but it worked once today. It was a completely random LFD group (like always) and the role icons were shown in the VuhDo tooltip.

I then reloaded the UI and did a second LFD dungeon. The icons were missing again.

Only the tooltip option is required, and I doubt debugging will print anything useful in this case.

Like I said it works fine for me in LFD, so something is different about our setups that I'm not able to reproduce,

I suspect the difference is the formatting of your tooltip, and specifically the formatting on the server name of cross-realm players.

Please reply with:
1. a high-quality screenshot of the tooltip not working (so i can read the full name)
2. the full name and server name of the player target
3. a screen shot of any vuhdo settings screen which you've changed from the defaults.

1. I've uploaded two screenshots. One shows the VuhDo tooltip (without role icon) and one the default tooltip of the same player (with role icon).

2. As you can see in the screenshots, I didn't have any target at that time. If you meant the name of the mouseover unit, it's Dstü with server name Lothar. Note: The other players in the group didn't show role icons too, so I assume the german umlaut (ü) isn't the problem.

3. Since I've changed many settings in VuhDo, I've uploaded my saved variables file here. I'm using the profile named "Standard".

If you need anything else or need something tested, please ask.

I committed a possible fix as r70 - please give it a try and let me know if that fixes the problem.

Still not working, the if block you added is never entered.

But I found the real bug: You need to call RegisterHooks() on ADDON_LOADED of VuhDo. Currently VUHDO_updateTooltip is still nil when RegisterHooks() is called because VuhDo isn't loaded yet. This also explains why it did work while or after I was in a raid since RegisterHooks() is called on load of Blizzard_RaidUI.

Good catch - should be fixed in r71

Fixed, thanks. But isn't calling it for all Addons a bit overkill? ;-)