#448 Req: Data feed - Combat Indicator - Issues - Skada Damage Meter - Addons - Projects

Req: Data feed - Combat Indicator #448

New
Enhancment

Open

Assigned to

zarnivoop

Forge_User_36497828 created this issue Mar 8, 2016

Hi there, maybe you can add a Databroker feed that show for example "In Combat" and "Out of Combat" besides Personal DPS, Raid DPS and Personal Thread? Or maybe also you can add Combat Time as an extra feed?

i've done this by myself until you can integrate it by changed "Skada.lua at line 1892" from:

if selectedfeed ~= nil then
	local feedtext = selectedfeed()
	if feedtext then
		dataobj.text = feedtext
	end
end

to this:

if selectedfeed ~= nil then
	local feedtext = selectedfeed()
	if feedtext then
		dataobj.text = feedtext
	end
else
	if InCombatLockdown() then
		dataobj.text = "In Combat";
	else
		dataobj.text = "Out of Combat";
	end
end

but this isn't really clean, thanks ;)

Forge_User_36497828 added the tags New Enhancment Mar 8, 2016

Forge_User_36497828 posted a comment Mar 9, 2016

hi again, seems InCombatLockdown() does not fire on every PLAYER_REGEN_ENABLED and PLAYER_REGEN_DISABLED as described :/

So i added an extra Frame for Register a Event in "Skada.lua at line 13":

local InCombatFrame = CreateFrame("Frame")
local InCombat
InCombatFrame:RegisterEvent("PLAYER_REGEN_ENABLED")
InCombatFrame:RegisterEvent("PLAYER_REGEN_DISABLED")
InCombatFrame:SetScript("OnEvent", function(self, event, ...)
    InCombat = (event=="PLAYER_REGEN_DISABLED")
end)

and also edited the posted sugestion code to:

if selectedfeed ~= nil then
	local feedtext = selectedfeed()
	if feedtext then
		dataobj.text = feedtext
	end
else
	if InCombat then
		dataobj.text = "In Combat"
	else
		dataobj.text = "Out of Combat"
	end
end

To post a comment, please login or register a new account.