WowAce

What steps will reproduce the problem?
1. Get into combat (as a holy paladin)
2. Heal someone damaged with Light of the Martyr
3. Skada wouldn't take into account the minus healing caused on the casting paladin in the calculation of the healing done.

What is the expected output? What do you see instead?
To have the damage caused by Light of the Martyr to be deducted from the healing done by it, to get the true net result of the spell. At the moment it only takes into account the healing it does (at least in the healing calculation).

What version of the product are you using?
r632

Thanks

pls add Light of the Martyr to Holy pala!

Honestly, having just looked at the spell description, I'm not sure this is fair. I don't know how other meters handles it, but to me it looks like it has two components:

1 healing done on the target 1 damage taken on the source

In my opinion the second component does not have a place in Healing Done.

Similar to tanks with Damage Taken. Some tanks take more damage by way of class design. They also then show up on Healing Done. But Damage Taken is not adjusted to account for the healing they do.

Honestly, having just looked at the spell description, I'm not sure this is fair.

Light of the Martyr does 50% of the healing done as damage to the caster. So it's only 50% as effective as the healing done. The damage taken still has to be healed (or absorbed which is considered a heal in the healing meter) and is bonus damage on top of what the fight and its mechanics do. Not taking this into account in the healing done gives below average players the illusion that healing with LotM is good and when they're ranking high on Skada they must be doing well.

I don't know how other meters handles it,

In-game meters currently all fail at showing it properly. However Warcraft Logs does show it properly (and adjust HPS for it):

https://www.warcraftlogs.com/reports/pJcKMQA4YXhL3G7m#fight=9&type=healing&source=11

Still one might argue it should also be displayed in damage taken as you're increasing your damage intake putting more strain at healers to heal you and increasing the risk of you dying, but there are also good reasons not to show it in damage taken (e.g. it might give the wrong idea that someone is taking more avoidable damage than is true) so I'll leave it at that for now.

but to me it looks like it has two components:

 

 

1 healing done on the target 1 damage taken on the source

In my opinion the second component does not have a place in Healing Done.

I believe the healing done meter is used to gauge how effectively your healers are healing. At the very least it should reflect the effect of healing spells. The effect of LotM is its healing output minus the damage it causes. But right now the meter gives a false healing output for anyone casting LotM regularly: the displayed effective healing is 50% higher than it really is. So the current display of not including the LotM damage is wrong and against what I think the goal of the healing done meter is.

Also overhealing is subtracted in healing done reinforcing that it's about the effectiveness of healing, not just output.

Also absorbs are considered in healing done so there seems to be a place for other types of effects.

Similar to tanks with Damage Taken. Some tanks take more damage by way of class design. They also then show up on Healing Done. But Damage Taken is not adjusted to account for the healing they do.

Damage Taken isn't a Tank Performance meter though. However what is taken into account in Damage Taken is damage avoided with absorbs. Or rather, it's actually not included in the display at all. (This seems strange to me but this isn't the right issue for that) So basically it already shows the effective damage taken. And I believe healing done should try to do the same: the effective healing, so overhealing not included, absorbs included, and negative healing (i.e. LotM self damage) substracted.

If you ever want to hear a bunch of Holy Paladins backing this up, hop into the holy paladin discord: https://discord.gg/7sD2eWb