WowAce

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?
----------------------------------------------------------------------------------------------
I'm playing a fury warrior and when i check my enrage uptime, it shows around 2% and sometimes lower.. And i have a feeling that the longer fight goes, the lower percentage gets. (Checked it at, Heroic boss, trash packs, target dummy etc..). Also Its not just enrage, all the other buffs are showing a very low percentage of uptime. Normally enrage uptime should be around, 50-60% and even higher with gear.

What version of the product are you using?
----------------------------------------------------------------------------------------------
I'm using the latest one. Also tried a few older versions but its the same result.

Do you have an error log of what happened?

Please provide any additional information below.
----------------------------------------------------------------------------------------------
One of my friends, while we were in the same party for a heroic dungeon, said he could see my enrage uptime to be around 60% and he is also using skada, but he said he was using an even older version like 1.4 or something?

I also had this happen. I had the buff uptime window open, and I see that I have the buff, but still the percentage in the buff uptime window is going down... When I have the buff logic dictates that the uptime percentage has to go up- So something is amiss there.

It seems like Skada is only tracking the initial application presence of a buff. I tested a couple of times on my DH with a 60 second target dummy fight. I used immolation aura on CD (every 13.6 sec) and at the 30 second mark used soul cleave to clear the initial soul fragment buff. I also was spamming shear so that within a few seconds at most a new soul fragment buff was applied. The results were:

• Soul Fragment uptime 44%, 40.6%
• Immolation Aura uptime 9.8%, 10.9%

There should have been around 75-90% uptime on Soul Fragment depending on RNG and as Immolation Aura lasts 6 seconds with a 13.6 sec CD it should have been around 40-44% even accounting for lag.

Given that I cleared my initial soul fragment buff at 30 seconds with soul cleave and assuming a second or two for the initial application presence to appear that 40-44% uptime would be for that initial application presence. Same for Immolation aura, it lasts 6 seconds(aka 10% of a minute)

Edit: after testing with demon spikes I actually think it stops counting the uptime after the first time the buff falls off. I tested this again with a 1 minute fight. I applied demon spikes and then reapplied it before the initial application fell off the results were a 18.2% uptime, which is pretty close to the expected 20% since demon spikes lasts 6 seconds (2 applications would be 12 seconds if done perfect) and I had to reapply slightly early.

The logic in log_auraapply in Debuffs.lua looks to be faulty.

It never sets .started except for the first time a buff/debuff is (continually) active.

It should probably look like this: http://pastebin.com/zdZ2hU7s

The change being the addition of:

player.auras[aura.spellname].started = player.auras[aura.spellname].started or time()

right after:

player.auras[aura.spellname].active = player.auras[aura.spellname].active + 1