Questions about activity monitoring (>1000%) #529


Open
  • transitbus created this issue Jul 10, 2017

    Not sure if this is a bug of a limitation in what  ever function(s) are being used to calculate activity but when solo or on a target dummy activity is out of whack. Like 2000+%. It is accurate inside a raid or party just not solo.

     

    Is that even fixable?

     

    For example:

     

  • transitbus edited description Jul 10, 2017
  • transitbus posted a comment Jul 10, 2017

    Actually this happened in an LFR testing against other BM hunters

     

     

    Activity time is Waaaaay off.

  • transitbus edited title Jul 10, 2017
  • transitbus posted a comment Jul 10, 2017

    It seems for the most part it collects the correct activity at the end of a fight but during it often swings wildly even above 10,000%

  • xodiv posted a comment Aug 11, 2017

    Here is the fix for the whacky in-combat numbers.  In Skada.lua change: 

    function Skada:GetSetTime(set)
            if set.time then
                    return set.time
            else
                    return (time() - set.starttime)
            end
    end
    

     to

    function Skada:GetSetTime(set)
            if set.time and set.time > 0 then
                    return set.time
            else
                    return (time() - set.starttime)
            end
    end
    

     


    Edited Aug 11, 2017
  • xodiv posted a comment Aug 11, 2017

    There is a related problem for "trivial" segments which are current.

     

    I think the fix is in Skada:EndSegment() the updating of self.current.endtime, self.current.time and the call of setPlayerActiveTimes need to be moved out of the trivial set test.

     

     

     


    Edited Aug 11, 2017

To post a comment, please login or register a new account.