Hati bm hunter bugged even worse than before #537


  • Defect
Open
  • _ForgeUser28506003 created this issue Jul 14, 2017

       As you can see in the screen shot from the link bellow in the 3rd window starting from the left, my Hati is completely missing, no auto attacks, no kill commands (only my main pet) and many other damages that Hati does. As seen in the main window it is not  separately at the end. My hati was added to the hunter in the first 2 windows. When you use kill command normally both your main pet and Hati do the attack so at the end they should have an equal number of this ability. The hunter in the 2 windows has 92 Hati kill commands while his main pet has 44. He's got an extra 48 hati kill commands exactly how many my missing Hati should have as my main pet had 48. All other dmg from his hati is also inflated from mine so the entire pet was added to him. Basically im down around 140-150 k dps and he is up by that much.

       Also had my Hati showing up in our demo warlock's dmg but just the kill command. Other times Hati shows in my dmg but only a random number of kill commands is missing and added to smb else.There are a number of combinations of this bug ranging from bad to very bad depending on how it chooses to bug^^

    If before only bm hunters were pissed off now everybody that uses skada is angry as smb is gonna often get a free 140-200 k dps boost depending on how aoe heavy the fight is.

     

    https://s18.postimg.org/9pio95fvt/Wo_WScrn_Shot_071417_120921.jpg

     

    L.e. Here is a screenshot with my hati entirely added to the warlock's dmg (on 6 positions)

     

    https://s22.postimg.org/s04xusadt/Wo_WScrn_Shot_071617_225616.jpg

  • _ForgeUser28506003 added a tag Defect Jul 14, 2017
  • _ForgeUser28506003 edited description Jul 14, 2017
  • _ForgeUser28506003 edited description Jul 14, 2017
  • _ForgeUser28506003 edited description Jul 14, 2017
  • _ForgeUser28506003 edited description Jul 14, 2017
  • _ForgeUser28506003 edited title and description Jul 15, 2017
  • _ForgeUser28506003 edited description Jul 16, 2017
  • xodiv posted a comment Jul 25, 2017

    r740 was a terrible Tweak and needs to be removed.

                -- Hati (7.0, BM hunter artifact)
                if band(srcFlags, PET_FLAG) ~= 0 then
                    lastpet.timestamp = timestamp
                    lastpet.srcGUID = srcGUID
                elseif srcName == 'Hati' and not assignedhatis[srcGUID] then
                    if lastpet.timestamp == timestamp then
                        local owner = Skada:GetPetOwner(lastpet.srcGUID)
                        if owner then
                            Skada:AssignPet(owner.id, owner.name, srcGUID)
                            assignedhatis[srcGUID] = true
                        end
                    end
                end
    

    This actually breaks correct assignments of Hati NPCs seen in the core via SPELL_SUMMON. And, worse, from my combat log testing doesn't work anyway - Hati and hunter pets don't cast at the same timestamp anyway.

    The minimum fix to this is to remove the assignedhatis variable completely and have the elseif check be

                elseif srcName == 'Hati' and not Skada:GetPetOwner(srcGUID) then
                    if lastpet.timestamp == timestamp then
                        local owner = Skada:GetPetOwner(lastpet.srcGUID)
                        if owner then
                            Skada:AssignPet(owner.id, owner.name, srcGUID)
                        end
                    end
                end
    

    But honestly it's so useless you may as well remove the entire Tweak. What I'm seeing in logs is that unrelated unit's pets do actions by coincidence at the same time and Hati gets assigned or reassigned completely incorrectly.

    At least without the tweak it'll be right if it sees the Hati summon, which it will for the the hunter themselves.

  • xodiv posted a comment Jul 25, 2017

    It seems like you may be also able to do assigment based on the Titan's Thunder buff application, if it is cast (it's an golden artifact trait), as it does seem to apply to only the casting hunter's Hati.

     

    This from the WoWCombatLog.txt but I think the same is true for CLEU:

    7/25 16:09:10.185 SPELL_CAST_SUCCESS,Player-3721-01DE6BC8,"Halas-Caelestrasz",0x518,0x0,0000000000000000,nil,0x80000000,0x80000000,207068,"Titan's Thunder",0x1,0000000000000000,0000000000000000,0,0,0,0,-
    7/25 16:09:10.185 SPELL_AURA_APPLIED,Player-3721-01DE6BC8,"Halas-Caelestrasz",0x518,0x0,Player-3721-01DE6BC8,"Halas-Caelestrasz",0x518,0x0,207068,"Titan's Thunder",0x1,BUFF
    7/25 16:09:10.185 SPELL_AURA_APPLIED,Player-3721-01DE6BC8,"Halas-Caelestrasz",0x518,0x0,Pet-0-3888-1220-13885-731-040057DA71,"Ellvis",0x1118,0x0,218638,"Titan's Thunder",0x8,BUFF
    7/25 16:09:10.632 SPELL_AURA_APPLIED,Player-3721-01DE6BC8,"Halas-Caelestrasz",0x518,0x0,Pet-0-3888-1220-13885-731-040057DA71,"Ellvis",0x1118,0x0,207094,"Titan's Thunder",0x1,BUFF
    7/25 16:09:10.632 SPELL_AURA_APPLIED,Player-3721-01DE6BC8,"Halas-Caelestrasz",0x518,0x0,Creature-0-3888-1220-13885-100324-000076D76E,"Hati",0x2118,0x0,207094,"Titan's Thunder",0x1,BUFF

     E.g.,

                -- Hati (7.0, BM hunter artifact)
                if firstArg == 207094 and event == 'SPELL_AURA_APPLIED' and band(dstFlags, PET_FLAG) ~= 0 and not Skada:GetPetOwner(dstGUID) then
                    Skada:AssignPet(srcGUID, srcName, dstGUID)
                end
    
    

    Edited Jul 25, 2017
  • xodiv posted a comment Jul 28, 2017

    Including "Mend Pet" and "Bestial Wrath" which you can only cast on your own pet too.

     

        Skada.cleuFrame:SetScript("OnEvent", function(frame, event, timestamp, eventtype, hideCaster, srcGUID, srcName, srcFlags, srcRaidFlags, dstGUID, dstName, dstFlags, dstRaidFlags, ...)
    
            -- Detect Hati (7.0, BM hunter artifact "pet")
            -- SPELL_SUMMON in core will pick this up normally if we see the summon.
            if dstName == 'Hati' and event == 'SPELL_AURA_APPLIED' and band(srcFlags, COMBATLOG_OBJECT_TYPE_PLAYER) ~= 0 and not Skada:GetPetOwner(dstGUID) then
                local buff = select(1, ...) 
                -- mend pet, bestial wrath, titan's thunder
                if buff == 136 or buff == 207033 or buff == 207094 then
                    Skada:AssignPet(srcGUID, srcName, dstGUID)
                end
            end
    
            -- Only perform these modifications if we are already in combat
            if Skada.current then
                local firstArg = select(1, ...)
    
                -- Akaari's Soul (7.0, Rogue artifact)
                if (firstArg == 185438 or firstArg == 145424) and eventtype == 'SPELL_DAMAGE' then
    
    

    Edited Jul 28, 2017
  • transitbus posted a comment Jul 30, 2017

    If you do this then you need to include dire beasts as well. They get "decoupled" from hunter damage as well.  They are labelled as "Beast"

     

    https://www.wowace.com/projects/skada/issues/533

     

     

  • pherl posted a comment Jul 31, 2017

    Any chance to roll back the broken logic at least? This makes this dps meter useless as I will be either ranked No 1, if the other hunter's hati counts as mine, or at the bottom if otherwise. Only about 1 in 10 pulls the meter is correct  (comparing to the wcl)

  • xodiv posted a comment Aug 1, 2017

    I put a comment in on your Dire Beast issue - it's not really the same problem and as far as I can see can't be fixed.

     

    The licensing for Skada doesn't let me fix it, so I'm really going to suggest https://mods.curse.com/addons/wow/details at this point.

  • transitbus posted a comment Aug 2, 2017

    Skada has way more problems than just not keeping its parsing up to data with combat log changes. Spells are not being parsed correctly, internal functions of skada to track things like uptime and activity time are so out of whack they are now comical. Not to mention it isn't accurately loading half the time in instances so its reporting of dps and hps are often critically out of sync.

     

    I love the concept of skada and how light weight it is and I despise the sloppiness of how details uses memory space but Skada is dead and I have moved on to details a while back. I simply came back to see if skada can be salvaged but it looks like that isn't the case.

     

    People move on from this game all the time and one of the key developers for skada ha done so as well. The idiotic licensing model that curse offers (all right reserved) has come back to bite quite a few popular addons lately.

  • xodiv posted a comment Aug 10, 2017

    Frustrating, but I'm not really seeing most of those problems. Are there tickets in for them? What's being parsed incorrectly? Not sure about activity (how to define it is pretty arbitrary) but I think uptimes should be ok since my fix got put in earlier in the year.


To post a comment, please login or register a new account.