WowAce

Hello, 

Wonderful addon. Thank you for all your hardwork. 

I'm getting lua errors when I fight mobs with an NPC companion. Max level Blood DK on Antonidas. Right now, I'm in Bastion with Alexandros Mograine, and any time I get into combat, I get the following errors. 

#1

Message: Interface\AddOns\Skada\modules\Enemies.lua:18: Usage: local className, classFilename, classID = UnitClass(unit)
Time: Tue Feb 15 12:51:55 2022
Count: 5
Stack: Interface\AddOns\Skada\modules\Enemies.lua:18: Usage: local className, classFilename, classID = UnitClass(unit)
[string "=[C]"]: ?
[string "=[C]"]: in function `UnitClass'
[string "@Interface\AddOns\Skada\modules\Enemies.lua"]:18: in function <Interface\AddOns\Skada\modules\Enemies.lua:15>
[string "@Interface\AddOns\Skada\modules\Enemies.lua"]:40: in function <Interface\AddOns\Skada\modules\Enemies.lua:33>
[string "@Interface\AddOns\Skada\modules\Enemies.lua"]:131: in function `func'
[string "@Interface\AddOns\Skada\Skada.lua"]:1854: in function <Interface\AddOns\Skada\Skada.lua:1747>
[string "@Interface\AddOns\Skada\Skada.lua"]:1903: in function <Interface\AddOns\Skada\Skada.lua:1902>

Locals:

#2

Message: Interface\AddOns\Skada\modules\Enemies.lua:18: Usage: local className, classFilename, classID = UnitClass(unit)
Time: Tue Feb 15 12:51:57 2022
Count: 1
Stack: Interface\AddOns\Skada\modules\Enemies.lua:18: Usage: local className, classFilename, classID = UnitClass(unit)
[string "=[C]"]: ?
[string "=[C]"]: in function `UnitClass'
[string "@Interface\AddOns\Skada\modules\Enemies.lua"]:18: in function <Interface\AddOns\Skada\modules\Enemies.lua:15>
[string "@Interface\AddOns\Skada\modules\Enemies.lua"]:40: in function <Interface\AddOns\Skada\modules\Enemies.lua:33>
[string "@Interface\AddOns\Skada\modules\Enemies.lua"]:107: in function `func'
[string "@Interface\AddOns\Skada\Skada.lua"]:1854: in function <Interface\AddOns\Skada\Skada.lua:1747>
[string "@Interface\AddOns\Skada\Skada.lua"]:1903: in function <Interface\AddOns\Skada\Skada.lua:1902>

Locals:

For some reason this only happens with Necrolord players who go through the covenant campaign quests. At least from observation. Someone else noticed the same. See the second comment here: https://www.curseforge.com/wow/addons/skada/issues/616

I have completed Venthyr, Kyrian and Night Fae and didn't experience it. No amount of reloading helped. I did some troubleshooting steps and noticed it happens when you have a friendly NPC with you as part of the quest. These NPCs are classified as pets in this state. This is where the problem comes from. As to why Necrolord only, I have no idea. Pets are merged under your character in the meter with the format "PetName: PetAbility"

Baroness Draka for example. She was helping me kill enemy NPCs and I would get the LUA every single time I entered combat. I have ticked "Merge pets" under "General options" in /skada config. In the damage meter under [Current fight] > [Damage] > Zyven, I should see her damage output as "Baroness Draka: Attack". But I wasn't.

I was able to work around this by unticking "Merge pets" and resetting the meter data to empty. The damage meter now shows Baroness Draka as "Zyven: Baroness Draka". Clicking that shows her abilities separately from mine. The LUA errors disappeared.