WowAce

Blazethesage reported on the curse comments page:

I'm having a strange issue... I'm playing an affliction warlock, and Speakinspell doesn't seem to be recognizing when I land a killing blow.  I know for sure I'm getting the kill, Speakinspell simply doesn't do anything with it.  Any thoughts?  No cooldowns, 100% chance (for testing), and nothing.

EDIT: So, confirmation, for some reason my spells are not triggering the Killing Blow trigger.  If I were to smack an enemy to death with my staff however, that triggers it just fine.  Is this something weird with the mod, or has Blizzard decided to be a butt and break this on their end?  I've never had trouble with the killing blow trigger on casters before...

EDIT2: Further clarification: It's specifically damage-over-time spells that don't trigger the "Killing blow" trigger.  If I were to land a killing blow with Seed of Corruption's explosion, for example, it would go off just fine.

I think the root cause is in this bit of logic in wowevents.lua

	--TODOFUTURE: this is only going to catch MOST killing blows
	--	if you kill something by exactly the right amount of damage, your overkill can be 0
	--	that's extremely unlikely, but for perfection we could use UNIT_DIED or PARTY_KILL
	--	Unfortunately, both of those provide GUID parameters instead of names
	--	which is just annoying, so I'm leaving it based on overkill damage for now
	if overkill and overkill > 0 then

Damage of time spells probably never cause overkill damage