WowAce

What steps will reproduce the problem?

1. Log on after upgrading from r210 to v3.0

2. After fixing the above problem (see below), log on again and try to disable, then enable a 60 minute buff through the options: Fire Festival Fortitude (on due to the WoW holidays).

What is the expected output? What do you see instead?

Expected: no issues for 1. and for 2., the spell to disable and reenable when checkmarking the "Enabled" option for it.

Instead: on first logon after upgrading, an error is thrown and the mod no longer functions. After fixing that issue by deleting the saved variables and trying again, encounter the second problem. The spell(s) you checkmark to enable or disable tracking of don't pay attention to the state of the checkmark until you relog.

What version of the product are you using?

v3.0

Do you have an error log of what happened?

For the first issue:

["message"] = {
				"SpellReminder-3.0\\core.lua:455: table index is nil\nSpellReminder-3.0\\core.lua:424: in function `AddNewAnchor'\nSpellReminder-3.0\\core.lua:447: in function `CreateAnchors'\nSpellReminder-3.0\\core.lua:424: in function `AddNewAnchor'\nSpellReminder-3.0\\core.lua:443: in function `CreateAnchors'\nSpellReminder-3.0\\core.lua:355: in function `OnProfileEnable'\nSpellReminder-3.0\\core.lua:280: in function <Interface\\AddOns\\SpellReminder\\core.lua:279>\n(tail call): ?:\n<in C code>: ?\n<string>:\"safecall Dispatcher[1]\":9: in function <[string \"safecall Dispatcher[1]\"]:5>\n(tail call): ?:\nAceAddon-3.0-10 (Ace3):543: in function `EnableAddon'\nAceAddon-3.0-10 (Ace3):635: in function <Interface\\AddOns\\Ace3\\AceAddon-3.0\\AceAddon-3.0.lua:621>\n<in C code>: in function `LoadAddOn'\nInterface\\FrameXML\\UIParent.lua:259: in function `UIParentLoadAddOn':\nInterface\\FrameXML\\UIParent.lua:282: in function `CombatLog_LoadUI':\nInterface\\FrameXML\\UIParent.lua:558: in function <Interface\\FrameXML\\UIParent", -- [1]
				".lua:531>:\n", -- [2]
			},
			["type"] = "error",
			["session"] = 3113,
			["counter"] = 1,
		}, -- [997]

No errors for the second issue.

Please provide any additional information below.

As the first issue was fixed by deleting (both the root and individual character) saved variables from the Ace2 SpellReminder, it says that no upgrade code is in the mod. Logging on after the upgrade, it shows you two anchors on the screen as well as throwing up the error. Nothing further can be done; the options can't be accessed and no spells are tracked.

You don't want people upgrading to run into this bug, so three alternatives.

- - The easiest way is just to say "you must delete all your prior SpellReminder saved variables before logging on with the new Ace3 version". Very much a hassle for users who spent a great deal of time setting up the Ace2 version the way they wanted. All that time spent goes up in smoke.

- - Second option is also undesirable: have the mod automatically reset the saved variables on logon from an older version so it doesn't bugout.

- - Third option is the best: provide a one-time upgrade mechanism/SV interpreter so that people can continue to use their old saved variable settings that they may have spent a great deal of time setting up. Bar positions, what spells to track and not track and so on. Its the most code for you to do this, but the hours of time saved for people not having to set things up from scratch from will benefit society the most ;).

The second problem is enough to make me go back to the Ace2 version for now. The old version instantly hid spells when you set them to "inactive" and showed them again when you changed them to "active". v3.0 doesn't do that. Once you remove the checkmark from Enabled for a spell, the spell bar remains onscreen until you relog. Same deal checkmarking a spell's Enabled to make it active when its in the Inactive header section; you have to relog to see it again..

Having to relog to change the active status of spells is a monumental ongoing hassle. More and more so the more database mods you run and/or the slower the computer you have, as both of those slow down your relogs. Its so much of a hassle here that I'm back to the Ace2 version.

Great idea to port this to Ace3, but hope to see these two issues fixed.

Thanks Zidomo, I've taken down the v3 'release' version, the latest alpha r211 is the same release so you can still play with it there. Hopefully it didn't destroy too many people's SVs!

I should be able to retain the same savedvariables. I thought mine was working with the old SV format but shall have to compare and fix.

As for enabling and disabling, i will check it out tonight. I've booked some coding time with the lady so i should be able to get some time in! ;)

Thanks!

Hi Zidomo, can you please try again with the latest beta (r217). If all is ok then i'll release it as v3.0

Thanks!

Ahh I see you've been hard at work since I was last here :).

Sure, will try another alpha/beta. Since your post below, though, seems you have released a few more since r217; currently is at r221. Let me know when/if you'd like me to test one just prior to the intended release push (or earlier) and for sure, will give it a go here.

r222 is a release candidate. Take a look and see what you think! :)

I switched this ticket back from Verified to Waiting status because r223/v3.0 bugs out again upgrading from the last Ace2 version's saved variables here (the first problem reported in this ticket). Its even worse than the first time it happened with this ticket's r211.

Log on and the following two errors are thrown up. Unlike the same earlier problem, no bars are shown or anything; the mod completely dies:

["message"] = "SpellReminder-3.0\\core.lua:176: table index is nil\n(tail call): ?:\n<in C code>: ?\n<string>:\"safecall Dispatcher[1]\":9: in function <[string \"safecall Dispatcher[1]\"]:5>\n(tail call): ?:\nAceAddon-3.0-10 (Ace3):514: in function `InitializeAddon'\nAceAddon-3.0-10 (Ace3):628: in function <Interface\\AddOns\\Ace3\\AceAddon-3.0\\AceAddon-3.0.lua:621>\n",
			["type"] = "error",
			["time"] = "2011/07/07 03:12:49",
			["session"] = 3185,
			["counter"] = 1,
		}, -- [999]
		{
			["message"] = "SpellReminder-3.0\\core.lua:441: table index is nil\nSpellReminder-3.0\\core.lua:341: in function `OnProfileEnable'\nSpellReminder-3.0\\core.lua:266: in function <Interface\\AddOns\\SpellReminder\\core.lua:265>\n(tail call): ?:\n<in C code>: ?\n<string>:\"safecall Dispatcher[1]\":9: in function <[string \"safecall Dispatcher[1]\"]:5>\n(tail call): ?:\nAceAddon-3.0-10 (Ace3):543: in function `EnableAddon'\nAceAddon-3.0-10 (Ace3):635: in function <Interface\\AddOns\\Ace3\\AceAddon-3.0\\AceAddon-3.0.lua:621>\n<in C code>: in function `LoadAddOn'\nInterface\\FrameXML\\UIParent.lua:259: in function `UIParentLoadAddOn':\nInterface\\FrameXML\\UIParent.lua:282: in function `CombatLog_LoadUI':\nInterface\\FrameXML\\UIParent.lua:558: in function <Interface\\FrameXML\\UIParent.lua:531>:\n",
			["type"] = "error",
			["time"] = "2011/07/07 03:13:11",
			["session"] = 3185,
			["counter"] = 1,
		}, -- [1000]

Exit and log on the same character again after this happens without deleting the new SVs, an error identical to the second one above occurs.

One thing different, the SpellReminder LDB feed is active unlike the first try with r223. Go into options by rightclicking the feed. Under Timer Bars, both the Bar Groups and Filter Priorities header pages are completely blank.

Click some more things on the options frame, yet another error is thrown up:

["message"] = {
				"SpellReminder-3.0\\core.lua:441: table index is nil\nSpellReminder-3.0\\options.lua:22: in function <Interface\\AddOns\\SpellReminder\\options.lua:18>\n(tail call): ?:\n<in C code>: ?\n<string>:\"safecall Dispatcher[2]\":9: in function <[string \"safecall Dispatcher[2]\"]:5>\n(tail call): ?:\nAceConfigDialog-3.0-54:798: in function <...nfig-3.0\\AceConfigDialog-3.0\\AceConfigDialog-3.0.lua:613>\n(tail call): ?:\n<in C code>: ?\n<string>:\"safecall Dispatcher[3]\":9: in function <[string \"safecall Dispatcher[3]\"]:5>\n(tail call): ?:\nAceGUI-3.0-33 (Ace3):314: in function `Fire'\n...ns\\Ace3\\AceGUI-3.0\\widgets\\AceGUIWidget-DropDown.lua:439: in function <...ns\\Ace3\\AceGUI-3.0\\widgets\\AceGUIWidget-DropDown.lua:430>:\n(tail call): ?:\n<in C code>: ?\n<string>:\"safecall Dispatcher[3]\":9: in function <[string \"safecall Dispatcher[3]\"]:5>\n(tail call): ?:\nAceGUI-3.0-33 (Ace3):314: in function `Fire'\n...3\\AceGUI-3.0\\widgets\\AceGUIWidget-DropDown-Items.lua:351: in function <...3\\AceGUI-3.0\\widgets\\AceGUIW", -- [1]
				"idget-DropDown-Items.lua:341>:\n", -- [2]
			},
			["type"] = "error",
			["time"] = "2011/07/07 05:12:26",
			["session"] = 3186,
			["counter"] = 1,
		}, -- [1000]
	},

Similar to the second error above, but it happens via options.lua, line 22 instead of core.lua, line 341. Casting spells, nothing happens; no bars are shown or anything.

------

Finally, delete all SVs and try logging on again. Sure enough, like the original ticket problem #1, this solves the bugouts. After logging on a Druid, bars for Mark of the Wild and his (60 minute) food buff appear with unlocked bars.

Then go into options and uncheck "Enabled" for each of the buffs. Close the options and yes, the bars go away immediately.

But then go back into options and recheck Enabled to get them back. Unfortunately, just like ticket problem #2, they don't come back until I relog. Upon relogging, both bars reappear. Even more unfortunately, after they come back on relog, you can't get rid of them in-game. Go back into options, uncheck Enabled on both and they don't go away.

Then cast a healing spell on the Druid, which brings up a new bar. Magically, the two spells above that I wanted Enabled again suddenly appear.

Finally, uncheck Enabled again for both. They don't go away...lol. Stood there without doing anything and discovered they only go away and/or come back if you wait up to 30 seconds, at which time they do suddenly change state. They also go away/come back if you cast a spell that brings up another bar, as noted above.

Appreciate you deciding to go with the auto-upgrade option for the SVs. It bugs out and doesn't work at all though. And the bar enabling/disabling is flaky; shouldn't have to wait an extended time and/or cast a different spell to have the bar status change take effect. The last Ace2 version's bar status changes took effect immediately.

could you please test again with the latest beta (r228)? The nil index bug should be fixed :)

I'd like to test the alphas before you tag them for release...but there is never enough time before you do (sobs uncontrollably).

:D

Will be able to test in a couple of hours to see if r229/v3.0.1 have fixed the above issues for good.

Haha i try to wait, but get over zealous thinking that the last "release" was buggy (because i didnt let you test that one either!) If this release is all ok, we can do a proper testing process for future changes :)

Issue #1 isn't fixed with r229/v3.0.1. Slightly improved, but still majorly bugged.

Log on with Ace2-version SVs. Unlike prior revision attempts, it does not bug out at that time. Better, the default "normal" & "emphasis" bars are in the very same locations I had set them to in the Ace2 version.

But with the old version, I personally added an additional (non-default) bar to track Druid Lifebloom. The bar is called (appropriately enough)..."Lifebloom". I positioned it immediately to the right of the raid frames on the left side of the UI. The two default bars were positioned (and carried over correctly) in the center-middle of the UI.

Cast the Lifebloom spell, an error is thrown and the "Lifebloom" bar does not appear at any time. The spell doesn't appear at the normal or emphasis anchors either. Worse, the error rapidly repeats on each tick of the spell:

["message"] = "SpellReminder-3.0\\core.lua:885: attempt to index field '?' (a nil value)\nSpellReminder-3.0\\core.lua:829: in function <Interface\\AddOns\\SpellReminder\\core.lua:808>\n(tail call): ?:\n<in C code>: ?\n<string>:\"safecall Dispatcher[2]\":9: in function <[string \"safecall Dispatcher[2]\"]:5>\n(tail call): ?:\nAceTimer-3.0-5 (Ace3):164: in function <Interface\\AddOns\\Ace3\\AceTimer-3.0\\AceTimer-3.0.lua:138>\n",
            ["type"] = "error",
            ["session"] = 3271,
            ["counter"] = 112,
        }, -- [1000]

So the upgrade code isn't handling custom bars properly. Not only not handling them properly, but like every time before, it continues to bug out until you delete your current saved variables and start from scratch. Go into Timer Bars, Bar Groups and delete your custom bar. Uncheck "Allow Custom Group". Exit and restart. Try casting Lifebloom again. The previous bug occurs again, repeating at a high speed. Go back into options and notice that "Allow Custom Group" was magically checkmarked again on its own; it has no group selected.

As to problem #2, its much improved. No longer have to wait up to 30 seconds to see a bar state change. Instead, the changes appear within a handful of seconds (no more than 5). Not as good as the Ace2's instant state change, but usable.

Ok, the latest beta should fix the bar import issue for good

Not quite sure what the other issue is (the one with a 5second lag?). If it is still an issue, could you create a separate ticket for that please? I'm getting a bit confused with the two bugs in one :)

Thanks!

Nope. r232 bugs out in different circumstances...and the options cannot be accessed. Which essentially kills the mod's functionality.

After rolling back my SVs to the Ace2 version's, log on with a character that does not have any custom bars set up (unlike the Druid in the previous test), only the default Normal and Emphasis bars. Bugs are thrown at logon as well as 19 seconds afterwards (not casting anything):

["message"] = "LibBars-1.0-90013 (SpellReminder):334: A bar list named Emphasis already exists.\nLibBars-1.0-90013 (SpellReminder):334: in function `NewBarGroup'\nSpellReminder-3.0\\core.lua:484: in function `CreateAnchors'\nSpellReminder-3.0\\core.lua:467: in function `DeleteAnchor'\nSpellReminder-3.0\\core.lua:434: in function `RenameAnchor'\nSpellReminder-3.0\\core.lua:179: in function <Interface\\AddOns\\SpellReminder\\core.lua:168>\n(tail call): ?:\n<in C code>: ?\n<string>:\"safecall Dispatcher[1]\":9: in function <[string \"safecall Dispatcher[1]\"]:5>\n(tail call): ?:\nAceAddon-3.0-10 (Ace3):514: in function `InitializeAddon'\nAceAddon-3.0-10 (Ace3):628: in function <Interface\\AddOns\\Ace3\\AceAddon-3.0\\AceAddon-3.0.lua:621>\n",
			["type"] = "error",
			["time"] = "2011/07/14 12:46:40",
			["session"] = 3276,
			["counter"] = 1,
		}, -- [997]
		{
			["message"] = "LibBars-1.0-90013 (SpellReminder):334: A bar list named Emphasis already exists.\nLibBars-1.0-90013 (SpellReminder):334: in function `NewBarGroup'\nSpellReminder-3.0\\core.lua:484: in function `CreateAnchors'\nSpellReminder-3.0\\core.lua:345: in function `OnProfileEnable'\nSpellReminder-3.0\\core.lua:267: in function <Interface\\AddOns\\SpellReminder\\core.lua:266>\n(tail call): ?:\n<in C code>: ?\n<string>:\"safecall Dispatcher[1]\":9: in function <[string \"safecall Dispatcher[1]\"]:5>\n(tail call): ?:\nAceAddon-3.0-10 (Ace3):543: in function `EnableAddon'\nAceAddon-3.0-10 (Ace3):635: in function <Interface\\AddOns\\Ace3\\AceAddon-3.0\\AceAddon-3.0.lua:621>\n<in C code>: in function `LoadAddOn'\nInterface\\FrameXML\\UIParent.lua:259: in function `UIParentLoadAddOn':\nInterface\\FrameXML\\UIParent.lua:282: in function `CombatLog_LoadUI':\nInterface\\FrameXML\\UIParent.lua:558: in function <Interface\\FrameXML\\UIParent.lua:531>:\n",
			["type"] = "error",
			["time"] = "2011/07/14 12:46:59",
			["session"] = 3276,
			["counter"] = 1,
		}, -- [998]

As it was a bank alt character, logged out and logged on a main character that also has no custom bars active, only the default ones. But with a lot of detected spells. No errors there on logon.

Finally, logged on the Druid that had the issue upgrading the SVs earlier. No errors at logon. The Normal & Emphasis bars positions were carried over properly from the Ace2 SVs. And (drum roll)....the custom "Lifebloom" bar also appeared in the proper position and didn't bugout like before. So looking good.

But not quite. Noticed that in addition to the LDB feed I have always run with SpellReminder (now going through LibDataBroker instead of the old version in combo with FuBar2Broker), there was now a minimap icon all of a sudden. Clicked it to access the option panel, an error was thrown up and the panel refused to open. A mod-killing bug; see the new ticket 22.

---

At this point, I suggest just removing all the upgrade code and put a warning on the descriptions for people to make sure to delete their old saved variables if upgrading from the Ace2 version. Doing more than that but less than the current full upgrade code that has yet to work without functionality bugs:

1) Automatically delete an old version's detected SVs once the Ace3 version is installed and never again. Some mods have done this sort of thing on version upgrades.

2) Even simpler, throw up a warning frame at first logon (only) of the Ace3 version, reminding people that things are unlikely to work properly unless they delete all their old SVs after exiting and coming back. Have seen other mods do this as well.

If you instead really want to try to sort out the ongoing issues with the upgrade code...hope you are able to.

it should be easy to fix the upgrade code. i rolled back to v2, set up new groups, pointed spells to customgroups and then upgraded to v3. It took a while to fix the issues but eventually i got it to work perfectly. So i'm not sure why you're seeing problems and i'm not.

The LibBars problem i did see however. And still occurs when renaming a bar and renaming it back. I can perhaps recycle the old groups though. This is a LibBars bug and will only be fixed when moving to LibCandyBar (LibBars does not have an option to remove/release Groups). Unfortunately this move is not an easy one as LibCandyBar does not have built in 'bar groups'. So i would have to manage an anchor, and bar sorting and positioning manually. A lot of code i dont have time to do right now.

As for the upgrade code, with people spending so much time on setting up their SpellReminder, I feel I need to nail the upgrade and make it automatic. As my test case worked perfectly, i'm sure it will be possible. Perhaps you could attach your v2 SV files (both char and profile) so i can try to work with those?

Thanks!

alpha r234 should resolve the "A bar list named Emphasis already exists." problem.

And....r234 is still messed up.

Log on with that version with v2.2.1's (Ace2) saved variables on both the earlier character that gave the LibBars error as well as the Druid, no errors. Cast regular spells that appear on both the Normal and Emphasis bars, no problem. Open SpellReminder's options, no problem.

But then cast Lifebloom which I still have set to appear in a custom bar. And yet again, yee olde attempt to index field '?' error that also occurred with r229:

["message"] = "SpellReminder-3.0\\core.lua:897: attempt to index field '?' (a nil value)\nSpellReminder-3.0\\core.lua:841: in function <Interface\\AddOns\\SpellReminder\\core.lua:820>\n(tail call): ?:\n<in C code>: ?\n<string>:\"safecall Dispatcher[2]\":9: in function <[string \"safecall Dispatcher[2]\"]:5>\n(tail call): ?:\nAceTimer-3.0-5 (Ace3):164: in function <Interface\\AddOns\\Ace3\\AceTimer-3.0\\AceTimer-3.0.lua:138>\n",
			["type"] = "error",
			["time"] = "2011/07/15 05:19:16",
			["session"] = 3292,
			["counter"] = 71,
		}, -- [1000]

As before, the bar doesn't appear and the error repeats at high speed.

Then go into options and notice that for the spell set to appear on the custom bar (Lifebloom), Allow Custom Group is checkmarked, but strangely no Custom Group name is selected. Its blank. So go into the dropdown for Custom Group and manually select the bar name I had previously set (also "Lifebloom").

After doing that, no more errors on casting.

So more work to do on importing spells set to custom groups from the Ace2 version.

are bars being imported properly now (r237). If not, is it possible to include a copy of your savedvariables for SpellReminder? For this bug, i just need the \WTF\Account\#\SavedVariables\SpellReminder.lua file. as bar groups are stored in the profile, and not per char.

Thanks!

Not spending time testing importing again right now as there are two new/ongoing issues with r237. See tickets 25 & 26.

At this point, we are getting dangerously close to this mod "jumping the shark". A similar problem previously afflicted the ZOMGBuffs mod. Long, long ago, it was far and away the most reliable buff-suggesting mod when it was using Ace2. It unfortunately jumped the shark on its move to Ace3. An endless string of ongoing bugs; many of which still aren't resolved after many months since the framework change.

The advantage SpellReminder has at this time: an active author :). Still, new builds that only partially fix a previous problem while continually introducing major new problems is a recipe for never having it work properly. Hopefully we can get to a point where this mod acts as it did in its Ace2 guise.

I identified a possible problem, importing older SV files (why it didn't have a problem for my newer v2 saved variables!). The options automatically hides spells which haven't been used for some time, unfortunately time seems to have softend and the current time is a mile out compared to the last seen time. r239 bypasses the "auto archive" feature. All your spells should now show properly.

Not to worry about the development. as long as you're happy to test it i'm happy to fix it! I am really grateful for all your hard work, it makes a refreshing change having some help with testing ;)

Keep me posted on how you get on :)

Ori

known issue: bargroups not showing in the options... fixing it now

fixed that, next problem with bar group imports. for some reason the groups are not shown now... working on it :)

ok, try r241 :)

r242: no LUA errors so far on an Ace2 SV import. But continuing problems. Biggest problem: it still doesn't deal with importing custom bars properly.

As before, logged on one character, logged out then logged on the Druid who has the Lifebloom custom bar. No errors. Cast Lifebloom. The spell fails to appear in its previously set up custom bar; instead it appears in a Normal bar.

Go into options (which doesn't throw errors anymore). For the Lifebloom spell, notice that Allow Custom Group is checkmarked but...like before, the Custom Group selection has nothing at all showing.

So pull out that dropdown list and select "Lifebloom" (the custom bar name that the spell is supposed to be attached to and was in the Ace2 vers., as mentioned before). Sure enough, cast the spell and it properly shows up in the custom bar in the proper position.

Another problem: in addition to the above, both Font & Texture under Bar Formatting are also blank after an import. So you have no way of knowing in-game what font/texture you were previously using. Changing the font/texture from "blank" to something else from the dropdowns works and the names chosen remain showing after doing so.

Aha, i think i finally understand what the problem is. Bar groups are stored in the profile, not per char. So when you import one char, you aren't getting the bars from your other char. this begs the question: Is it better to store groups per char? The problem with that is i have about 5 cars i use regularly and i have a common bar group layout. it would be very tiring to have to set them up on every char.

Which do you think is the best way?

As for font and texture, i know why that has happened. Ace3Config returns the table key as the value on selects instead of the table value (Ace2) ill have to write custom converts for these.

Ill post again when these are fixed. thanks!

Well, profiles are not selectable by the user currently with SpellReminder. As AceDB-3.0 allows fairly easy implemetation of profile selection, it may (or may not) be worth it to put it in.

But...the typical default with the AceDB-3.0 method is to have it save per-character profiles as opposed to using a "default" global one. I don't remember an Ace3 mod with profile selection actually defaulting to a global "default" on first install. Users have to change each character to a global "default" if they want that. Which is a slight bit of a hassle on first use, but not a large one. Another quick profile adjustment allowed is to import settings from another character (or a default) into one character's existing profile settings, which can be done quickly.

A much larger hassle is setting up bar groups (and every other option) for many different characters that you instead want to be global, as you mention. Its a pet peeve of mine on mods that implement profiles, but default to per-character with no easy way of moving to global (as the AceDB-3.0 method provides). So...

Not sure you can implement a (AceDB-3.0) profile system while having various options per-character and other options global as SpellReminder currently does. But if you can, do it. The small amount of user hassle enabling the custom bar groups per character is much (much) less than having to redo every Normal & Emphasis bar group from scratch per-character as you mention.

If on the other hand you cannot separate particular option sections into different profile sections (bar groups global, spells per-character, etc.) using selectable profiles, it brings up the giant question: Have a user-selectable profile system or not?

I don't see a benefit of it. Spells are 99.9999% of the time something users would want to keep per-character. Having global spell profiles I could not even imagine. A global shared list of spells would be enormous and far too much of a hassle to look at and deal with on each character due to many spells having no use between characters. And as you mention, bar groups & bar options are, for the most part, something most users would want to be global, except for custom bars. Most users I would imagine would want sound & text alert options to be global as well (except again for custom bars).

So I vote to keep profiles as they are and not move to a user-selectable AceDB-3.0 profile system, if you cannot separate option sections in such a system.

As to Ace2 importing, can imagine people having a large number of custom bars attached to a large number of particular spells would have a large amount hassle as it currently is. Similar to other users having to redo Normal & Emphasis groups on each character...heh.

So I don't see the solution there, other than to not worry about it. Assessing things in terms of "most users affected", I see more people as having things as you (and I) do: more bars in Normal & Emphasis groups than in custom groups. So forcing people to reselect custom groups for particular spells will affect less people than having to set up bar groups for every character. Having bars off by even one pixel between characters can affect a person's efficiency and muscle memory.

So again, don't worry about the issue and don't change bar groups to be stored per-character.

Currently the spells are stored per char, so this can stay as is, no reason to move this into a profile.

In the last alpha bar groups are imported from the per char db, and moved into the profile, it will do this when you log into each character. so as you log into more and more characters you may well get more bar groups appearing each time. these are done by name, so if you have two groups with the same name across different characters then it won't import it twice. so anyone setting up common groups on every character will have a nice clean interface.

If you have bar groups set up as follows: warrior: normal, emphasis, shouts druid: normal, emphasis, raid buffs, lifebloom

after logging into both characters, these will be merged. so you will have the following groups in all characters: normal, emphasis, shouts, raid buffs, lifebloom

all per char spells will retain their custom groups, so theoretically the user shouldnt need to change anything. They may however wish to combine some of these groups, so i may remove the group shouts, and target all of my shouts to raid buffs instead.

Basically i want to give the user as much options as possible.

All settings are stored in the profile apart from spells, which are per char... I'll probably leave it this way unless we can think of a good reason not too. :)

It might be worth trying your v2 bank char then druid bar group import again. with the latest alpha you should see all of your druid bars merged in even if you log into the bank first! :)

If that's the case, we can mark this one as fixed?

Thanks :D

r244: still fails to disable (after unchecking Enabled) a new spell detected for many seconds (20+) after first detecting it. Or until a different spell is cast. Same thing with rechecking a spell to Enabled; takes forever (or until another spell is cast) for it to show up. Problematic for long duration buffs/spells.

This is from a r242 upgrade; import testing still to come.

latest beta fixes the disabling/enabling thing. r245 :)

Yes, nice work. r245 completely solves the enabling/disabling. Bars now go away immediately after disabling and come back immediately after enabling.

Import testing still to come, again ;).

Bad news (& a bit of good) with the importing of Ace2 SVs with r245. Custom bars attached to spells and their locations are properly imported. But lots of things are not.

The dropdown selections for General, Text Warnings along with Texture and Font under Bar Formatting as well as Allow Custom Sound under particular spells (it is set for) are all blank after logging on, much like earlier versions.

Ill try to get this fixed asap :)

fixed in r253 by making use of AceGUI-3.0-SharedMediaWidgets - no version 2 SV import required, as this change reverts to using the same save format as spellreminder v2 for sharedmedia options.

Ah interesting. Moreso that it requires another library to do that. No problem, though; AceGUI-3.0-SharedMediaWidgets is a very widely used library with no history of problems.

Yes, with two considerations for using old settings, more problems have the potential for appearing than with one. As in: 1) "import" & interpret the old settings and 2) convert those settings to the currently used format. Elimination of 2) can certainly remove one potential for problems.

Have not tested importing since r245, will again soon.

In addition to the more serious issue with r255 in the other ticket, another one will put there.

Have not tested Ace2 SV importing with yet, but in terms of upgrading from a pre-AceGUI-3.0-SharedMediaWidgets version (r251 used before here), it experiences the exact same problem...heh. Most all dropdown selections are blank after logging on with a r255 upgrade.

the first implementation of ace3config was badly done on my part, this caused boxes to be blank on upgrading from version2. this new method is compatible with the version2 saves, but anyone who has been using version 3 will now get blank boxes again. i can write a "version3 to new version3 import", that shouldn't take long :)

I've a routine to fix the saved variables and tested it with old v2 saves and the old v3 saves. it seems to be working for me, could you try it? Thanks!

With r258 (upgrading from r251 saved variables), a lot is fixed, but not everything. On the single custom bar here (along with the other bars) the proper font, scaling & texture were imported correctly and correctly shown in the dropdown selections.

But on the custom bar, the previously selected custom sound was not imported correctly. Instead of the "BeepBeepBeep" sound previously selected, it mysteriously chose "CartoonFX".

Haven't tested very much further importing; at this stage, it pretty much doesn't matter for the bulk of users. One bug with it still seen, however.

A Paladin respeced into protection (tanking) for the first time since Lich King. Had "Crusader" as a tracked buff cooldown (its a spell effect from the talent Crusade). Bugged out and the following error was thrown & repeated throughout a 5-man instance run. It was placed on the default Normal & Emphasis bars, the bars were not changed or moved:

["message"] = "LibBars-1.0-90013 (LibBars-1.0):589: Cannot move SpellReminder_TRACKING_Crusader;0x0200000003A82B3B to this group; a bar with that name already exists.\nLibBars-1.0-90013 (LibBars-1.0):589: in function `MoveBarToGroup'\nSpellReminder-3.0\\core.lua:968: in function `CreateReminderBar'\nSpellReminder-3.0\\core.lua:898: in function <Interface\\AddOns\\SpellReminder\\core.lua:875>\n(tail call): ?:\n<in C code>: ?\n<string>:\"safecall Dispatcher[2]\":9: in function <[string \"safecall Dispatcher[2]\"]:5>\n(tail call): ?:\nAceTimer-3.0-5 (Ace3):164: in function <Interface\\AddOns\\Ace3\\AceTimer-3.0\\AceTimer-3.0.lua:138>\n",
			["type"] = "error",
			["session"] = 3925,
			["counter"] = 10,
		}, -- [1000]