WowAce

------------------------------------------------------------------------
r87 | subdino | 2009-11-21 09:34:18 +0000 (Sat, 21 Nov 2009) | 2 lines
Changed paths:
   A /tags/1.0-rc6 (from /trunk:86)

Tagging as 1.0-rc6
Last rc before guild synchronisation support.
------------------------------------------------------------------------
r86 | subdino | 2009-11-13 07:54:29 +0000 (Fri, 13 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

"#" operator doesn't work on a set, take 2.
Also, add a note about MAX_FRIEND_COUNT having an underestimated value.
------------------------------------------------------------------------
r85 | subdino | 2009-11-13 07:54:27 +0000 (Fri, 13 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Make it possible to add other condition causing an importExport call to be
aborted.
------------------------------------------------------------------------
r84 | subdino | 2009-11-13 07:54:26 +0000 (Fri, 13 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Make actions get called with SyncFriends instance as first parameter for
future extension.
------------------------------------------------------------------------
r83 | subdino | 2009-11-13 07:54:24 +0000 (Fri, 13 Nov 2009) | 1 line
Changed paths:
   M /trunk/SyncFriends.lua

Don't take the risk to transmit unexpected parameters to callback.
------------------------------------------------------------------------
r82 | subdino | 2009-11-13 07:54:23 +0000 (Fri, 13 Nov 2009) | 1 line
Changed paths:
   M /trunk/SyncFriends.lua

Make configuration tab order stable.
------------------------------------------------------------------------
r81 | subdino | 2009-11-13 07:54:21 +0000 (Fri, 13 Nov 2009) | 1 line
Changed paths:
   M /trunk/SyncFriends.lua

Fix logical inversion when registering for event notification.
------------------------------------------------------------------------
r80 | subdino | 2009-11-06 07:59:23 +0000 (Fri, 06 Nov 2009) | 1 line
Changed paths:
   M /trunk/SyncFriends.lua

Check friend list has been loaded upon importExport call.
------------------------------------------------------------------------
r79 | subdino | 2009-11-05 21:30:29 +0000 (Thu, 05 Nov 2009) | 1 line
Changed paths:
   M /trunk/SyncFriends.lua

Don't try to update cache if it was not generated yet.
------------------------------------------------------------------------
r78 | subdino | 2009-11-05 21:30:28 +0000 (Thu, 05 Nov 2009) | 1 line
Changed paths:
   M /trunk/SyncFriends.lua

# operator doesn't work for key-value maps.
------------------------------------------------------------------------
r77 | subdino | 2009-11-05 21:30:26 +0000 (Thu, 05 Nov 2009) | 1 line
Changed paths:
   M /trunk/SyncFriends.lua

Make AddFriend and RemoveFriend hooks obey configuration.
------------------------------------------------------------------------
r75 | subdino | 2009-11-05 00:14:16 +0000 (Thu, 05 Nov 2009) | 4 lines
Changed paths:
   M /trunk/SyncFriends.lua

Cache getUISyncPoolOption return value, and update it in an incremental
manner. This dramatically reduces the amount of CPU used by SyncFriends
when using the option dialog, while it increases memory footprint by
a few kB only
------------------------------------------------------------------------
r74 | subdino | 2009-11-05 00:14:14 +0000 (Thu, 05 Nov 2009) | 1 line
Changed paths:
   M /trunk/SyncFriends.lua

Make setNote raise an error when setting a note for an unknown friend.
------------------------------------------------------------------------
r73 | subdino | 2009-11-05 00:14:12 +0000 (Thu, 05 Nov 2009) | 1 line
Changed paths:
   M /trunk/SyncFriends.lua

Factorize storeAction message printing.
------------------------------------------------------------------------
r72 | subdino | 2009-11-04 23:17:46 +0000 (Wed, 04 Nov 2009) | 1 line
Changed paths:
   M /trunk/SyncFriends.lua

Fix typo in comment.
------------------------------------------------------------------------
r71 | subdino | 2009-11-04 23:17:45 +0000 (Wed, 04 Nov 2009) | 1 line
Changed paths:
   M /trunk/SyncFriends.lua

Replace repeated string appends by table.concat call.
------------------------------------------------------------------------
r70 | subdino | 2009-11-04 23:17:43 +0000 (Wed, 04 Nov 2009) | 3 lines
Changed paths:
   M /trunk/SyncFriends.lua

findglobals detects magic comments for "unavoidable" globals, and
suggests to bind lua built-ins & modules to local namespace.
Also, pre-resolve module functions to avoid multiple lookups.
------------------------------------------------------------------------
r69 | subdino | 2009-11-04 23:17:42 +0000 (Wed, 04 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Fix error when Auto-export is disabled and there is an unknown character
in friend list.
------------------------------------------------------------------------
r68 | subdino | 2009-11-03 03:03:49 +0000 (Tue, 03 Nov 2009) | 3 lines
Changed paths:
   M /trunk/SyncFriends.lua

Expand tabs.
Remove unexected parameter from method declaration.

------------------------------------------------------------------------
r66 | subdino | 2009-11-02 21:48:17 +0000 (Mon, 02 Nov 2009) | 2 lines
Changed paths:
   M /trunk/Locales/enUS.lua

Update default translation.

------------------------------------------------------------------------
r65 | subdino | 2009-11-02 21:45:04 +0000 (Mon, 02 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Make message translation-friendly.

------------------------------------------------------------------------
r64 | subdino | 2009-11-02 21:43:24 +0000 (Mon, 02 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Remove improper way to forget a pool entry.

------------------------------------------------------------------------
r62 | subdino | 2009-11-02 21:24:46 +0000 (Mon, 02 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

It is meaningless to "initialise" variables to nil.

------------------------------------------------------------------------
r61 | subdino | 2009-11-02 21:23:57 +0000 (Mon, 02 Nov 2009) | 3 lines
Changed paths:
   M /trunk/SyncFriends.lua

Make SyncFriends:forget actualy work.
Use it from SyncFriends:unsetKnownBy.

------------------------------------------------------------------------
r60 | subdino | 2009-11-02 21:13:55 +0000 (Mon, 02 Nov 2009) | 3 lines
Changed paths:
   M /trunk/SyncFriends.lua

Fix an "undefined global" error in SyncFriends:dump method.
Add a commented-out list of "local" definition whose only purpose is to make findglobals output more quiet when enabled.

------------------------------------------------------------------------
r59 | subdino | 2009-11-02 21:10:45 +0000 (Mon, 02 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Simplify setKnownBy/unsetKnownBy use (only takes friend name as parameter).

------------------------------------------------------------------------
r58 | subdino | 2009-11-02 20:47:17 +0000 (Mon, 02 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Fix access to undefined variable when removing a friend. Sig.

------------------------------------------------------------------------
r57 | subdino | 2009-11-02 20:45:43 +0000 (Mon, 02 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Fix access to undefined variable when adding a friend.

------------------------------------------------------------------------
r56 | subdino | 2009-11-02 20:26:14 +0000 (Mon, 02 Nov 2009) | 3 lines
Changed paths:
   M /trunk/SyncFriends.lua

Add an option to forget a friend when no alt has him in his friendlist.
Make option ordering fixed so new option don't become first.

------------------------------------------------------------------------
r55 | subdino | 2009-11-02 19:47:29 +0000 (Mon, 02 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Use a special color for "self" player in displayed player names.

------------------------------------------------------------------------
r54 | subdino | 2009-11-02 19:46:27 +0000 (Mon, 02 Nov 2009) | 3 lines
Changed paths:
   M /trunk/SyncFriends.lua

For each friend, store which alt knows it.
Also, display that list on the configuration panel of each friend.

------------------------------------------------------------------------
r53 | subdino | 2009-11-02 08:00:03 +0000 (Mon, 02 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Local-ize globals accidentaly introduced in r51.

------------------------------------------------------------------------
r52 | subdino | 2009-11-02 07:59:03 +0000 (Mon, 02 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Add a comment about improving config dialog layout.

------------------------------------------------------------------------
r51 | subdino | 2009-11-02 07:58:22 +0000 (Mon, 02 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Display alt names differently than friend names.

------------------------------------------------------------------------
r50 | subdino | 2009-11-02 07:56:51 +0000 (Mon, 02 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Fix a bug introduced in sync pool layout change which made it impossible to register new friends for sync.

------------------------------------------------------------------------
r49 | subdino | 2009-11-01 21:41:45 +0000 (Sun, 01 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

No need to output a "replacing note" message when there is no note set yet.

------------------------------------------------------------------------
r48 | subdino | 2009-11-01 17:17:02 +0000 (Sun, 01 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Add initial note synchronisation support.

------------------------------------------------------------------------
r47 | subdino | 2009-11-01 12:56:04 +0000 (Sun, 01 Nov 2009) | 3 lines
Changed paths:
   M /trunk/SyncFriends.lua

Make generated accessors become methods.
Pass all received parameters through to scoped accessors.

------------------------------------------------------------------------
r46 | subdino | 2009-11-01 12:35:54 +0000 (Sun, 01 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Make addGetSet orthogonal to overridableOptionGroupArgs.

------------------------------------------------------------------------
r45 | subdino | 2009-11-01 11:14:44 +0000 (Sun, 01 Nov 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Check if accessors already exist before creating and binding them on class.

------------------------------------------------------------------------
r44 | subdino | 2009-11-01 11:13:26 +0000 (Sun, 01 Nov 2009) | 3 lines
Changed paths:
   M /trunk/SyncFriends.lua

Separate titlecased property name from property access.
Separate overridableOptionGroupArgs arguments from addGetSet ones.

------------------------------------------------------------------------
r43 | subdino | 2009-11-01 09:25:14 +0000 (Sun, 01 Nov 2009) | 5 lines
Changed paths:
   A /trunk/.pkgmeta
   M /trunk/SyncFriends.lua

Global variable cleanup:
- declare local some vars which were accidentaly made globals
- move local declaration out of loops when possible
- remove all *_ACTION_NAME since they are used in only one place

------------------------------------------------------------------------
r42 | subdino | 2009-10-31 22:11:10 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Remove now useless isFriend method, and add an XXX about possible polution of synchronisation pool.

------------------------------------------------------------------------
r41 | subdino | 2009-10-31 22:06:32 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Friends are actualy added/removed after scripts are executed (not immediately), so it is wrong to check for their presence in the friend list immediately after the call.

------------------------------------------------------------------------
r40 | subdino | 2009-10-31 22:01:57 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Make playerName a local.

------------------------------------------------------------------------
r39 | subdino | 2009-10-31 22:01:23 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Call isFriend with ":" so it gets the magic self-reference.

------------------------------------------------------------------------
r38 | subdino | 2009-10-31 15:45:37 +0000 (Sat, 31 Oct 2009) | 3 lines
Changed paths:
   M /trunk/Locales/deDE.lua
   A /trunk/Locales/esES.lua
   A /trunk/Locales/esMX.lua
   M /trunk/Locales/frFR.lua
   M /trunk/Locales/koKR.lua
   M /trunk/Locales/ruRU.lua
   M /trunk/Locales/zhCN.lua
   M /trunk/Locales/zhTW.lua
   M /trunk/SyncFriends.toc

Fix locales (return immediately if L is nil).
Add esMX and esES locales.

------------------------------------------------------------------------
r37 | subdino | 2009-10-31 15:21:15 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Don't translate slash command usage templates.

------------------------------------------------------------------------
r36 | subdino | 2009-10-31 15:15:00 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.toc

Toc file cleanup: Clean addon name, use a repository keyword for version.

------------------------------------------------------------------------
r34 | subdino | 2009-10-31 14:52:05 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Fix inability to remove friends: only register unknown friends to sync pool.

------------------------------------------------------------------------
r33 | subdino | 2009-10-31 14:50:52 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Properly call original function to fix infinite hook recursion.

------------------------------------------------------------------------
r32 | subdino | 2009-10-31 14:33:49 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Fix titlecasing match string: underscores must be stripped from property name.

------------------------------------------------------------------------
r30 | subdino | 2009-10-31 13:44:29 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

copyTable's result should be local.

------------------------------------------------------------------------
r29 | subdino | 2009-10-31 13:32:47 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Replace "== nil" by "not", as advised by stolenlegacy.

------------------------------------------------------------------------
r28 | subdino | 2009-10-31 12:59:27 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Add an XXX about a magic constant.

------------------------------------------------------------------------
r27 | subdino | 2009-10-31 12:44:04 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Rename auto export and auto import properties. This breaks configuration compatibility, which is still allowed/acceptable in beta.

------------------------------------------------------------------------
r26 | subdino | 2009-10-31 12:42:38 +0000 (Sat, 31 Oct 2009) | 3 lines
Changed paths:
   M /trunk/SyncFriends.lua

Change "property" parameter value: now it's the actual property name, not a titlecased value.
Also, remove related XXX from overridableOptionGroupArgs as we just pass that value through to addGetSet.

------------------------------------------------------------------------
r25 | subdino | 2009-10-31 12:25:27 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Dexcription typo.

------------------------------------------------------------------------
r24 | subdino | 2009-10-31 12:21:25 +0000 (Sat, 31 Oct 2009) | 5 lines
Changed paths:
   M /trunk/SyncFriends.lua

Rethink addOverridableOption:
- Make its use consistent with slashCommand and dynamicGroup
- Group by option rather than by scope
- Rename as overridableOptionGroupArgs

------------------------------------------------------------------------
r23 | subdino | 2009-10-31 10:05:33 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Reorganise configuration panel to leave more space for friend list.

------------------------------------------------------------------------
r22 | subdino | 2009-10-31 09:22:28 +0000 (Sat, 31 Oct 2009) | 5 lines
Changed paths:
   M /trunk/SyncFriends.lua

Remove XXXs from slashCommand:
- AceConsole is designed to be embeded into addon, so this is a dependency, not an XXX
- It is not possible to guess any of given arguments, so no way (for the moment) to reduce their number.
- Defining only a setter works (it is called even when no arguments are given).

------------------------------------------------------------------------
r21 | subdino | 2009-10-31 09:17:29 +0000 (Sat, 31 Oct 2009) | 3 lines
Changed paths:
   M /trunk/SyncFriends.lua

Make optionAsSlashCommand use consistent with dynamicGroup.
Rename optionAsSlashCommand into slashCommand.

------------------------------------------------------------------------
r20 | subdino | 2009-10-31 09:08:28 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Hide "dump" action from user interface (but preserve it as slash command).

------------------------------------------------------------------------
r19 | subdino | 2009-10-31 09:04:54 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Make "Dump start" localizable.

------------------------------------------------------------------------
r18 | subdino | 2009-10-31 09:04:14 +0000 (Sat, 31 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Add a user interface (via config panel) to modify sync pool content.

------------------------------------------------------------------------
r17 | subdino | 2009-10-25 11:02:05 +0000 (Sun, 25 Oct 2009) | 4 lines
Changed paths:
   M /trunk/Locales/deDE.lua
   M /trunk/Locales/enUS.lua
   M /trunk/Locales/frFR.lua
   M /trunk/Locales/koKR.lua
   M /trunk/Locales/ruRU.lua
   M /trunk/Locales/zhCN.lua
   M /trunk/Locales/zhTW.lua

Fix non-default translations:
- they are not the default translation (copy-paste is baad)
- debug needs to be defined just once

------------------------------------------------------------------------
r16 | subdino | 2009-10-25 10:40:19 +0000 (Sun, 25 Oct 2009) | 2 lines
Changed paths:
   A /trunk/Locales
   A /trunk/Locales/deDE.lua
   A /trunk/Locales/enUS.lua
   A /trunk/Locales/frFR.lua
   A /trunk/Locales/koKR.lua
   A /trunk/Locales/ruRU.lua
   A /trunk/Locales/zhCN.lua
   A /trunk/Locales/zhTW.lua
   M /trunk/SyncFriends.lua
   M /trunk/SyncFriends.toc

Make translatable, and add translation template files.

------------------------------------------------------------------------
r15 | subdino | 2009-10-25 10:32:05 +0000 (Sun, 25 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Remove ununsed variable.

------------------------------------------------------------------------
r14 | subdino | 2009-10-25 10:29:52 +0000 (Sun, 25 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Don't set configuration option title from addGetSet so it besomes independant from storage id (and becomes translatable).

------------------------------------------------------------------------
r13 | subdino | 2009-10-24 18:00:52 +0000 (Sat, 24 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Inline global- and char-level option groups so they are visible at the same time in the configuration panel.

------------------------------------------------------------------------
r12 | subdino | 2009-10-24 17:59:59 +0000 (Sat, 24 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Hooking RemoveFriend requires to allow AceHook to act on secure functions (was lost in r10).

------------------------------------------------------------------------
r11 | subdino | 2009-10-24 17:02:21 +0000 (Sat, 24 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

There is no point in refusing user to register a player for skip if not known already.

------------------------------------------------------------------------
r10 | subdino | 2009-10-24 16:44:40 +0000 (Sat, 24 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Implement RemoveFriend TODO and factorise with AddFriend.

------------------------------------------------------------------------
r9 | subdino | 2009-10-24 16:38:22 +0000 (Sat, 24 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Fix a typo in NewAddon parameter.

------------------------------------------------------------------------
r8 | subdino | 2009-10-24 15:27:40 +0000 (Sat, 24 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Detect when user has reached the friend list limit, and skip addition (found by Codayus_).

------------------------------------------------------------------------
r7 | subdino | 2009-10-24 15:26:02 +0000 (Sat, 24 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Declare "result" as local (fixes unexpected return values).

------------------------------------------------------------------------
r6 | subdino | 2009-10-24 15:02:07 +0000 (Sat, 24 Oct 2009) | 2 lines
Changed paths:
   M /trunk/SyncFriends.lua

Don't ignore action return value.

------------------------------------------------------------------------
r5 | subdino | 2009-10-24 14:02:03 +0000 (Sat, 24 Oct 2009) | 3 lines
Changed paths:
   M /trunk/SyncFriends.lua

Factorise code from getPool and flushPool.
Make flushPool emit a log so user knows something happened.

------------------------------------------------------------------------
r4 | subdino | 2009-10-24 13:53:59 +0000 (Sat, 24 Oct 2009) | 4 lines
Changed paths:
   M /trunk/SyncFriends.lua

Cleanup action registry: use a static registry, as there is no need to change it dynamicaly, and the amount of factorised code isn't worth the pain.
Make coding style more consistent: don't use semicolons as line terminators.
Remove unused consts.

------------------------------------------------------------------------
r3 | subdino | 2009-10-24 12:20:01 +0000 (Sat, 24 Oct 2009) | 3 lines
Changed paths:
   M /trunk/SyncFriends.lua

Add documentation for (potentialy) generic functions, and gather TODOs/XXXs.
Wordwrap at 79 chars.

------------------------------------------------------------------------
r2 | subdino | 2009-10-24 11:35:32 +0000 (Sat, 24 Oct 2009) | 2 lines
Changed paths:
   A /trunk/SyncFriends.lua
   A /trunk/SyncFriends.toc

Initial import.

------------------------------------------------------------------------
r1 | root | 2009-10-24 11:21:26 +0000 (Sat, 24 Oct 2009) | 1 line
Changed paths:
   A /branches
   A /tags
   A /trunk

"syncfriends/mainline: Initial Import"
------------------------------------------------------------------------