WowAce

What steps will reproduce the problem?
1. Unknown
2. When adding friend
3. Unknown

What is the expected output? What do you see instead?
Friend is added--the friend is added with any notes.

What version of the product are you using?
1.3

Do you have an error log of what happened?
Date: 2012-02-22 11:01:42
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\SyncFriends\SyncFriends.lua line 794:
   Cannot set a note for an unknown friend.
Debug:
   (tail call): ?
   [C]: ?
   [C]: ?
   SyncFriends\SyncFriends.lua:794: setNote()
   SyncFriends\SyncFriends.lua:698:
      SyncFriends\SyncFriends.lua:695
   (tail call): ?
   [C]: SetFriendNotes()
   ..\FrameXML\StaticPopup.lua:1854: OnAccept()
   ..\FrameXML\StaticPopup.lua:3646: StaticPopup_OnClick()
   [string "*:OnClick"]:1:
      [string "*:OnClick"]:1
AddOns:
  Swatter, v5.13.5258 (BoldBandicoot)
  WowheadLooter, v40020
  NPCScan, v4.3.0.2
  NPCScanOverlay, v4.3.0.1
  Ace3, v
  AckisRecipeList, v2.3.0
  Altoholic, v4.3.001
  Atlas, v1.21.1
  AtlasBattlegrounds, v1.21.1
  AtlasDungeonLocs, v1.21.0
  AtlasOutdoorRaids, v1.21.0
  AtlasLoot, vv6.05.03
  AtlasLootCataclysm, vv6.05.03
  AtlasLootLoader, vv6.05.03
  AtlasQuest, v4.7.0
  AucAdvanced, v5.13.5258 (BoldBandicoot)
  aucadvancedsearcherpawn, v1.3.8
  AucFilterBasic, v5.13.5258 (BoldBandicoot)
  AucFilterOutlier, v5.13.5258.5187(5.13/embedded)
  AucMatchUndercut, v5.13.5258.5232(5.13/embedded)
  AucScanData, v5.13.5258 (BoldBandicoot)
  AucStatHistogram, v5.13.5258 (BoldBandicoot)
  AucStatiLevel, v5.13.5258 (BoldBandicoot)
  AucStatPurchased, v5.13.5258 (BoldBandicoot)
  AucStatSales, v5.13.5258.4838(5.13/embedded)
  AucStatSimple, v5.13.5258 (BoldBandicoot)
  AucStatStdDev, v5.13.5258 (BoldBandicoot)
  AucStatWOWEcon, v5.13.5258.4828(5.13/embedded)
  AucUtilAHWindowControl, v5.13.5258.5133(5.13/embedded)
  AucUtilAppraiser, v5.13.5258.5241(5.13/embedded)
  AucUtilAskPrice, v5.13.5258.5160(5.13/embedded)
  AucUtilAutoMagic, v5.13.5258.5224(5.13/embedded)
  AucUtilCompactUI, v5.13.5258.5254(5.13/embedded)
  AucUtilEasyBuyout, v5.13.5258.5241(5.13/embedded)
  AucUtilFixAH, v5.13.5258 (BoldBandicoot)
  AucUtilItemSuggest, v5.13.5258.5224(5.13/embedded)
  AucUtilPriceLevel, v5.13.5258.5241(5.13/embedded)
  AucUtilScanButton, v5.13.5258.5153(5.13/embedded)
  AucUtilScanFinish, v5.13.5258.5153(5.13/embedded)
  AucUtilScanProgress, v5.13.5258.4979(5.13/embedded)
  AucUtilScanStart, v5.13.5258.5153(5.13/embedded)
  AucUtilSearchUI, v5.13.5258.5254(5.13/embedded)
  AucUtilSimpleAuction, v5.13.5258.5210(5.13/embedded)
  AucUtilVendMarkup, v5.13.5258.4828(5.13/embedded)
  Babylonian, v5.1.DEV.312(/embedded)
  BagBrother, v
  Bagnon, v4.3.9
  BankStack, vv25
  BeanCounter, v5.13.5258 (BoldBandicoot)
  Collectinator, v1.0.21
  Configator, v5.1.DEV.312(/embedded)
  Cromulent, vv1.6
  CurseProfiler, v
  DataStore, v4.3.001
  DataStoreAchievements, v4.3.001
  DataStoreAgenda, v4.3.001
  DataStoreAuctions, v4.3.001
  DataStoreCharacters, v4.3.001
  DataStoreContainers, v4.3.001
  DataStoreCrafts, v4.3.001
  DataStoreCurrencies, v4.3.001
  DataStoreInventory, v4.3.001
  DataStoreMails, v4.3.001
  DataStorePets, v4.3.001
  DataStoreQuests, v4.3.001
  DataStoreReputations, v4.3.001
  DataStoreSpells, v4.3.001
  DataStoreStats, v4.3.001
  DataStoreTalents, v4.3.001
  DBMCore, v
  DebugLib, v5.1.DEV.312(/embedded)
  Decursive, v2.7.0.5
  Dominos, v4.3.4
  DominosBufftimes, v
  DominosCast, v
  DominosTotems, v
  DominosXP, v
  EasyMail, v
  Enchantrix, v5.13.5258 (BoldBandicoot)
  EnchantrixBarker, v5.13.5258 (BoldBandicoot)
  FBBroker, v1.15e
  FBMergeDatabase, v1.0.7
  FBOutfitDisplayFrame, v1.0.7e
  FBTitan, v1.0.7
  FBTrackingFrame, v1.0.7
  FishingBuddy, v1.0.7f
  Gatherer, v3.2.4
  GathererDBWowhead, v1.0.2011-11-03
  GearScore, v4.11.00.00
  HealBot, v4.3.0.1
  InFlightLoad, v4.3.001
  Informant, v5.13.5258 (BoldBandicoot)
  LibExtraTip, v5.12.DEV.319(/embedded)
  LightHeaded, v344
  Livestock, v1.5.4
  Molinari, v40300.14-Beta
  Outfitter, v5.4.4
  Pawn, v1.5.19
  QuestCompletist, v99.5
  QuestGuru, v2.2.7-40300
  QuestGuruTracker, v1.5.10-40300
  Rarity, v1.0
  RarityOptions, v
  Recount, v
  SimpleCoords, v1.94
  Skillet, v
  SlideBar, v5.13.5258 (BoldBandicoot)
  Spellcraft, v
  Stubby, v5.13.5258 (BoldBandicoot)
  SyncFriends, v1.3
  TabardMaster, v094
  TipHelper, v5.12.DEV.315(/embedded)
  Titan, v5.0.12.40300 - Revision 519
  TitanGold, v5.0.12.40300
  TitanHealBot, v4.3.0.0
  TitanXP, v5.0.12.40300
  TomTom, vv40300-1.4.4-541092e
  WIM, vr315
  XBar, v4.13
  XBuffBar, v4.05
  XCustomBar, v4.04
  XPetStuffBar, v4.06
  XRogueBar, v4.03
  XSealBar, v4.03
  XTradeBar, v4.05
  XTrapBar, v4.03
  XWarlockBar, v4.04
  BlizRuntimeLib_enUS v4.3.2.40300 <us>
  (ck=f49)

Please provide any additional information below.

Thanks for the bug report.

Could you try with the latest svn revision ? You should just have to replace SyncFriends.lua after checking it out. I don't expect my changes to actually solve the issue, but they should help identifying the cause. The error message should mention the name of the friend it's trying to set a note for, or even the friend number SetFriendNotes is called for. (Boy, is that API inconvenient...).

Disclaimer: I didn't run my changes on WoW after writing them. They are simple enough to be very-likely-correct, but I don't have an active WoW account for several months now. Also, my changes pass FindGlobals checks, so at least they are valid LUA and there should not be any variable name typo.

@Subdino: Go

Sorry, this wasn't clear enough: If you just use a bare SyncFriends SVN checkout, you will not have translations. If you wish to test the fix with your existing v1.3 translations, you may just overwrite SyncFriends.lua from your 1.3 addon with the one from SVN.