Does not identify tanking role in timewalker dungeons #44


  • Defect
Open
Assigned to fulgertunet
  • MysticalOS created this issue Oct 16, 2016

    I haven't really debugged it but in a TW dungeon it treats me (a tank who's role is tank in the dungeon) as a dps with dps threat colors.

  • MysticalOS added the tags New Defect Oct 16, 2016
  • Fulger posted a comment Oct 17, 2016

    The functions seem to return good information. Using:

    local specIndex = GetSpecialization()
    local id, name, description, texture, background, role, class = GetSpecializationInfo(specIndex)
    
    if role == "TANK" ...
    

    The spec info update happens on ACTIVE_TALENT_GROUP_CHANGED. Is it possible you were DPS outside the dungeon and were swapped to tank automatically when entering the dungeon?

    Anyway it might be a good idea to update on PLAYER_ENTERING_WORLD also. Not sure if there is a special event fired for the auto talent change when using group finder.

  • MysticalOS posted a comment Oct 17, 2016

    Nope, ALWAYS tank, tank before going in, tank on inside. in fact i was doing world quests before the dungeon and it used tank colors. it LITERALLY changed from tank to DPS as soon as I entered timewalker dungeon (in a tank spec/role)

    it'll require debugging but it's just not something I had time to do.

    I do know when you enter a dungeon ACTIVE_TALENT_GROUP_CHANGED can fire several times and the way they code it now, briefly you might not appear with a spec. it's possible it briefly pulled no spec at all and defaulted dps. possibly adding a delay and throttle to check would solve it. I know in DBM I dropped using ACTIVE_TALENT_GROUP_CHANGED completely and just use PLAYER_SPECIALIZATION_CHANGED instead. That may be worth reviewing too.

  • MysticalOS posted a comment Oct 17, 2016

    Nope, ALWAYS tank, tank before going in, tank on inside. in fact i was doing world quests before the dungeon and it used tank colors. it LITERALLY changed from tank to DPS as soon as I entered timewalker dungeon (in a tank spec/role)

    it'll require debugging but it's just not something I had time to do.

    I do know when you enter a dungeon ACTIVE_TALENT_GROUP_CHANGED can fire several times and the way they code it now, briefly you might not appear with a spec. it's possible it briefly pulled no spec at all and defaulted dps. possibly adding a delay and throttle to check would solve it. I know in DBM I dropped using ACTIVE_TALENT_GROUP_CHANGED completely and just use PLAYER_SPECIALIZATION_CHANGED instead. That may be worth reviewing too.


    Edited Oct 17, 2016
  • cdartois posted a comment Oct 17, 2016

    I noticed this as well on my DH... was really throwing me off lol

  • Fulger posted a comment Mar 4, 2017

    This might have been fixed in v1.25 on 26 Oct 2016.

  • Fulger removed a tag New Mar 4, 2017

To post a comment, please login or register a new account.