wow 5.3 - all queries return as complete true #22


  • Started
  • Defect
Open
Assigned to sylvanaar
  • left2hand4dark created this issue May 22, 2013

    What steps will reproduce the problem?
    1.use libwho:Who with arg of 90-90 on high pop server  when return has count of 50
    2.use libwho;who with arg of 90-90 c-"eachclass" and get counts that total more then 50
    3.Use CensusPlus version Toc 50200 release with out of date enabled.. and compare with version for 50300 which disables libwho usage.

    What is the expected output? What do you see instead?
    libwho calls api numResults, totalCount = GetNumWhoResults()
    pre 5.3 this would return at max  49, 50  which would trigger complete flag as false
    with 5.3 this now returns at max 50, 50  and complete is set as true   always
    I have not yet found anything from Blizzard as to why/how they changed this return result for GenNumWhoResults().

    What version of the product are you using?
    CensusPlus addon has been using whoLib 2.0.117 since the only change with that and .122 is the change to the minor version number
    otherwise the LibWho-2.0.lua is identical.

    Do you have an error log of what happened?

    Please provide any additional information below.
    Currently CensusPlus has reverted to using the default api which means it can conflict with Wim and other libwho users. If we can get an update that again enables valid complete flag returns, I'll reset CensusPlus back to using LibWho.

  • left2hand4dark added the tags New Defect May 22, 2013
  • _ForgeUser8012253 posted a comment May 23, 2013

    Change line 507 in "LibWho-2.0.lua"

    From:

    local complete = self.Total == #self.Result
    

    To:

    local complete = (self.Total == #self.Result) and (self.Total < MAX_WHOS_FROM_SERVER)
    

    I tested this out with CensusPlus and it looked like it worked. Hope this helps.

  • left2hand4dark posted a comment May 23, 2013

    @esiemiat: Go

    unfortunately that doesn't work as the Blizzard variable as defined in FriendsFrame.lua is MAX_WHOS_FROM_SERVER = 50. the code would have to be MAX_WHOS_FROM_SERVER - 1


    Edited May 23, 2013
  • sylvanaar removed a tag New May 30, 2013
  • sylvanaar added a tag Accepted May 30, 2013
  • sylvanaar removed a tag Accepted May 30, 2013
  • sylvanaar added a tag Started May 30, 2013
  • sylvanaar posted a comment May 30, 2013

    Revision: 123 Author: sylvanaar Date: Thursday, May 30, 2013 6:08:47 PM Message: Suggested change by esiemiat. Need to test.


    Modified : /trunk/LibWho-2.0/LibWho-2.0.lua


To post a comment, please login or register a new account.