WowAce

Completely stopped working after 7.3. Loved this addon.

Everyone is aware. Please read below for a patch to make it work again.

Please fix.

Can this be updated for 7.3 here on Curse please? Thank you!

There is an alpha version on the project site for 7.3.

The only problem is a syntax error in localization-ptBR.lua in line 73.

Just comment this line and the version works fine.

Can you show what line you mean please? Pretty certain my line 73 is already commented out but im still getting an error :) 

!! WARNING TO PEOPLE WHO WANT TO USE THE r250 alpha !!

I got a TON of errors besides the localization one (fixed it as you suggested ty). I was about to submit a ticket but figured i should do my due diligence first. on a hunch, i renamed my saved variables to force Bankitems to make new ones, and lo and behold, all the errors were gone! they were things like "attempt to perform arithmetic on local 'numBonusIDs' (a nil value)" "attempt to upvalue something on bag101?" 4 errors in total, but the last error had an infinite never-ending count. O_o

anyways. starting fresh with new saved variables MIGHT be poeples option if they decide to use the r250 Alpha. so plz be AWARE!! make backups!

i don't mind it so much. just gotta login to everyone again. nothing critical for me. but i couldn't stop getting infinite errors on my toon if i kept my old variables. :(

i still have my old variables if people want the exact errors i got. i can re-enable them and login to trigger them. :p

You are right.

With the versions for 7.x the storage of BankItems data changed.

I had the same problem a year ago, when i first used an alpha version for 7.0.3. (didn't remember this, when i wrote the comment)

But as you mentioned it is not a big deal.

Just remove the BankItems.lua file from SavedVariables and login with ervery character, so the data will be generated again in the new format.

Hey, can I ask where is this alpha version at? I went to the project site link above and I'm not seeing anything for the last few years except some comments asking for help with no answers. Looking up curseforge & bankitems brought me to the same place, so I'm wondering if someone can link me or point me in the right direction! Thanks <3

The project site is here: https://www.wowace.com/projects/bank-items/files/2471265

Thank you so much! :D

Quote from LarryWowAce >>

You are right.

With the versions for 7.x the storage of BankItems data changed.

I had the same problem a year ago, when i first used an alpha version for 7.0.3. (didn't remember this, when i wrote the comment)

But as you mentioned it is not a big deal.

Just remove the BankItems.lua file from SavedVariables and login with ervery character, so the data will be generated again in the new format.

 

 

So this addon broke for me in 7.3 - I tried without it but missed it, so I've got it working with the below patch (I also recommending incorporating fredefup's fix for mail item count):

Line 870:
-		PlaySound("igBackPackOpen")
+		PlaySound(SOUNDKIT.IG_BACKPACK_OPEN)

Line 895:
-	PlaySound("igBackPackClose")
+	PlaySound(SOUNDKIT.IG_BACKPACK_CLOSE)

Line 1037:
-	PlaySound("igMainMenuOpen")
+	PlaySound(SOUNDKIT.IG_MAINMENU_OPEN)

Line 1042:
-	PlaySound("igMainMenuOpen")
+	PlaySound(SOUNDKIT.IG_MAINMENU_CLOSE)

Line 1276:
-	PlaySound("GuildVaultOpen")
+	PlaySound(SOUNDKIT.GUILD_VAULT_OPEN)

Line 1280:
-	PlaySound("GuildVaultClose")
+	PlaySound(SOUNDKIT.GUILD_VAULT_CLOSE)

Line 1348:
-	PlaySound("igMainMenuOpen")
+	PlaySound(SOUNDKIT.IG_MAINMENU_OPEN)

Line 1353:
-	PlaySound("igMainMenuClose")
+	PlaySound(SOUNDKIT.IG_MAINMENU_CLOSE)

Line 1383:
-	PlaySound("UI_EtherealWindow_Open")
+	PlaySound(SOUNDKIT.UI_ETHEREAL_WINDOW_OPEN)

Line 1388:
-	PlaySound("UI_EtherealWindow_Close")
+	PlaySound(SOUNDKIT.UI_ETHEREAL_WINDOW_CLOSE)

Line 1739:
-			PlaySound("igMainMenuOptionCheckBoxOff")
+			PlaySound(SOUNDKIT.IG_MAINMENU_OPTION_CHECKBOX_ON)

Line 1743:
-			PlaySound("igMainMenuOptionCheckBoxOn")
+			PlaySound(SOUNDKIT.IG_MAINMENU_OPTION_CHECKBOX_OFF)

Line 1767:
-			PlaySound("igMainMenuOptionCheckBoxOff")
+			PlaySound(SOUNDKIT.IG_MAINMENU_OPTION_CHECKBOX_OFF)

Line 1769:
-			PlaySound("igMainMenuOptionCheckBoxOn")
+			PlaySound(SOUNDKIT.IG_MAINMENU_OPTION_CHECKBOX_ON)

Line 2074:
-			PlaySound("igMainMenuOptionCheckBoxOff")
+			PlaySound(SOUNDKIT.IG_MAINMENU_OPTION_CHECKBOX_OFF)

Line 2078:
-			PlaySound("igMainMenuOptionCheckBoxOn")
+			PlaySound(SOUNDKIT.IG_MAINMENU_OPTION_CHECKBOX_ON)

Line 2100:
-			PlaySound("igMainMenuOptionCheckBoxOff")
+			PlaySound(SOUNDKIT.IG_MAINMENU_OPTION_CHECKBOX_OFF)

Line 2102:
-			PlaySound("igMainMenuOptionCheckBoxOn")
+			PlaySound(SOUNDKIT.IG_MAINMENU_OPTION_CHECKBOX_ON)

Good work, 

I appreciate the work you have put into getting this addon to work again. This fix works perfectly on version 6.1.0. Make sure that is the version you have before applying this fix. I had made the mistake of installing the newest alpha version and this code does not work with it. I guess newer isn't always better.

Made the changes to 6.1.0 but it's still broken.  Doesn't show the items in the bank at all.  It shows items in bags in the bank, but won't show the items in the bank or the reagent bank.  This is even after visiting a bank.  When I turn on errors, I get lots of errors:

Message: Interface\AddOns\BankItems\BankItems.lua:1037: Usage: PlaySound(soundKitID, optional["SFX","Music","Ambience", "Dialog" or "Master"], [forceNoDuplicates, runFinishCallback])
Time: Sun Sep 3 18:29:59 2017
Count: 2
Stack: Interface\AddOns\BankItems\BankItems.lua:1037: Usage: PlaySound(soundKitID, optional["SFX","Music","Ambience", "Dialog" or "Master"], [forceNoDuplicates, runFinishCallback])
[C]: ?
[C]: in function `PlaySound'
Interface\AddOns\BankItems\BankItems.lua:1037: in function <Interface\AddOns\BankItems\BankItems.lua:1034>
[C]: in function `Show'
Interface\FrameXML\UIParent.lua:2441: in function `SetUIPanel'
Interface\FrameXML\UIParent.lua:2282: in function `ShowUIPanel'
Interface\FrameXML\UIParent.lua:2151: in function <Interface\FrameXML\UIParent.lua:2147>
[C]: in function `SetAttribute'
Interface\FrameXML\UIParent.lua:2935: in function `ShowUIPanel'
Interface\AddOns\BankItems\BankItems.lua:3074: in function `BankItems_SlashHandler'
Interface\AddOns\BankItems\BankItems.lua:6022: in function <Interface\AddOns\BankItems\BankItems.lua:6021>

Locals:

Next page:

Message: Interface\AddOns\BankItems\BankItems.lua:1042: Usage: PlaySound(soundKitID, optional["SFX","Music","Ambience", "Dialog" or "Master"], [forceNoDuplicates, runFinishCallback])
Time: Sun Sep 3 18:29:53 2017
Count: 1
Stack: Interface\AddOns\BankItems\BankItems.lua:1042: Usage: PlaySound(soundKitID, optional["SFX","Music","Ambience", "Dialog" or "Master"], [forceNoDuplicates, runFinishCallback])
[C]: ?
[C]: in function `PlaySound'
Interface\AddOns\BankItems\BankItems.lua:1042: in function <Interface\AddOns\BankItems\BankItems.lua:1041>
[C]: in function `Hide'
Interface\FrameXML\UIParent.lua:2425: in function `SetUIPanel'
Interface\FrameXML\UIParent.lua:2501: in function `HideUIPanel'
Interface\FrameXML\UIParent.lua:2155: in function <Interface\FrameXML\UIParent.lua:2147>
[C]: in function `SetAttribute'
Interface\FrameXML\UIParent.lua:2951: in function `HideUIPanel'
Interface\AddOns\BankItems\BankItems.lua:1560: in function <Interface\AddOns\BankItems\BankItems.lua:1559>

Locals:

FWIW, lines 1037 and 1042 look like they should according to the post above.

This looks like the same error I had before I changed lines 1037 & 1042 to PlaySound(SOUNDKIT.IG_MAINMENU_OPEN) & PlaySound(SOUNDKIT.IG_MAINMENU_CLOSE).

Sorry the fix didn't work for you, it is working for me with the above lines.

For those who want the mail-count to work again, change the following in Bankitems.lua:

Line: 3452

From:  local name, itemTexture, count, quality, canUse

To:       local name, itemID, itemTexture, count, quality, canUse

Line: 3467

From: name, itemTexture, count, quality, canUse = GetInboxItem(i, k)

To:      name, itemID, itemTexture, count, quality, canUse = GetInboxItem(i, k)

Line: 4950

From: local name, _, count = GetInboxItem(index, i)

To:      local name, _, _, count = GetInboxItem(index, i)

You need to look into all your mailboxes that shows wrong numbers in the tooltip to have the numbers refreshed correctly.

I have no solution for the guildbank-tooltip issue or the LUA-errors.

Hi  :)

Yes, please update. . .I Love, LOve, LOVE this addon !!

I get several LUA errors when opening tabs, etc.  If you need a copy of any of these, please let me know and I'll be happy to copy and paste these to a document and email it to you !!