WowAce

I posted an error under the Tickets tab.

http://www.wowace.com/addons/cosplay/tickets/4-cosplay-error-upon-weapon-inspection/

New error has of the 5.0.4 patch.

 

Message: Interface\FrameXML\ModelFrames.lua:311: attempt to index local 'frame' (a nil value) Time: 08/30/12 08:45:04 Count: 1 Stack: Interface\FrameXML\ModelFrames.lua:311: in function `SetDressUpBackground' Interface\AddOns\Cosplay\Cosplay.lua:104: in function `Reset' Interface\AddOns\Cosplay\Cosplay.lua:74: in function <Interface\AddOns\Cosplay\Cosplay.lua:73> [C]: in function `Show' Interface\FrameXML\UIParent.lua:1738: in function `SetUIPanel' Interface\FrameXML\UIParent.lua:1572: in function `ShowUIPanel' Interface\FrameXML\UIParent.lua:1469: in function <Interface\FrameXML\UIParent.lua:1465> [C]: in function `SetAttribute' Interface\FrameXML\UIParent.lua:2179: in function `ShowUIPanel' Interface\FrameXML\ModelFrames.lua:259: in function <Interface\FrameXML\ModelFrames.lua:235> (tail call): ? [string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>

Locals: frame = nil fileName = nil texture = "Interface\DressUpFrame\DressUpBackground-Orc" (*temporary) = "Orc" (*temporary) = "Interface\DressUpFrame\DressUpBackground-Orc" (*temporary) = "Orc" (*temporary) = nil (*temporary) = "attempt to index local 'frame' (a nil value)"

The problem appears to be the "SetDressUpBackground()" function, line 104, that is causing the error I am experiencing.  I can only guess that with 5.0.4 new functionality was added to this function, resulting in the error being thrown. Commenting out the line appears to do nothing important, and the addon works fine.

If someone has any idea what this function actually does, and how to fix it, I'd be happy to listen.

Update for patch 5.0.4 please!

Help137 thanks for the fixes!

And here is the fix for the Auction House errors

Replace lines 85 - 100 with the following:

-K

 

function Cosplay:CreateAHButtons()
    if not AHButtonsCreated then
        local AuctionDUFUndressButton = CreateFrame("Button", "ADUFUndressButton", SideDressUpModel, "UIPanelButtonTemplate")        
        ADUFUndressButton:SetWidth(70)
        ADUFUndressButton:SetHeight(22)
        ADUFUndressButton:SetText(L["Undress"])
        ADUFUndressButton:SetPoint("BOTTOM", "SideDressUpModelResetButton", "TOP", 0, 2)
        ADUFUndressButton:SetScript("OnClick", function()
            SideDressUpModel:Undress()
            PlaySound("gsTitleOptionOK")
        end)

        AHButtonsCreated = true
    end
    self:UnregisterEvent("AUCTION_HOUSE_SHOW")
end

Assuming you're using the latest version, just comment out lines 141 & 142. If you don't have an editor with line numbers, look for the code below. Blizzard appears to have substantially changed the buttons in the paper doll window and it's no longer possible to hide them in this manor. Personally, having the buttons at the top doesn't bother me and it certainly bothers me less than an error every time I log in. If phyber doens't turn up here in another week or two to at least say hello, I'll post a fan update version on WI with the fix already in it.


-K


local function MakeRotatable()
    local f = DressUpModel
    -- Hide the rotation buttons
--    DressUpModelRotateLeftButton:Hide()
--    DressUpModelRotateRightButton:Hide()

 

Well Grizzly, I'm sure he's just terrified at that threat. I mean, think of all the money he'll loose if you stop using his add-ons... I'm sure he doesn't have a real life or anything else that might get in the way of him updating these.  And this one, I mean, you just can't raid without it! 

Get Real.

Get a Life.

Don't let the door hit you on the way out.

 

-K

 

Ever heard the saying about sarcasm being the lowest form of wit?

I fully understand there can be any number of reasons for any addon author to be absent for a period of time, but in this case the simple fact that phyber updated 8 other addons when 4.3 released clearly showed activity! Lack of response from any addon author is generally not a good indication for continued future support. If addon authors want to release their creations into the public domain then they should be prepared to handle criticism from time to time!

However, I certainly can accept that my previous comment was rather badly worded so I'll edit it to soften the comments to try and prevent causing any offence to anyone!

A week after patch 4.3 and this still hasn't been fixed and updated to work with patch 4.3! Checking the Project Site reveals a ticket from 14th November 2011 reporting the initial log-in error from the PTR but phyber hasn't even bothered to do anything about that ticket! I'm wondering why phyber appears to have chosen to ignore some of his addons, checking his Projects page shows a number of other addons that haven't been fixed and updated for patch 4.3 yet. Starting to think it may be time to just find alternatives that are actively maintained by their authors!

Seems that phyber has updated 8 of his other addons since 4.3 was released, so he's still active. Hopefully he'll get around to fixing this one in the next few days.

Ran into another error when logging in.

Date: 2011-11-30 19:59:08
ID: 2
Error occured in: Global
Count: 1
Message: ..\AddOns\Cosplay\Cosplay.lua line 91:
   ADUFUndressButton:SetPoint(): Couldn't find region named 'AuctionDressUpFrameResetButton'
Debug:
   (tail call): ?
   [C]: SetPoint()
   Cosplay\Cosplay.lua:91: ?()
   ...ore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147:
      ...ore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:147
   [string "safecall Dispatcher[1]"]:4:
      [string "safecall Dispatcher[1]"]:4
   [C]: ?
   [string "safecall Dispatcher[1]"]:13: ?()
   ...ore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:92: Fire()
   ...\AddOns\DataStore\libs\AceEvent-3.0\AceEvent-3.0.lua:120:
      ...\AddOns\DataStore\libs\AceEvent-3.0\AceEvent-3.0.lua:119
AddOns:

Update for 4.3 needed :-)

Date: 2011-11-30 09:42:24
ID: 3
Error occured in: Global
Count: 1
Message: ..\AddOns\Cosplay\Cosplay.lua line 141:
   attempt to index global 'DressUpModelRotateLeftButton' (a nil value)
Debug:
   (tail call): ?
   Cosplay\Cosplay.lua:141:
      Cosplay\Cosplay.lua:138
   Cosplay\Cosplay.lua:182: ToggleRotatable()
   Cosplay\Cosplay.lua:224:
      Cosplay\Cosplay.lua:216
   (tail call): ?
   [C]: ?
   [string "safecall Dispatcher[1]"]:9:
      [string "safecall Dispatcher[1]"]:5
   (tail call): ?
   Ace3\AceAddon-3.0\AceAddon-3.0.lua:543: EnableAddon()
   Ace3\AceAddon-3.0\AceAddon-3.0.lua:636:
      Ace3\AceAddon-3.0\AceAddon-3.0.lua:621
   [C]: LoadAddOn()
   ..\FrameXML\UIParent.lua:274: UIParentLoadAddOn()
   ..\FrameXML\UIParent.lua:297: CombatLog_LoadUI()
   ..\FrameXML\UIParent.lua:616:
      ..\FrameXML\UIParent.lua:582

Simple fix. Open cosplay.lua and do a search and replace. Search for the word "this" and replace it with the word "self". Don't include the quotes.

I searched and searched fir "this" but can't find any.

Really? You didn't find any occurences of "this" in cosplay.lua? I found 14 occurences when I searched it! Don't include the quotes in your search!

@ kalimash: Do all 14 occurences of "this" need to be replaced?

Any plan to update this addon to 4.0.1 and Cataclysm? I miss my undress button. ^^

Don't know why Blizz never included such a simple little feature :(

Thank YOU for the addon!! A must have for anyone who cares about how their character looks, or will look with certain gear on!

love this addon *loud gnomish kiss sound*